Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release mc-4.8.27 #4179

Closed
mc-butler opened this issue Jan 21, 2021 · 36 comments
Closed

Prepare for release mc-4.8.27 #4179

mc-butler opened this issue Jan 21, 2021 · 36 comments
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4179
Reporter zaytsev (@zyv)

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 17:43 UTC (comment 1)

Branch: 4179_cleanup
Initial [f4d59a44493162248efa7e1d44ec9f21d449a48f]

@mc-butler
Copy link
Author

Changed by and on Mar 9, 2021 at 15:00 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 9, 2021 at 15:00 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 9, 2021 at 15:00 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 9, 2021 at 15:00 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 13, 2021 at 8:52 UTC (comment 2)

mc-4179-fix-lto-type-mismatch-warning.patch​: applied.
mc-4179-hex_translate_to_regex.c-fix-maybe-uninitialize-warning.patch​: applied.
mc-4179-libcheck-fail-deprecated.patch​: applied.
mc-4179-libcheck-fail_unless-deprecated.patch​: applied.

Thanks!

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 17:04 UTC (comment 3)

  • Branch state changed from no branch to merged

Merged to master: [f223210].

git log pretty=oneline 318981535..f223210dc

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 17:05 UTC (comment 4)

  • Branch state changed from merged to no branch

@mc-butler
Copy link
Author

Changed by and on Mar 14, 2021 at 17:09 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 14, 2021 at 17:09 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 14, 2021 at 17:09 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 14, 2021 at 17:09 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 17:40 UTC (comment 5)

mc-4179-chattr.c-fix-cast-qual-warning.patch​: applied.
mc-4179-extfs.c-fix-cast-qual-warning.patch​​: applied.
mc-4179-filegui.c-fix-cast-qual-warning.patch​: applied.
mc-4179-group.c-fix-cast-qual-warning.patch​: applied.

Thanks!

Branch: 4179_cleanup
Initial [b31642cdd0a527f40786cff491666f1ac8fba4e1]

@mc-butler
Copy link
Author

Changed by and on Mar 27, 2021 at 15:48 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 27, 2021 at 15:48 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 27, 2021 at 15:49 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 27, 2021 at 15:49 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 28, 2021 at 7:46 UTC (comment 6)

mc-4179-input.c-fix-cast-qual-warning.patch​,
mc-4179-internal.c-fix-cast-qual-warning.patch​,
mc-4179-menu.c-fix-cast-qual-warning.patch​,
mc-4179-panel.c-fix-cast-qual-warning.patch​ squashed to one commit.

@mc-butler
Copy link
Author

Changed by and on May 18, 2021 at 17:35 UTC

@mc-butler
Copy link
Author

Changed by and on May 18, 2021 at 17:35 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 23, 2021 at 8:14 UTC (comment 7)

mc-4179-cid-background.c-fix-argument-cannot-be-negative.patch​

I think the following patch is more simple:

diff --git a/src/background.c b/src/background.c
index 584cd74ef..b5c64a5d0 100644
--- a/src/background.c
+++ b/src/background.c
@@ -281,10 +281,10 @@ background_attention (int fd, void *closure)
 
     if (to_child_fd == -1)
         message (D_ERROR, background_process_error, "%s", _("Unknown error in child"));
-
-    /* Handle the call */
-    if (type == Return_Integer)
+    else if (type == Return_Integer)
     {
+        /* Handle the call */
+
         int result = 0;
 
         if (have_ctx == 0)

mc-4179-cid-editcmd.c-fix-dereference-before-null-check.patch

I think the test

   if (edit->search == NULL)

in edit_do_search() can be just removed or replaced with assert to catch such case (can it occurs?).

@mc-butler
Copy link
Author

Changed by and on May 24, 2021 at 17:11 UTC (comment 8)

yes, your approach is more nice and simple. :)

@mc-butler
Copy link
Author

Changed by and on May 24, 2021 at 17:15 UTC

@mc-butler
Copy link
Author

Changed by and on May 24, 2021 at 17:15 UTC

@mc-butler
Copy link
Author

Changed by and on May 24, 2021 at 17:15 UTC

@mc-butler
Copy link
Author

Changed by and on May 24, 2021 at 17:15 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 28, 2021 at 6:27 UTC (comment 9)

mc-4179-file.c-fix-deadcode.deadstores-warning.patch

Probably something is incorrect in fix of #4027. Extra testing is required.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 28, 2021 at 6:44 UTC (comment 10)

mc-4179-cid-background.c-fix-argument-cannot-be-negative.patch​: done
mc-4179-cid-editcmd.c-fix-dereference-before-null-check.patch​: done
mc-4179-editdraw.c-fix-deadcode.deadstores-warning.patch​: done
mc-4179-editsearch.c-fix-deadcode.deadstores-warning.patch​: done
mc-4179-syntax.c-fix-deadcode.deadstores-warning.patch​: done

@mc-butler
Copy link
Author

Changed by and on May 30, 2021 at 14:42 UTC

@mc-butler
Copy link
Author

Changed by and on May 30, 2021 at 14:42 UTC

@mc-butler
Copy link
Author

Changed by and on May 30, 2021 at 14:42 UTC

@mc-butler
Copy link
Author

Changed by and on May 30, 2021 at 14:42 UTC

@mc-butler
Copy link
Author

Changed by and on May 30, 2021 at 14:42 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 2, 2021 at 6:18 UTC (comment 11)

mc-4179-cid-dir.c-fix-resource-leak.patch​: done
mc-4179-cid-ext.c-fix-resource-leak.patch​: done
mc-4179-cid-hotlist.c-fix-use-after-free.patch​: done
mc-4179-cid-serialize.c-fix-resource-leak.patch​: done
mc-4179-cid-vfs_class.c-fix-double-free.patch​: first free is the bug, not second one.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 20, 2021 at 13:23 UTC (comment 12)

  • Votes set to committed-master
  • Branch state changed from no branch to merged

Merged to master: [a81f1ca]

git log --pretty=oneline 77545fbb6..a81f1ca19

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 15, 2021 at 14:36 UTC (comment 13)

  • Status changed from new to closed
  • Resolution set to fixed

prepare repository for release
download PO-translations from Transifex.net
store translations in git repo
download the hint translations from Transifex.net
store translations in git repo

done

create new NEWS wiki page for next version

NEWS-4.8.28

add content of current NEWS wiki page to the doc/NEWS file
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files
make checksums for archives

done

upload source packages and checksums to the special upload area

skipped

developers should download tarballs, verify checksums, compile and install locally

done

upload source packages and checksums
run command
update Wiki start page
write an announcement

done

create new ticket

#4270

close ticket for release
close current milestone

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.27
Development

No branches or pull requests
1 participant
@mc-butler