Compile failure on OS X 10.9.5

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4181
Reporter	kroleg (krolega@….ru)
Mentions	kybl (@kybl)

tty-ncurses.c:556:5: error: unknown type name 'cchar_t'; did you mean 'wchar_t'?
    cchar_t *ctext;
    ^~~~~~~
    wchar_t
/usr/include/sys/_types/_wchar_t.h:33:26: note: 'wchar_t' declared here
typedef __darwin_wchar_t wchar_t;
                         ^
tty-ncurses.c:565:31: error: use of undeclared identifier 'cchar_t'; did you mean 'wchar_t'?
    ctext = g_malloc (sizeof (cchar_t) * (cols + 1));
                              ^
/usr/include/sys/_types/_wchar_t.h:33:26: note: 'wchar_t' declared here
typedef __darwin_wchar_t wchar_t;
                         ^
tty-ncurses.c:569:9: warning: implicit declaration of function 'mvin_wchnstr' is invalid in C99
      [-Wimplicit-function-declaration]
        mvin_wchnstr (y + row, x, ctext, cols);
        ^
tty-ncurses.c:573:13: warning: implicit declaration of function 'getcchar' is invalid in C99
      [-Wimplicit-function-declaration]
            getcchar (&ctext[col], wch, &attrs, &color_pair, NULL);
            ^
tty-ncurses.c:574:13: warning: implicit declaration of function 'setcchar' is invalid in C99
      [-Wimplicit-function-declaration]
            setcchar (&ctext[col], wch, attrs, color, NULL);
            ^
tty-ncurses.c:577:9: warning: implicit declaration of function 'mvadd_wchnstr' is invalid in C99
      [-Wimplicit-function-declaration]
        mvadd_wchnstr (y + row, x, ctext, cols);
        ^
9 warnings and 2 errors generated.
make[3]: *** [tty-ncurses.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
mc-4.8.26-x86_64-ncurses build error 
bash-4.4$ 

Note

Original attachments:

• mc-4.8.26-ncurses.patch (raw) by andrew_b (@aborodin) on Jan 23, 2021 at 12:11 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 4:16 UTC (comment 1)

• Version changed from master to 4.8.26
• Cc set to kybl

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 12:11 UTC

• Attachment mc-4.8.26-ncurses.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 12:13 UTC (comment 2)

@kroleg, please try mc-4.8.26-ncurses.patch.

[mc-butler]

Changed by kroleg (krolega@….ru) on Jan 23, 2021 at 18:26 UTC (comment 2.3)

Replying to andrew_b:

@kroleg, please try mc-4.8.26-ncurses.patch.

Building mc-4.8.26-ncurses completed successfully. Thank you.

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 18:30 UTC (comment 3.4)

Replying to kroleg:

Building mc-4.8.26-ncurses completed successfully. Thank you.

Does it works correctly (I mean #4102)?

[mc-butler]

Changed by kroleg (krolega@….ru) on Jan 23, 2021 at 19:45 UTC (comment 4.5)

Replying to andrew_b:

Replying to kroleg:

Building mc-4.8.26-ncurses completed successfully. Thank you.

Does it works correctly (I mean #4102)?

Yes, shadows work great!
Beautifully )

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 24, 2021 at 11:22 UTC (comment 6)

• Owner set to andrew_b
• Branch state changed from no branch to on review
• Status changed from new to accepted
• Milestone changed from Future Releases to 4.8.27

Branch: 4182_osx_ncurses_ftbfs.
[ba62dd3]

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 24, 2021 at 11:22 UTC (comment 7)

• Branch state changed from on review to approved
• Votes set to kroleg andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 24, 2021 at 11:24 UTC (comment 8)

• Resolution set to fixed
• Votes changed from kroleg andrew_b to committed-master
• Status changed from accepted to testing
• Branch state changed from approved to merged

Merged to master: [25bc8a6].

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 24, 2021 at 11:25 UTC (comment 9)

• Status changed from testing to closed

[mc-butler]

Changed by kybl (@kybl) on Jan 25, 2021 at 8:38 UTC (comment 10)

Thanks for the patch! I don't have OS X so I did not have a chance to try it. Sorry for that :-)

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 25, 2021 at 8:43 UTC (comment 10.11)

Replying to kybl:

Thanks for the patch! I don't have OS X

I don't have too.

so I did not have a chance to try it. Sorry for that :-)

I googled a email with useful info.