[patch] WindowCascade action

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4184
Reporter	psprint (sg44567@….com)
Keywords	windows, cascade

Hi!
I've implemented the main part of the requested non-fullscreen mode startup (see post).

The patch is fairly simple. It just:

• registers the command in keybind.h/.c/*-defaults.c/mc.default.keymap,
• then adds the case for it in editwidget.c,
• and also a function + a helper function in the same file to implement it.

The implementation is a simple loop that arranges the windows in cascade arrangement. It's somewhat intelligent as it gradually lowers the shift between windows as seen in the asciicast.

Note

Original attachments:

• WindowCascade.patch (raw) by psprint (sg44567@….com) on Jan 23, 2021 at 20:45 UTC
• WindowCascadeTiled___-w_-T_opts___menus___man_doc.patch (raw) by psprint (sg44567@….com) on Jan 24, 2021 at 6:07 UTC
• WindowCascadeTiled__-w_-T_opts__menus__man_doc.patch (raw) by psprint (sg44567@….com) on Jan 24, 2021 at 8:14 UTC

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 23, 2021 at 20:45 UTC

• Attachment WindowCascade.patch (raw) added

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 23, 2021 at 20:48 UTC

• Blocking set to #4185

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 24, 2021 at 3:54 UTC

• Blocking changed from #4185 to #4185, #4186

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 24, 2021 at 6:07 UTC (comment 3)

Following comment:2:#4186 I've merged the #4185-4186 's into this one. Patch is attached. I've also:

• added man documentation of -w/--cascade -T/--tile options,
• extended Window menu with the two arrangement commands,
• wrapped the options structures extension with #ifdef USE_INTERNAL_EDIT.

IMO -w is a very good option – it's read as "-w(indowed)". All other possible options like -c, -C are already taken, so the -w is quite a lucky last resort.

It would be difficult to add options just for mcedit as the code doesn't have such option-palette (like e.g.: --help-terminal). Plus the fact that mc has the option -e which basically works like the mcedit symlink – so it has sense to include -w/-T in general options.

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 24, 2021 at 6:07 UTC

• Attachment WindowCascadeTiled___-w_-T_opts___menus___man_doc.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 24, 2021 at 6:25 UTC (comment 3.4)

Replying to psprint:

IMO -w is a very good option – it's read as "-w(indowed)".

"windowed" != "cascade"

Why misc/mc.default.emacs is ignored?

Reduce variable scope as much as possible.

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 24, 2021 at 6:56 UTC (comment 5)

For me -w seems natural for the cascade view… But I'm not going to cling on it, if you have better idea.

I'm attaching a patch with:

• mc.default.emacs extended with the two actions,
• WRect moved to the inner block (are there any other variable scopes that you've meant to limited?)
• some comments added.

[mc-butler]

Changed by psprint (sg44567@….com) on Jan 24, 2021 at 8:14 UTC

• Attachment WindowCascadeTiled__-w_-T_opts__menus__man_doc.patch (raw) added

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:43 UTC

• Blocked by set to #4186
• Blocking changed from #4185, #4186 to #4185

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:45 UTC (comment 7)

• Blocking #4185 deleted