savannah: smbfs performance suffers badly if no username is specified in the URL

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/42
Reporter	ptsekov

Original: http://savannah.gnu.org/bugs/?16216

Submitted by:	Pavel Tsekov <ptsekov>	Submitted on:	Wed 29 Mar 2006 03:07:47 PM UTC
Category:	VFS	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	All

Original submission:

1) From the Left or Right menu select SMB Link

2) Type the hostname of a remote samba server

3) \\Password for \\xxx.xxx.xxx.xxx\IPC$ dialog appears. In the 
Username field type GUEST

4) Navigate to a share and press Enter. Notice how long it takes to 
load the listing

5) Go to a .tar.gz file and hit Enter -> MC will crash

This problem is caused by the fact that smbfs uses a pool of active 
connections which are uniquely identified by their hostname, 
username and sharename. When no user is specified in the url, but 
in the "Password for" dialog and this name is different from the 
current login name, smbfs thinks that we are trying to connect to 
the remote machine with the current login name. This confuses smbfs 
and it doesn't notice that there is a valid connection which can be 
reused - the result is that smbfs opens a new connection each time 
it needs to issue a command to the samba server.
	Pavel Tsekov <ptsekov>
Project Administrator

Comment 1 by Pavel Tsekov <ptsekov> at Thu 30 Mar 2006 09:10:24 AM UTC:

I am attaching a patch.

Note

Original attachments:

• mc-smbfs-dont-trash-connections.patch (raw) by slavazanko (@slavaz) on Dec 25, 2008 at 20:48 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 25, 2008 at 20:48 UTC

• Attachment mc-smbfs-dont-trash-connections.patch (raw) added

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 25, 2008 at 20:57 UTC (comment 1)

• Description edited

[mc-butler]

Changed by styx (@styx) on May 25, 2009 at 6:50 UTC (comment 2)

• Milestone set to future releases

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 25, 2011 at 12:53 UTC (comment 3)

• Severity set to no branch
• Blocked by set to #1

[mc-butler]

Changed by ossi (@ossilator) on Jan 11, 2014 at 16:08 UTC (comment 4)

• Reporter changed from slavazanko to ptsekov
• Description edited
• Branch state set to no branch

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 26, 2021 at 7:10 UTC (comment 5)

• Milestone Future Releases deleted
• Status changed from new to closed
• Version set to master
• Resolution set to invalid

[6f676d0]