Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch][bug] Fix "Find declaration" disrupting file's path #4207

Closed
mc-butler opened this issue Feb 18, 2021 · 5 comments
Closed

[patch][bug] Fix "Find declaration" disrupting file's path #4207

mc-butler opened this issue Feb 18, 2021 · 5 comments
Assignees
@aborodin
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4207
Reporter psprint (sg44567@….com)
Keywords ctags, tags
  • Leaving a file for a TAGS symbol with "Find declaration",
  • and then going back with "Back from declaration",
  • causes filename_vpath in WEdit to be incorrect –
  • it'll have dir_vpath (WEdit) prepended.

That's because the code doesn't check if filename_vpath is already absolute before prepending. This patch fixes this.

asciinema showing the bug.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by psprint (sg44567@….com) on Feb 18, 2021 at 23:01 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 20, 2021 at 6:49 UTC (comment 1)

  • Branch state changed from no branch to on review
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.27

Patch is applied with some modification.

Branch: 4207_tag_declaration
[e64eb397e54c745e62a6eb695bb1ee3670d781c3]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 28, 2021 at 13:51 UTC (comment 2)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 28, 2021 at 13:52 UTC (comment 3)

  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Status changed from accepted to testing
  • Branch state changed from approved to merged

Merged to master: [94588d2].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 28, 2021 at 13:54 UTC (comment 4)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.27
Development

No branches or pull requests
2 participants
@aborodin @mc-butler