User menu entry with %view fails on no-exec filesystem.

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4242
Reporter	lkrotowski (lukasz.krotowski@….com)

When tmp filesystem is no-exec user menu with %view fails to execute with error: can't execute: Permission denied. User menu without %view works fine. It's because in usermenu.c, in execute_menu_command() case without %view on no-exec filesystem is explicitly handled by executing script indirectly with /bin/sh.

Attached (ugly) patch copies that handling to %view case. And it seems to work for me.

Note

Original attachments:

• mc-view-on-no-exec-fs.patch (raw) by lkrotowski (lukasz.krotowski@….com) on May 14, 2021 at 21:48 UTC

[mc-butler]

Changed by lkrotowski (lukasz.krotowski@….com) on May 14, 2021 at 21:48 UTC

• Attachment mc-view-on-no-exec-fs.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on May 16, 2021 at 9:01 UTC (comment 1)

• Milestone changed from Future Releases to 4.8.27
• Status changed from new to accepted
• Owner set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on May 16, 2021 at 9:02 UTC (comment 2)

• Branch state changed from no branch to on review

Branch: 4242_usermenu_view_indirect
Initial [d86bc9a554164fba0cdaface1446119ecd463d0d]

[mc-butler]

Changed by andrew_b (@aborodin) on May 23, 2021 at 7:49 UTC (comment 3)

• Branch state changed from on review to approved
• Votes set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on May 23, 2021 at 7:51 UTC (comment 4)

Merged to master: [83d4966].

git log --pretty=oneline 3a457a2cb..83d496680

[mc-butler]

Changed by andrew_b (@aborodin) on May 23, 2021 at 7:53 UTC (comment 5)

• Resolution set to fixed
• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from andrew_b to committed-master

[mc-butler]

Changed by andrew_b (@aborodin) on May 23, 2021 at 7:53 UTC (comment 6)

• Status changed from testing to closed