Prepare for release mc-4.8.28

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4270
Reporter	zaytsev (@zyv)

Note

Original attachments:

• mc-4270-replace-obsolete-ac_prog_cc_stdc.patch (raw) by and on Dec 22, 2021 at 22:16 UTC
• mc-4270-remove-unused-macros.patch (raw) by and on Dec 22, 2021 at 22:16 UTC
• mc-4270-filegui-fix-cid-331828-331850.patch (raw) by and on Feb 17, 2022 at 18:50 UTC
• mc-4270-filegui-fix-cid-331837.patch (raw) by and on Feb 25, 2022 at 19:41 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 5, 2021 at 12:44 UTC (comment 1)

Branch: 4270_cleanup
Initial [662684d6b0d49a59f785c5a41bdc1f298a8c9370]

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 21, 2021 at 12:13 UTC (comment 2)

• Branch state changed from no branch to merged

Merged to master: [eff779b].

git lof ---pretty=oneline b8262f22e..eff779b24

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 6, 2021 at 18:37 UTC (comment 3)

Branch: 4270_cleanup
Initial [1a093a8125e109807c87280a4ef9ef458020a6a4]

[mc-butler]

Changed by and on Dec 22, 2021 at 22:16 UTC

• Attachment mc-4270-replace-obsolete-ac_prog_cc_stdc.patch (raw) added

[mc-butler]

Changed by and on Dec 22, 2021 at 22:16 UTC

• Attachment mc-4270-remove-unused-macros.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 24, 2021 at 9:37 UTC (comment 4)

mc-4270-remove-unused-macros.patch​: applied.
mc-4270-replace-obsolete-ac_prog_cc_stdc.patch​: applied.
Thanks!

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 28, 2022 at 17:58 UTC

• Blocking set to #4330

[mc-butler]

Changed by and on Feb 14, 2022 at 18:22 UTC (comment 6)

I bump 4270_cleanup at scan.coverity.com to see was new in Coverity 2021.12.1 release.
Looks like coverity view defects login is still broken.

[mc-butler]

Changed by and on Feb 17, 2022 at 18:50 UTC

• Attachment mc-4270-filegui-fix-cid-331828-331850.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 19, 2022 at 15:44 UTC (comment 7)

Thanks! Applied with some modifications.

[mc-butler]

Changed by and on Feb 25, 2022 at 19:41 UTC

• Attachment mc-4270-filegui-fix-cid-331837.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 26, 2022 at 18:23 UTC (comment 8)

Thanks! Applied.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 13, 2022 at 10:32 UTC (comment 9)

Merged to master: [7fe3f4c].

git --log --pretty=oneline cbcda8a28..7fe3f4c89

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 13, 2022 at 10:35 UTC

• Blocking #4330 deleted

(In #4330) Fixed as [185c80f].

[mc-butler]

Changed by zaytsev (@zyv) on Mar 20, 2022 at 12:02 UTC (comment 11)

Hi Andrew,

I get the following warning while building:

../../../src/viewer/coord_cache.c: In function ‘mcview_ccache_add_entry’:
../../../src/viewer/coord_cache.c:97:5: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
   97 |     cache->cache[pos] = g_memdup (entry, sizeof (*entry));
      |     ^~~~~
In file included from /usr/include/glib-2.0/glib.h:82,
                 from ../../../lib/global.h:66,
                 from ../../../src/viewer/coord_cache.c:57:
/usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
  257 | gpointer              g_memdup         (gconstpointer mem,
      |                       ^~~~~~~~

Yury

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 20, 2022 at 13:21 UTC (comment 12)

g_memdup has been deprecated since version 2.68 and should not be used in newly-written code.
Use g_memdup2() instead, as it accepts a gsize argument for byte_size, avoiding the possibility of overflow in a gsize → guint conversion

It's not critical in this case, because sizeof (*entry) is significantly less than SIZE_MAX.
Let's fix that after release.

[mc-butler]

Changed by zaytsev (@zyv) on Mar 21, 2022 at 9:05 UTC (comment 13)

Fine with me - another one from ossie:

> find.c: In function ‘find_cmd’:
> find.c:1837:28: warning: ‘start_dir_len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   1837 |                 p = name + (size_t) start_dir_len;
>        |                            ^~~~~~~~~~~~~~~~~~~~~~
> find.c:1897:13: note: ‘start_dir_len’ was declared here
>   1897 |     ssize_t start_dir_len;
>        |             ^~~~~~~~~~~~~

For the record.

[mc-butler]

Changed by zaytsev (@zyv) on Mar 27, 2022 at 12:18 UTC (comment 14)

• Owner set to zaytsev
• Status changed from new to accepted

prepare repository for release
download PO-translations from Transifex.net
store translations in git repo
download the hint translations from Transifex.net
store translations in git repo
create new NEWS wiki page for next version with empty template

NEWS-4.8.29

add content of current NEWS wiki page to the doc/NEWS file in git repo
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files

done

upload source packages and checksums to the special upload area
developers should download tarballs, verify checksums, compile and install locally

skipped

upload source packages and checksums
run command
update Wiki start page with latest release number

done

[mc-butler]

Changed by zaytsev (@zyv) on Mar 27, 2022 at 13:17 UTC (comment 15)

• Status changed from accepted to testing
• Resolution set to fixed

write an announcement: list user visible changes (bugs and features)

done

create new ticket (type=task, component=adm) for the next release

#4357

close ticket for release
close current milestone

done

[mc-butler]

Changed by zaytsev (@zyv) on Mar 27, 2022 at 13:18 UTC (comment 16)

• Status changed from testing to closed