Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc uses dhotfocus color for selected entry in the history dialog #4274

Closed
mc-butler opened this issue Aug 29, 2021 · 1 comment
Closed

mc uses dhotfocus color for selected entry in the history dialog #4274

mc-butler opened this issue Aug 29, 2021 · 1 comment
Labels
area: skin Theming support and skin files prio: medium Has the potential to affect progress

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4274
Reporter mstilkerich (ms@….de)

Hello,

I am in the process of creating a color scheme based on the solarized colors palette using truecolors.

I noticed that mc uses the dialog.dhotfocus color for the selected entry in the history list. My understanding of this color is it should be used for single hotkey characters, and therefore use for the entire entry in the history list comes unexpected to me.

What I would expect here is the use of dialog.dfocus instead. After all, the non-selected entry also uses the dialog._default_ color, not dialog.dhotnormal which would be the non-focused pendant to dhotfocus.

A screenshot is available here https://github.com/mstilkerich/mc-solarized-truecolor/blob/553183d61c17f310ffb2d0b7beb5a7392f18bc3e/screenshots/dark-truecolor-history-dialog.png.

The corresponding skin file is this:
https://github.com/mstilkerich/mc-solarized-truecolor/blob/553183d61c17f310ffb2d0b7beb5a7392f18bc3e/solarized-dark-truecolor.ini

Is this intended? It doesn't look nicely as normally this color style is only used for single characters.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 29, 2021 at 13:55 UTC (comment 1)

  • Resolution set to duplicate
  • Component changed from mc-core to mc-skin
  • Version changed from 4.8.27 to master
  • Status changed from new to closed
  • Milestone Future Releases deleted

Closed as duplicate of #3160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: skin Theming support and skin files prio: medium Has the potential to affect progress
Development

No branches or pull requests

1 participant