Variable redeclared in filevercmp_test5

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4358
Reporter	ats (ats-mc@….org)

In mc-4.8.28, the test filevercmp_test5 in tests/lib/strutil/filevercmp.c declares:

size_t _i;

However, the name _i is also used inside check's START_TEST macro, so GCC 11.2 complains:

filevercmp.c: In function ‘filevercmp_test5_fn’:
filevercmp.c:356:12: error: ‘_i’ redeclared as different kind of symbol

I've fixed this in the attached patch by renaming _i and _j, but you may prefer a different new name...

Note

Original attachments:

• checki.diff (raw) by ats (ats-mc@….org) on Mar 27, 2022 at 14:44 UTC

[mc-butler]

Changed by ats (ats-mc@….org) on Mar 27, 2022 at 14:44 UTC

• Attachment checki.diff (raw) added

Patch: rename _i/_j to ii/jj

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 27, 2022 at 16:17 UTC (comment 1)

• Component changed from mc-core to tests

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 27, 2022 at 16:49 UTC (comment 2)

• Milestone changed from Future Releases to 4.8.29
• Status changed from new to accepted
• Blocked by set to #4357
• Owner set to andrew_b

Thanks!
Applied in 4357_cleanup branch.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 28, 2022 at 3:28 UTC (comment 3)

Ticket #4359 has been marked as a duplicate of this ticket.

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 5, 2022 at 14:23 UTC (comment 4)

Ticket #4366 has been marked as a duplicate of this ticket.

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 5, 2022 at 16:51 UTC (comment 5)

• Blocked by #4357 deleted

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 5, 2022 at 16:51 UTC (comment 6)

• Resolution set to fixed
• Status changed from accepted to testing

[7435010]

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 5, 2022 at 16:56 UTC (comment 7)

• Status changed from testing to closed