Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-my-posh 13.7.0+ breaks Midnight Commander's subshell #4436

Closed
mc-butler opened this issue Jan 28, 2023 · 2 comments
Closed

oh-my-posh 13.7.0+ breaks Midnight Commander's subshell #4436

mc-butler opened this issue Jan 28, 2023 · 2 comments
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.26 Reproducible in version 4.8.26

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4436
Reporter philip_petev (madmax2000@….com)

Guys, any comments on this one:
JanDeDobbeleer/oh-my-posh#3415

Version 13.7.0 introduced changes in the function that hooks up with the bash prompt and that change causes mc to act like the -u parameter (no subshell) is used or the subshell support was never enabled in the first place.
Now, the oh-my-posh author claims there is nothing wrong on his side and the problem must be on your side.

Tested on:
Debian 11 (amd64, bash 5.1.4, mc 4.8.26)
Ubuntu 22.04.1 (amd64, bash 5.1.16, mc 4.8.27)
my NAS (Linux 4.2.8, aarch64, bash 5.2.15, mc 4.8.29)

Providing config to oh-my-posh or using the stock settings doesn't matter.

Some logs from the Debian machine:

LC_MESSAGES=C mc -V
GNU Midnight Commander 4.8.26
Built with GLib 2.66.8
Built with S-Lang 2.3.2 with terminfo database
With builtin Editor and Aspell support
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;
LC_MESSAGES=C mc -F
Home directory: /home/philip
Profile root directory: /home/philip

[System data]
    Config directory: /etc/mc/
    Data directory:   /usr/share/mc/
    File extension handlers: /usr/lib/mc/ext.d/
    VFS plugins and scripts: /usr/lib/mc/
        extfs.d:        /usr/lib/mc/extfs.d/
        fish:           /usr/lib/mc/fish/

[User data]
    Config directory: /home/philip/.config/mc/
    Data directory:   /home/philip/.local/share/mc/
        skins:          /home/philip/.local/share/mc/skins/
        extfs.d:        /home/philip/.local/share/mc/extfs.d/
        fish:           /home/philip/.local/share/mc/fish/
        mcedit macros:  /home/philip/.local/share/mc/mc.macros
        mcedit external macros: /home/philip/.local/share/mc/mcedit/macros.d/macro.*
    Cache directory:  /home/philip/.cache/mc/
mc --configure-options
 '--build=x86_64-linux-gnu' '--prefix=/usr' '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--sysconfdir=/etc' '--localstatedir=/var' '--disable-option-checking' '--libdir=${prefix}/lib/x86_64-linux-gnu' '--runstatedir=/run' '--disable-maintainer-mode' '--disable-dependency-tracking' 'AWK=awk' 'X11_WWW=x-www-browser' '--libexecdir=/usr/lib' '--with-x' '--with-screen=slang' '--disable-rpath' '--disable-static' '--disable-silent-rules' '--enable-aspell' '--enable-vfs-sftp' '--enable-vfs-undelfs' '--enable-tests' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/mc-xlv0ck/mc-4.8.26=. -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-z,relro -Wl,-z,now -Wl,--as-needed' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2'

I've selected version mc 4.8.26, but it happens pretty much with every version after this one. Can't say are the version before this one affected or not since 4.8.26 is the oldest I've got.

@mc-butler
Copy link
Author

Changed by zaytsev-work (@zyv) on Jan 28, 2023 at 9:47 UTC (comment 1)

  • Resolution set to wontfix
  • Status changed from new to closed

I've commented in GitHub:

JanDeDobbeleer/oh-my-posh#3415 (comment)

Will close this until there is something to do on our side.

@mc-butler
Copy link
Author

Changed by zaytsev-work (@zyv) on Jan 28, 2023 at 9:50 UTC (comment 2)

  • Milestone Future Releases deleted

@mc-butler mc-butler closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.26 Reproducible in version 4.8.26
Development

No branches or pull requests

1 participant