Usage of 'sed' in build system/makefiles is not portable

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4459
Reporter	karlson2k (karlson2k@….com)

In the build system the sed command used with unportable "inplace" options ("-i").
The leads to build failures on some platforms, like Solaris, and reduces portability in general.

Similar issues were fixed already in the past: #3479

The configure script is already detecting suitable sed command in LT_INIT macro, so it worth to use the result of this detection to reduce portability problems.

On the other hand, workaround for "inplace" use is very simple and straightforward, so for the best portability it would be better to avoid unportable sed commands.

POSIX sed specification: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

Suggested fix: #184

Note

Original attachments:

• 0001-configure-add-explicit-sed-detection.patch (raw) by karlson2k (karlson2k@….com) on May 19, 2023 at 17:53 UTC
• 0002-Use-configure-detected-or-user-specified-sed-in-buil.patch (raw) by karlson2k (karlson2k@….com) on May 19, 2023 at 17:53 UTC
• 0003-Replaced-unportable-inplace-sed-command.patch (raw) by karlson2k (karlson2k@….com) on May 19, 2023 at 17:54 UTC

[mc-butler]

Changed by karlson2k (karlson2k@….com) on May 19, 2023 at 17:53 UTC

• Attachment 0001-configure-add-explicit-sed-detection.patch (raw) added

[mc-butler]

Changed by karlson2k (karlson2k@….com) on May 19, 2023 at 17:53 UTC

• Attachment 0002-Use-configure-detected-or-user-specified-sed-in-buil.patch (raw) added

[mc-butler]

Changed by karlson2k (karlson2k@….com) on May 19, 2023 at 17:54 UTC

• Attachment 0003-Replaced-unportable-inplace-sed-command.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on May 19, 2023 at 18:13 UTC (comment 1)

• Status changed from new to accepted
• Milestone changed from Future Releases to 4.8.30
• Component changed from mc-core to compilation
• Owner set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:06 UTC (comment 2)

• Branch state changed from no branch to on review

Branch: 4459_sed
Initial [054a051]

[mc-butler]

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:07 UTC (comment 3)

• Branch state changed from on review to approved
• Votes set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:09 UTC (comment 4)

• Branch state changed from approved to merged
• Votes changed from andrew_b to committed-master
• Status changed from accepted to testing
• Resolution set to fixed

Merged to master: [2e3e3a3].

git log --pretty=oneline e5911c1ef..2e3e3a377

[mc-butler]

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:10 UTC (comment 5)

• Status changed from testing to closed

Thanks for the patches!