Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failed if ncurses used without --with-ncurses-includes= configure parameter #4462

Closed
mc-butler opened this issue May 19, 2023 · 6 comments
Closed

Build failed if ncurses used without --with-ncurses-includes= configure parameter #4462

mc-butler opened this issue May 19, 2023 · 6 comments
Assignees
@aborodin
Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.30

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4462
Reporter karlson2k (karlson2k@….com)

If ncurses location is not specified by configure parameters like '--with-ncurses-includes=/some/dir' then automatic detection at compiler/system default location is used in configure.
With automatic detection the header 'ncurses/term.h' is not checked therefore macro HAVE_NCURSES_TERM_H is not defined.

This leads to inclusion of system <term.h> which is not compatible with ncurses headers.

The simple fix is just addition of ncurses/term.h header detection to configure.

The suggested fix: #186

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by karlson2k (karlson2k@….com) on May 19, 2023 at 18:12 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 19, 2023 at 18:15 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.30
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Component changed from mc-core to compilation

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:47 UTC (comment 2)

  • Branch state changed from no branch to on review

Thanks for the patch!

Branch: 4462_ncurses_includes
[1f732f0]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:48 UTC (comment 3)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:49 UTC (comment 4)

  • Branch state changed from approved to merged
  • Status changed from accepted to testing
  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed

Merged to master: [5c9a145].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 20, 2023 at 17:51 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.30
Development

No branches or pull requests
2 participants
@aborodin @mc-butler