mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4493
Reporter	phil (@tuffnatty)

Note

Original attachments:

• patch-mc-src_vfs_local_Makefile.am.patch (raw) by phil (@tuffnatty) on Aug 19, 2023 at 0:50 UTC
• config.log (raw) by phil (@tuffnatty) on Aug 19, 2023 at 10:31 UTC
• 4493_ext2fs_cppflags.patch (raw) by andrew_b (@aborodin) on Aug 19, 2023 at 13:03 UTC

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 0:50 UTC

• Attachment patch-mc-src_vfs_local_Makefile.am.patch (raw) added

Proposed patch

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 6:16 UTC (comment 1)

There is no such issue on Linux. Please show config.log and output of make.

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 10:31 UTC

• Attachment config.log (raw) added

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 10:32 UTC (comment 2)

Attached config.log. Relevant output of make:

Making all in local                                                                                                                                           
gmake[6]: Entering directory '/usr/home/phil/freebsd-ports/misc/mc/work/mc-4.8.30/src/vfs/local'                                                              
/bin/sh ../../../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../../..  -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/
local/include  -I../../.. -I/usr/local/include  -DLIBICONV_PLUG -I/usr/local/include -I/usr/local/include  -I/usr/local/include  -Wassign-enum -Wbad-function-
cast -Wcomment -Wconditional-uninitialized -Wdeclaration-after-statement -Wfloat-conversion -Wfloat-equal -Wformat -Wformat-security -Wimplicit -Wimplicit-fal
lthrough -Wignored-qualifiers -Wlogical-not-parentheses -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmiss
ing-prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-long -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wwrite-strings  -O2 -pipe  -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -MT local.lo -MD -MP -MF .deps/local.Tpo -c -o local.lo local.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I../../.. -I/usr/local/include -DLIBICONV_PLUG -I/usr/local/include -I/usr/local/include -I/usr/local/include -Wassign-enum -Wbad-function-cast -Wcomment -Wconditional-uninitialized -Wdeclaration-after-statement -Wfloat-conversion -Wfloat-equal -Wformat -Wformat-security -Wimplicit -Wimplicit-fallthrough -Wignored-qualifiers -Wlogical-not-parentheses -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-long -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wwrite-strings -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT local.lo -MD -MP -MF .deps/local.Tpo -c local.c  -fPIC -DPIC -o .libs/local.o
local.c:35:10: fatal error: 'e2p/e2p.h' file not found
#include <e2p/e2p.h>            /* fgetflags(), fsetflags() */
         ^~~~~~~~~~~
1 error generated.
gmake[6]: *** [Makefile:513: local.lo] Error 1

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 10:35 UTC (comment 3)

I simply copied the fix from the other piece of code that uses e2p, src/filemanager/Makefile.am.

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 13:03 UTC

• Attachment 4493_ext2fs_cppflags.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 13:03 UTC (comment 4)

Please test the attached 4493_ext2fs_cppflags.patch.

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 14:09 UTC (comment 4.5)

Replying to andrew_b:

Please test the attached 4493_ext2fs_cppflags.patch.

Thanks, your patch also works fine.

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 17:56 UTC (comment 6)

• Status changed from new to accepted
• Owner set to andrew_b
• Branch state changed from no branch to on review

Branch: 4493_FTBFS_FreeBSD.
[9688e7d]

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 17:57 UTC (comment 7)

• Branch state changed from on review to approved
• Votes set to phil andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 17:58 UTC (comment 8)

• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from phil andrew_b to committed-master
• Resolution set to fixed

Merged to master: [c56c4f6].

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 19, 2023 at 17:59 UTC (comment 9)

• Status changed from testing to closed

[mc-butler]

Changed by phil (@tuffnatty) on Aug 19, 2023 at 18:55 UTC (comment 6.10)

Replying to andrew_b:

Branch: 4493_FTBFS_FreeBSD.
[9688e7d]

Probably it's too late, but there's a typo in your commit message: this is ticket 4493, not the number that ended up in the message.

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 20, 2023 at 8:23 UTC (comment 10.11)

Replying to phil:

Probably it's too late

Unfortunately yes. Commits in the master branch are unmodifiable.

but there's a typo in your commit message: this is ticket 4493

Yet another my such typo. :-(