Clicking on the sort order indicator resets ordering by first column

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4647
Reporter	lumi (luminary@….net)

In the core header, the sort order jumps back from modify time to name - happens when the switch is activated.

Note

Original attachments:

• screen-20250201-122903.mp4 (raw) by lumi (luminary@….net) on Feb 1, 2025 at 11:33 UTC

[mc-butler]

Changed by lumi (luminary@….net) on Feb 1, 2025 at 11:33 UTC

• Attachment screen-20250201-122903.mp4 (raw) added

[mc-butler]

Changed by zaytsev (@zyv) on Feb 1, 2025 at 17:18 UTC (comment 1)

• Summary changed from Core , window ; header jumps back to Clicking on the sort order indicator resets ordering by first column
• Component changed from mc-core to mc-tty

[mc-butler]

Changed by zaytsev (@zyv) on Feb 1, 2025 at 17:39 UTC (comment 2)

• Status changed from new to accepted
• Owner set to zaytsev
• Description edited
• Branch state changed from no branch to on review
• Milestone set to 4.8.34

Branch: 4647_indicator_click_sort_reverse
Changeset: [08125249226671472542acee07cb1f8137a5ea7e]

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 2, 2025 at 11:30 UTC (comment 3)

Mouse clicking area should depend on real width of sort indicator.
I've pushed a fixup.

[mc-butler]

Changed by zaytsev (@zyv) on Feb 2, 2025 at 12:23 UTC (comment 4)

• Votes set to zaytsev

Oh, wow, I didn't realize that the symbol is actually of variable width, thank you!

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 2, 2025 at 12:47 UTC (comment 4.5)

Replying to zaytsev:

Oh, wow, I didn't realize that the symbol is actually of variable width, thank you!

I believe, in 99,99% sort indicator occupies two screen cells, but we should support an any width.

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 2, 2025 at 15:20 UTC (comment 6)

• Votes changed from zaytsev to zaytsev andrew_b
• Branch state changed from on review to approved
• Component changed from mc-tty to mc-core

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 2, 2025 at 15:22 UTC (comment 7)

• Resolution set to fixed
• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from zaytsev andrew_b to committed-master

Merged to master: [0a97ffd].

git log --oneline 7b89c70ba..0a97ffd97

[mc-butler]

Changed by andrew_b (@aborodin) on Feb 2, 2025 at 15:23 UTC (comment 8)

• Status changed from testing to closed