savannah: Config checkboxes not acting on mouse click

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/54
Reporter	egmont (@egmontkob)
Mentions	egmont@….com (@egmontkob)
Keywords	groupbox

Original: http://savannah.gnu.org/bugs/?18689

Submitted by:	Egmont Koblinger <egmont>	Submitted on:	Thu 04 Jan 2007 06:52:40 PM UTC
Category:	None	Severity:	3 - Normal
Status:	Confirmed	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	GNU/Linux

Original submission:

Under Options/Configuration and Options/Layout, checkbox or 
radiobutton options that precede the currently focused widget are 
not clickable with mouse, these mouse clicks are simply ignored.

Example: open the Options/Configuration dialog, click on the 
checkbox of the last option ("safe deLete"), then click on any 
other option with your mouse, this second click will have no 
effect. You have to use the keyboard or close this dialog and open 
again to change these options.

Tested with 4.6.1 and with 2007-01-04-16 snapshot, both on Linux 
console (gpm) and in gnome-terminal. 

Comment 1 by Pavel Tsekov <ptsekov> at Fri 05 Jan 2007 01:40:25 PM UTC:

Oh, well. The mouse event is directed to the groupbox (the frame 
holding other widgets inside it). The bad thing is that the 
groupbox is rather simplistic widget and it doesn't know anything 
about the widgets that are displayed inside it :( IMO, the real 
solution to this problem should involve teaching the groupbox that 
it holds other widgets (i.e. making it a real container widget). A 
simplistic solution would be to skip groupboxes when dispatching 
mouse events.

Note

Original attachments:

• dlg_mouse_event-skip-widget-w-o-action.patch (raw) by sfionov (fionov@….com) on Oct 2, 2009 at 17:44 UTC

[mc-butler]

Changed by styx (@styx) on May 25, 2009 at 7:04 UTC (comment 1)

• Milestone set to future releases

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 18, 2009 at 13:52 UTC (comment 2)

• Severity set to no branch
• Milestone changed from future releases to 4.7.0-pre3

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Sep 22, 2009 at 11:28 UTC (comment 3)

• Milestone changed from 4.7.0-pre3 to 4.7.0-pre5

[mc-butler]

Changed by sfionov (fionov@….com) on Oct 2, 2009 at 17:44 UTC (comment 4)

The trivial fix is to skip widgets that matches coords but does not have an action (usually groupboxes), continuing search of widget with defined action.

[mc-butler]

Changed by sfionov (fionov@….com) on Oct 2, 2009 at 17:44 UTC

• Attachment dlg_mouse_event-skip-widget-w-o-action.patch (raw) added

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 2, 2009 at 21:42 UTC (comment 5)

• Owner set to andrew_b
• Status changed from new to assigned

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 3, 2009 at 13:27 UTC (comment 6)

• Milestone changed from 4.7.0-pre5 to 4.7.0-pre4
• Severity changed from no branch to on review

Created 54_dlg_mouse_handling branch. Parent branch: master.
[85211c5748d85458ffa02812a7ca001a4a3096c8]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Oct 5, 2009 at 7:37 UTC (comment 7)

• Votes set to angel_il
• Keywords set to checkbox

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 5, 2009 at 7:38 UTC (comment 8)

• Keywords changed from checkbox to groupbox

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 5, 2009 at 11:04 UTC (comment 9)

• Votes changed from angel_il to angel_il slavazanko
• Severity changed from on review to approved

Works. Thanks.

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 5, 2009 at 11:13 UTC (comment 10)

• Severity changed from approved to merged
• Votes changed from angel_il slavazanko to commited-master
• Resolution set to fixed
• Status changed from assigned to testing

Merged to master.
[57f9d0e]

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 5, 2009 at 11:13 UTC (comment 11)

• Status changed from testing to closed

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 5, 2009 at 11:13 UTC (comment 12)

• Version set to 4.6.1

[mc-butler]

Changed by ossi (@ossilator) on Jan 11, 2014 at 16:59 UTC (comment 13)

• Reporter changed from slavazanko to egmont
• Branch state set to no branch
• Description edited

[mc-butler]

Changed by egmont (@egmontkob) on Jan 11, 2014 at 23:40 UTC (comment 14)

• Cc set to egmont@….com

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 12, 2014 at 7:32 UTC (comment 15)

• Branch state changed from no branch to merged