savannah: Aborting a FISH file transfer is grossly inefficient

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/68
Reporter	ptsekov
Mentions	god12@….hut.fi

Original: http://savannah.gnu.org/bugs/?19721

Submitted by:	Pavel Tsekov <ptsekov>	Submitted on:	Fri 27 Apr 2007 08:40:45 AM UTC
Category:	VFS	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	All versions	Operating System:	All

Original submission:

I was looking at the fish code recently and noticed that aborting
a running file transfer still causes MC to read the whole file sent 
by the remote end. I realized that the way FISH is currently
implemented, i.e. commands and data sent over the same channel, this
 is the only way to clear the data channel so that command replies 
would get to the FISH layer without re-establishing a new link. 
While this could be acceptable for small transfers I doubt it that 
it makes sens for multi-megabyte files.

Ideas on how to fix it are welcome. One way I can see is to
open a separate FISH connection for the data transfer i.e. like FTP. 

Comment 1 by Oswald Buddenhagen <ossi> at Fri 27 Apr 2007 12:20:17 PM UTC:

no, i think we can do like ssh does, i.e., tunnel multiple virtual 
connections through one physical connection. this adds some 
overhead, though (especially cpu-wise, as we have to call dd for 
every chunk).

btw, you might want to look at kde's fishserv.pl, it has some 
optimizations. never looked at it myself, though.

Comment 2 by Pavel Tsekov <ptsekov> at Fri 27 Apr 2007 01:38:47 PM UTC:

Sounds interesting - I'll take a look at it. My perl is pretty bad 
though - I hope the code is not too complicated.

Comment 3 by Pavel Tsekov <ptsekov> at Wed 02 May 2007 01:20:28 PM UTC:

Unfortunately kde's fish implementation (as found in kioslave/fish 
directory) is not a improvement in this particular case. At least I 
do not see any code which deals with aborting a file transfer 
gracefully. Most likely the connection is just killed.

Comment 4 by Pavel Tsekov <ptsekov> at Mon 07 May 2007 01:06:26 PM UTC:

I've tested the ssh ability to tunnel multiple session over the same
 connection and it works nicely. There is one problem though - it is
 supported only with SSH protocol v2.

Comment 5 by Oswald Buddenhagen <ossi> at Mon 07 May 2007 04:18:32 PM UTC:

huh? you actually used ssh for that? i guess that's a fine optimization.
but for the general case the chunking should be homegrown (based on 
dd and printf/read, i guess).

[mc-butler]

Changed by styx (@styx) on May 25, 2009 at 7:07 UTC (comment 1)

• Milestone set to future releases

[mc-butler]

Changed by metux (@metux) on Sep 14, 2010 at 11:46 UTC (comment 2)

• Severity set to no branch

Is this still valid with the new fish implementation ?

[mc-butler]

Changed by zaytsev (@zyv) on Sep 14, 2010 at 12:58 UTC (comment 3)

Sure it is.

P.S. SSH2+ sounds like a reasonable requirement nowadays.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 13, 2011 at 22:55 UTC (comment 4)

• Owner set to angel_il
• Status changed from new to accepted

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 13, 2011 at 23:06 UTC (comment 5)

branch: 68_fish_abort_file_transfer_fix (parent master)
changeset: 68_fish_abort_file_transfer_fix

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 14, 2011 at 10:32 UTC (comment 6)

• Milestone changed from Future Releases to 4.8.0-pre1
• Version set to master

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 15, 2011 at 16:21 UTC (comment 7)

• Severity changed from no branch to on review

please review

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 7, 2011 at 8:42 UTC (comment 8)

• Severity changed from on review to on rework

Need rebase to current 'master' branch

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 7, 2011 at 20:27 UTC (comment 9)

forced update: 68_fish_abort_file_transfer_fix

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 7, 2011 at 20:29 UTC (comment 10)

• Severity changed from on rework to on review

please review

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 8, 2011 at 9:25 UTC (comment 11)

• Branch state set to on review
• Severity changed from on review to no branch

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 9, 2011 at 14:01 UTC (comment 12)

• Branch state changed from on review to on hold
• Blocked by set to #77

In my point of view, need to resolve #77 issue first, then probably this ticket will be non-actual. If not - we will continue development from this point.

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 6, 2011 at 7:29 UTC (comment 13)

• Milestone changed from 4.8.0-pre1 to Future Releases

[mc-butler]

Changed by ossi (@ossilator) on Jan 5, 2014 at 14:05 UTC (comment 14)

• Summary changed from savannah: Aborting a FISH file transfer still causes the FISH layer to consume the whole file to savannah: Aborting a FISH file transfer is grossly inefficient

[mc-butler]

Changed by ossi (@ossilator) on Jan 11, 2014 at 17:09 UTC (comment 15)

• Description edited
• Reporter changed from slavazanko to ptsekov

[mc-butler]

Changed by god12 (god12@….hut.fi) on Nov 9, 2015 at 12:08 UTC (comment 16)

• Cc set to god12@….hut.fi

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 29, 2016 at 7:22 UTC (comment 17)

• Owner angel_il deleted
• Status changed from accepted to assigned