-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
savannah: "save as" retains mode #82
Comments
|
|
|
|
Pushed as changese:65771004c4948dd664674e8dee2ddce11786d777 to branch:82_sanitize_ro_file_edition.
Please review. |
|
|
|
|
This fix is wrong.
Suppose you have two files, foo and bar. Both files have 444 permissions. Now edit foo and "Save". It can't save and instead prompt you to "Save As". Enter bar. It will chmod bar to 644.
If we don't touch touch existing file permissions for "Save", I don't see why we should for "Save As".
Attached is a patch (against 4.7.0-pre1) which adds S_IWUSR only if different_filename and file does not exist yet. For consistency, it's S_IWUSR not S_IWRITE. |
|
you right :) |
|
ok, dborca is right, i forgot that destination file can has 444 permissions too :) |
|
|
|
|
|
Important
This issue was migrated from Trac:
ossi
(@ossilator)imdagger@….ru
Original: http://savannah.gnu.org/bugs/?23512
Original submission:
Note
Original attachments:
IMDagger
(imdagger@….ru) onAug 9, 2009 at 14:56 UTC
dborca
(dborca@….com) onAug 9, 2009 at 21:17 UTC
The text was updated successfully, but these errors were encountered: