Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

savannah: mc shows wrong metadata for ".." directory #89

Closed
mc-butler opened this issue Dec 26, 2008 · 7 comments
Closed

savannah: mc shows wrong metadata for ".." directory #89

mc-butler opened this issue Dec 26, 2008 · 7 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.6.2 Reproducible in version 4.6.2
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/89
Reporter darkk

Original: http://savannah.gnu.org/bugs/?24808

Submitted by:Leonid Evdokimov <darkk>Submitted on:Tue 11 Nov 2008 08:22:32 AM UTC
Category:Screen outputSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.1Operating System:GNU/Linux

Original submission:

mc always shows 0755 as ".." permissions ­— that's incorrect 
behaviour.
Much better way is to show nothing as mc does not show mtime, size 
and some other attributes of ".." at all.

User, group and some other values are broken too, seems, 
src/screen.c should be patched to check for ".." in more places. 
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 15, 2009 at 10:15 UTC (comment 1)

  • Version set to 4.6.2
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Keywords set to review
  • Milestone set to 4.7

89_parent_dir_metadata is created; parent branch: master.

Solution: display "UP--DIR" in mini-status when ".." is selected.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 17, 2009 at 7:57 UTC (comment 2)

  • Keywords changed from review to review, vote-slavazanko

IMHO good solution. Patch contain comment:

FIXME:
while loading directory (do_load_dir() and do_reload_dir(),
the actual stat info about ".." directory isn't got;
so just don't display incorrect info about ".." directory

I think, not needed to retrieve stat info for '..' directory. What think others?

@mc-butler
Copy link
Author

Changed by styx (@styx) on Mar 23, 2009 at 10:45 UTC (comment 2.3)

  • Keywords changed from review, vote-slavazanko to vote-slavazanko, vote-styx, approved

Replying to slavazanko:

IMHO good solution. Patch contain comment:

FIXME:
while loading directory (do_load_dir() and do_reload_dir(),
the actual stat info about ".." directory isn't got;
so just don't display incorrect info about ".." directory

I think, not needed to retrieve stat info for '..' directory. What think others?

I am agree with you, there is no need to get stat info for '..' directory.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 23, 2009 at 17:04 UTC (comment 4)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Keywords changed from vote-slavazanko, vote-styx, approved to commited-master

@mc-butler
Copy link
Author

Changed by styx (@styx) on Mar 24, 2009 at 7:29 UTC (comment 5)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jan 11, 2014 at 23:05 UTC (comment 6)

  • Branch state set to no branch
  • Description edited
  • Reporter changed from slavazanko to darkk

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 12, 2014 at 7:42 UTC (comment 7)

  • Branch state changed from no branch to merged
  • Votes set to commited-master
  • Keywords commited-master deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.6.2 Reproducible in version 4.6.2
Development

No branches or pull requests

2 participants