segfault-on-invalid-mtime fix

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/96
Reporter	slavazanko (@slavaz)
Mentions	weigelt@….de
Keywords	committed-master, committed-mc-4.6, vote-winnie, vote-slavazanko

Invalid timestamps on files caused mc to segfault by passing a null
pointer to strftime. Avoid trying to print the time in this case.

Source: Gentoo Portage
Reference: mc-4.6.1
Reported-By: Maxim Britov <maxim office modum by>
Reported-Bug: http://bugs.gentoo.org/184296
Submit-By: Enrico Weigelt, metux IT service <weigelt metux de>
Submit-Date: 2008-12-26
State: new

See attachment.

Note

Original attachments:

• segfault-on-invalid-mtime.patch (raw) by slavazanko (@slavaz) on Dec 28, 2008 at 12:14 UTC
• mc-4.6.1-ac-fix-obsolete-ac_aix.diff (raw) by metux (@metux) on Dec 30, 2008 at 1:23 UTC
• mc-4.6.1-timefmt.diff (raw) by metux (@metux) on Jan 6, 2009 at 18:47 UTC
• fix-timefmt-rev2.patch (raw) by winnie (@winnieXY) on Jan 10, 2009 at 10:57 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 28, 2008 at 12:14 UTC

• Attachment segfault-on-invalid-mtime.patch (raw) added

[mc-butler]

Changed by metux (@metux) on Dec 29, 2008 at 0:35 UTC (comment 1)

• Milestone set to Bug Fixing
• Cc set to weigelt@….de
• Priority changed from major to critical

Quite critical, should really go into next release.

[mc-butler]

Changed by metux (@metux) on Dec 30, 2008 at 1:23 UTC

• Attachment mc-4.6.1-ac-fix-obsolete-ac_aix.diff (raw) added

A more deep fix ...

[mc-butler]

Changed by winnie (@winnieXY) on Jan 6, 2009 at 6:23 UTC (comment 2)

• Milestone changed from Bug Fixing to 4.6.2

Reassign to 4.6.2 as this should be the bugfix release.

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 6, 2009 at 7:49 UTC (comment 3)

hm.. is patch mc-4.6.1-ac-fix-obsolete-ac_aix.diff really helps with fix this trouble? Or patch is a wrong?

[mc-butler]

Changed by metux (@metux) on Jan 6, 2009 at 18:45 UTC (comment 4)

Ups, obviously I uploaded the wrong patch ;-o

[mc-butler]

Changed by metux (@metux) on Jan 6, 2009 at 18:47 UTC

• Attachment mc-4.6.1-timefmt.diff (raw) added

Now the right one: reworked time formatting

[mc-butler]

Changed by metux (@metux) on Jan 6, 2009 at 18:47 UTC (comment 5)

• Keywords set to review

[mc-butler]

Changed by winnie (@winnieXY) on Jan 10, 2009 at 10:56 UTC (comment 6)

• Status changed from new to assigned
• Owner set to metux
• Keywords changed from review to review, vote-winnie

Assign metux as owner as until now nobody owns this bug really.
@metux: Please set the bug to accepted.

btw. I'll add a rev2 of the patch as this own doesn't apply on latest git (mc-4.6 branch).

[mc-butler]

Changed by winnie (@winnieXY) on Jan 10, 2009 at 10:57 UTC

• Attachment fix-timefmt-rev2.patch (raw) added

Patch rediffed to apply on latest git. (Also created a 96_segfault_invalid_mtime branch with this patch applied inside)

[mc-butler]

Changed by metux (@metux) on Jan 10, 2009 at 14:51 UTC (comment 7)

• Status changed from assigned to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 11, 2009 at 16:32 UTC (comment 8)

• Keywords changed from review, vote-winnie to review, vote-winnie, vote-slavazanko

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 11, 2009 at 16:33 UTC (comment 9)

• Keywords changed from review, vote-winnie, vote-slavazanko to review, vote-winnie, vote-slavazanko, approved

[mc-butler]

Changed by metux (@metux) on Jan 11, 2009 at 21:12 UTC (comment 10)

• Keywords changed from review, vote-winnie, vote-slavazanko, approved to committed-master, committed-mc-4.6, vote-winnie, vote-slavazanko

[mc-butler]

Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:50 UTC (comment 11)

• Resolution set to fixed
• Status changed from accepted to testing

[mc-butler]

Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:50 UTC (comment 12)

• Status changed from testing to closed

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 19, 2009 at 11:48 UTC (comment 13)

deleted 96_segfault_invalid_mtime branch from parent git.