pairs() consided harmful (Metatable with metatable)

[SoniEx2]

This code behaves differently in OC vs the standalone Lua interpreter:

local t = {}
local mt = {
  __index = {"1", "2", "3", test="hi"}, -- index 
  __gc = function() end -- dummy __gc, to trigger bug
}
local mtmt = {
  __pairs = function() -- dummy __pairs that returns an empty iterator
    return next, {}, nil
  end
}
setmetatable(mt, mtmt) -- needs to be done first
setmetatable(t, mt) -- trigger bug
-- ok so now let's test our __index shall we?
print(t[1], t[2], t[3], t.test) -- nil, nil, nil, nil
-- wait what?! it doesn't work!

Proposed solution: change setmetatable() to use for k, v in next, t do.

[RyanSquared]

I lost all faith in you the second I saw you write "pairs() considered harmful" - it's not harmful, it's just not usable in this spot.

[SoniEx2]

@ChickenNuggers I know but extortion tactics.

[skyem123]

You do know, when people get annoyed at you (like most OC people), titles like this are more likely to make them ignore it...

[SoniEx2]

@skyem123 Really? Because people started paying attention when I changed it to this...

[RyanSquared]

I mainly just called you an idiot because I saw you mention it elsewhere, a channel we unfortunately share.

[skyem123]

I would have checked it anyway... >_<

[fnuecke]

Next time, just make a PR, and don't be a passive-aggressive dick about it.