Skip to content

feat: add pymysql#416

Merged
shijinpjlab merged 1 commit into
MigoXLab:devfrom
shijinpjlab:dev_0603
Jun 3, 2026
Merged

feat: add pymysql#416
shijinpjlab merged 1 commit into
MigoXLab:devfrom
shijinpjlab:dev_0603

Conversation

@shijinpjlab

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the "pymysql" package to the runtime requirements. The feedback suggests specifying a minimum version constraint for "pymysql" to avoid potential compatibility issues and ensure stability in future updates.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread requirements/runtime.txt
pyarrow
sqlalchemy
xlrd
pymysql

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding pymysql without a version constraint can lead to unexpected breakages or compatibility issues in the future if a new major version is released. It is recommended to specify a minimum version constraint (e.g., >=1.1.0) to ensure stability.

pymysql>=1.1.0

@shijinpjlab shijinpjlab merged commit ca1d86e into MigoXLab:dev Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant