Skip to content

feat: retrieval add summary#419

Merged
e06084 merged 1 commit into
MigoXLab:devfrom
e06084:dev
Jun 6, 2026
Merged

feat: retrieval add summary#419
e06084 merged 1 commit into
MigoXLab:devfrom
e06084:dev

Conversation

@e06084

@e06084 e06084 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a summary attribute to the retrieval executor, initialized in the constructor and updated during execution, along with a new get_summary getter method. The review feedback suggests adding a return type annotation to the get_summary method to maintain consistency with other methods and support static type analysis.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dingo/exec/retrieval.py
self.retrieval_args = input_args.executor.retrieval
self.summary = SummaryModel()

def get_summary(self):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other methods in this class (such as execute and summarize) and to support static type analysis, please add a return type annotation to the get_summary method.

Suggested change
def get_summary(self):
def get_summary(self) -> SummaryModel:

@e06084 e06084 merged commit 2b4de44 into MigoXLab:dev Jun 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant