clean up typed data response, related to vapor#1657

Sources/Vapor/Request/Request.swift

@@ -139,6 +139,20 @@ public final class Request: ContainerAlias, DatabaseConnectable, HTTPMessageCont
         return Response(http: http, using: sharedContainer)
     }
 
+    /// Generate a `Response` for a `HTTPBody` convertible object using the supplied `MediaType`.
+    ///
+    ///     router.get("html") { req in
+    ///         return req.makeResponse("<h1>Hello, world!</h1>", as: .html)
+    ///     }
+    ///
+    /// - parameters:
+    ///     - type: The type of data to return the container with.
+    public func makeResponse(_ body: LosslessHTTPBodyRepresentable, as contentType: MediaType = .plainText) -> Response {
+        let res = makeResponse(http: .init(body: body))
+        res.http.contentType = contentType
+        return res
+    }
+
     // MARK: Database
 
     /// See `DatabaseConnectable`.

Tests/VaporTests/ApplicationTests.swift

@@ -524,8 +524,8 @@ class ApplicationTests: XCTestCase {
     func testDataResponses() throws {
         // without specific content type
         try Application.makeTest { router in
-            router.get("hello") { req -> Data in
-                return "Hello!".data(using: .utf8)!
+            router.get("hello") { req in
+                return req.makeResponse("Hello!")
             }
         }.test(.GET, "hello") { res in
             XCTAssertEqual(res.http.status, .ok)
@@ -535,7 +535,7 @@ class ApplicationTests: XCTestCase {
         // with specific content type
         try Application.makeTest { router in
             router.get("hey") { req -> Response in
-                return "Hey!".data(using: .utf8)!.response(type: .html)
+                return req.makeResponse("Hey!", as: .html)
             }
         }.test(.GET, "hey") { res in
             XCTAssertEqual(res.http.status, .ok)