New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Japanese language code, jp into ja #33

Merged
merged 1 commit into from Apr 16, 2017

Conversation

Projects
None yet
2 participants
@fmy
Contributor

fmy commented Apr 16, 2017

I rename jp into ja.

jp is Japan country code, and ja is Japanese language code.
https://en.wikipedia.org/wiki/ISO_639-1 // Language code
https://en.wikipedia.org/wiki/ISO_3166-2:JP // Country code

For backward-compatibility, I keep lunr.jp.js module.
Test codes for both lunr.ja.js and lunr.jp.js modules passed.

Pull request check-list

  • Describe in detail what you did and why you did it
  • Add tests. The more the better
    • with at least 1 scenario in case of a bug-fix and 4 scenarios in case of a new language
  • Don't open a Pull request for more unrelated topics. (eg a bug-fix, a new language, and few changes to stemming for existing languages in a single pull request)
// alias ja => jp for backward-compatibility.
lunr.jp = lunr.ja;
lunr.Pipeline.registerFunction(lunr.jp.stemmer, 'stemmer-jp');
lunr.Pipeline.registerFunction(lunr.jp.stopWordFilter, 'stopWordFilter-jp');

This comment has been minimized.

@fmy

fmy Apr 16, 2017

Contributor

here is the codes for backward-compatibility.

@MihaiValentin MihaiValentin merged commit a2f9efe into MihaiValentin:master Apr 16, 2017

@MihaiValentin

This comment has been minimized.

Owner

MihaiValentin commented Apr 16, 2017

@fmy Thanks for the contribution

@fmy fmy deleted the fmy:ja branch Apr 16, 2017

@miyahan miyahan referenced this pull request Nov 5, 2017

Merged

Add Japanese translation #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment