Annotate traits/classes/objects with @js.native (required since ScalaJS 0.6.5) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JS 0.6.5). Note: `package object ace` doesn't extend js.GlobalScope anymore. Extending js.GlobalScope requires us, since ScalaJS 0.6.5, to annotate the object with @js.native. Sadly, package objects cannot be annotated, and we thus need to explicitly assign a value to `ace`. More information at scala-js/scala-js#1892
|
@MikaelMayer So it appears that the latest version of the ScalaJS sbt plugin is indeed |
MikaelMayer
added a commit
that referenced
this pull request
Nov 27, 2015
Annotate traits/classes/objects with @js.native (required since ScalaJS 0.6.5)
MikaelMayer
pushed a commit
that referenced
this pull request
Dec 14, 2015
Updated missing scalajs commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
package object acedoesn't extendjs.GlobalScopeanymore.Extending
js.Any(or any of its subclasses) requires us, since ScalaJS 0.6.5, to annotate the object with @js.native. Sadly, package objects cannot be annotated, and we thus need to explicitly assign a value toace. More information at scala-js/scala-js#1892.