Add per-project config, concurrency, and interactive progress #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Dependencies
- Introduced indicatif = "0.18.2" as a new dependency to enable CLI progress visuals.
- Rationale: Provides a lightweight, reliable progress bar for long-running interactive tasks; laid groundwork for visual feedback in the run flow.
## Interactive Flow
- Introduced a progress bar in the interactive run flow to visualize progress while generating commit messages for file changes.
- Import indicatif::{ProgressBar, ProgressStyle} to support progress visuals.
- Initialize a ProgressBar in run_interactive sized to total file_changes plus one for completion.
- Increment the bar for each file processed (including ignored ones) to keep the UI in sync with work.
- Increment again when a file's summary is generated.
- Finalize the progress bar after creating the final commit message, finishing with a "Done." message.
- This is a UX enhancement; no core logic or commit content changes are introduced.
## Documentation - Introduced per-project config discovery and multi-method access in README to reflect concurrency/config goals. - Updated per-project TOML example to include a header ["user/repo"] and concrete override, demonstrating per-repo scope. - Removed the privacy notice from README to focus on configuration and usage. - Fixed EOF newline formatting for cleaner diffs. ## Config - Introduced new commitbot.toml to centralize concurrency and model settings. - Introduced global defaults: - default model (gpt-5-nano) - optional OpenAI-style API key with fallback to environment - max_concurrent_requests defaulting to 4 - Made configuration multi-source aware with precedence: CLI flags > environment variables > per-repo TOML overrides > default TOML section > hardcoded defaults. ## CLI Arguments - Introduced new global CLI option --max (Max concurrent requests to the LLM API) as an optional usize. - Represented as an Option<usize> to preserve existing default behavior when not supplied. - Removed Clap’s env-based lookup for OPENAI_API_KEY; api_key is now sourced only from CLI input (or other config sources). ## Configuration Loading - Added max_concurrent_requests to Config, wired through CLI (--max), env var (COMMITBOT_MAX_CONCURRENT_REQUESTS), and config file with default of 4. - Expanded configuration precedence to support multiple sources: CLI > environment > per-repo TOML overrides > default TOML section > hardcoded defaults. - Introduced FileConfigRoot and FileConfig to represent default and per-repo overrides. - Implemented repo-aware config resolution via git::detect_repo_id; per-repo config overlays default config. - Refactored loading: load_file_config now returns a FileConfigRoot; from_sources merges defaults with per-repo overrides. - Updated error handling: OPENAI_API_KEY must be provided via CLI, environment, or config file; clearer error if missing. ## Git Utilities - Introduced detect_repo_id() in src/git.rs to derive "owner/repo" from git remote.origin.url supporting SSH/HTTPS formats; returns Some or None non-fatally. ## LLM Client - Introduced Send + Sync bounds for LlmClient trait to enable safe concurrent usage across threads. ## Main Runtime - Introduced concurrency primitives (Arc/Mutex) and thread-scoped execution to run per-file LLM summarizations concurrently. - Introduced batched, concurrency-limited summarization logic governed by max_concurrent_requests; progress tracking remains responsive. - Wired configuration through to interactive flow: run_interactive now accepts Config; main passes loaded config to run_interactive. - Minor formatting and clarity improvements around concurrency setup and flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This branch introduces a configuration-driven, concurrent run experience with a user-visible progress bar in interactive mode. It adds per-repo overrides, a centralized config model, and batched LLM interactions to improve throughput while keeping the UI responsive. The changes unify configuration across CLI, environment, and per-repo TOML, and enable safe concurrent summarization of file changes.
Changes
Testing / Validation
Notes / Risks