Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip lines in longdef1 #103

Merged
merged 1 commit into from Nov 5, 2018
Merged

Don't strip lines in longdef1 #103

merged 1 commit into from Nov 5, 2018

Conversation

cstjean
Copy link
Collaborator

@cstjean cstjean commented Nov 2, 2018

Fix #102

All tests pass but.... why did you have striplines there in the first place? Did it handle a special case?

@MikeInnes
Copy link
Member

Unfortunately I'm not the right person to ask that question :) 9d701da

At a guess this is just a mis-translation of @q (which is only meant to avoid MacroTools line numbers getting in, but shouldn't strip lines from the input).

@MikeInnes MikeInnes merged commit 91554c9 into master Nov 5, 2018
@cstjean
Copy link
Collaborator Author

cstjean commented Nov 5, 2018

Oops 🙂. That is very likely. @q was black magic to me at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants