This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
[#77] Adding in a failing test suite which should work in Travis #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 2, 2017
| @@ -0,0 +1,12 @@ | |||
| QUnit.module("LivePage injected file", { | |||
There was a problem hiding this comment.
'QUnit' is not defined.
houndci-bot
reviewed
Jan 2, 2017
| QUnit.test( "normalizeURL - Return everything before the # in a url when ignore_anchors is enabled", function( assert ) { | ||
| assert.equal( new livePage({}).normalizeURL("http://www.site.com/"), "http://www.site.com/" ); | ||
| assert.equal( new livePage({ignore_anchors: true}).normalizeURL("http://www.site.com/#hello"), "http://www.site.com/" ); | ||
| assert.equal( new livePage({ignore_anchors: false}).normalizeURL("http://www.site.com/#hello"), "http://www.site.com/#hello" ); |
There was a problem hiding this comment.
Line is too long.
A constructor name should start with an uppercase letter.
Identifier 'ignore_anchors' is not in camel case.
'livePage' is not defined.
houndci-bot
reviewed
Jan 2, 2017
| // normalizeURL | ||
| QUnit.test( "normalizeURL - Return everything before the # in a url when ignore_anchors is enabled", function( assert ) { | ||
| assert.equal( new livePage({}).normalizeURL("http://www.site.com/"), "http://www.site.com/" ); | ||
| assert.equal( new livePage({ignore_anchors: true}).normalizeURL("http://www.site.com/#hello"), "http://www.site.com/" ); |
There was a problem hiding this comment.
Line is too long.
A constructor name should start with an uppercase letter.
Identifier 'ignore_anchors' is not in camel case.
'livePage' is not defined.
houndci-bot
reviewed
Jan 2, 2017
|
|
||
| // normalizeURL | ||
| QUnit.test( "normalizeURL - Return everything before the # in a url when ignore_anchors is enabled", function( assert ) { | ||
| assert.equal( new livePage({}).normalizeURL("http://www.site.com/"), "http://www.site.com/" ); |
There was a problem hiding this comment.
Line is too long.
A constructor name should start with an uppercase letter.
'livePage' is not defined.
houndci-bot
reviewed
Jan 2, 2017
| }); | ||
|
|
||
| // normalizeURL | ||
| QUnit.test( "normalizeURL - Return everything before the # in a url when ignore_anchors is enabled", function( assert ) { |
There was a problem hiding this comment.
Line is too long.
'QUnit' is not defined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77