Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stuff #2

Merged
merged 20 commits into from Oct 6, 2019

Conversation

@Niputi
Copy link
Member

Niputi commented Sep 1, 2019

goal of this pr is to make it run as expected.

after pr is no longer a draft @velddev and/or @exsersewo have to confirm the docker stuff and route works as expected

@velddev velddev requested review from velddev and exsersewo Sep 2, 2019
@velddev velddev added the enhancement label Sep 2, 2019
src/api.ts Outdated Show resolved Hide resolved
src/routes/images.router.ts Show resolved Hide resolved
@Niputi Niputi changed the title [wip] Redid some things [wip] Fixed stuff Sep 17, 2019
@Niputi

This comment has been minimized.

Copy link
Member Author

Niputi commented Sep 29, 2019

@exsersewo review/test and merge

Edit: please find any related issues and change pr text to include "Fixes: link_to_issue" for each of them if issues will be closed with this one

@Niputi Niputi changed the title [wip] Fixed stuff Fixed stuff Sep 29, 2019
@Niputi Niputi marked this pull request as ready for review Sep 29, 2019
@Niputi

This comment has been minimized.

Copy link
Member Author

Niputi commented Sep 29, 2019

might as well include veld in this request too

@Niputi Niputi requested a review from velddev Sep 29, 2019
@Niputi Niputi dismissed velddev’s stale review Oct 4, 2019

out of date

@Niputi Niputi requested a review from exsersewo Oct 4, 2019
src/routes/images.router.ts Outdated Show resolved Hide resolved
@Niputi Niputi requested a review from exsersewo Oct 6, 2019
@exsersewo exsersewo merged commit 2d34163 into master Oct 6, 2019
@exsersewo exsersewo deleted the redid-some-things branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.