-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use explicit dependencies in src/app
#10455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
added
the
ci-build-me
Add this label to trigger a circle+buildkite build for this branch
label
Mar 10, 2022
ylecornec
changed the title
Ylecornec/explicit dependencies src app
use explicit dependencies in Mar 10, 2022
src/app
mrmr1993
approved these changes
Mar 10, 2022
mitschabaude
approved these changes
Mar 10, 2022
Conflicts: src/app/cli/src/init/dune
lk86
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you will have to resolve the conflicts and get CI to pass, whether the failure is related or not
ylecornec
force-pushed
the
ylecornec/explicit_dependencies_src_app
branch
from
March 18, 2022 12:36
9eb96e2
to
0cf8cbb
Compare
Conflicts: src/app/archive/archive_lib/dune src/app/cli/src/init/dune
ylecornec
force-pushed
the
ylecornec/explicit_dependencies_src_app
branch
from
March 18, 2022 15:18
0cf8cbb
to
b599da9
Compare
This was referenced Mar 21, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
(implicit_transitive_deps false)
in thedune-project
files ofsrc/app
,adds the necessary explicit dependencies and removes some unnecessary ones.
Explain how you tested your changes:
dune build
in the affected foldersChecklist: