Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package generation/generate genesis config #15592

Merged
merged 12 commits into from
May 1, 2024
Merged

Package generation/generate genesis config #15592

merged 12 commits into from
May 1, 2024

Conversation

ghost-not-in-the-shell
Copy link
Contributor

@ghost-not-in-the-shell ghost-not-in-the-shell commented Apr 30, 2024 •
edited
Loading

Explain your changes:
prints out the new genesis config during package generation pipeline

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

georgeee
georgeee approved these changes May 1, 2024
View reviewed changes
buildkite/src/Command/MinaArtifact.dhall Outdated Show resolved Hide resolved
@ghost-not-in-the-shell ghost-not-in-the-shell marked this pull request as ready for review May 1, 2024 17:28
@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner May 1, 2024 17:28
@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell @georgeee
Update buildkite/src/Command/MinaArtifact.dhall
f78a305 
Co-authored-by: George Agapov <george.agapov@gmail.com>
@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell ghost-not-in-the-shell mentioned this pull request May 1, 2024
Merged
7 tasks
@deepthiskumar deepthiskumar merged commit ea77cab into berkeley May 1, 2024
9 of 11 checks passed
@deepthiskumar deepthiskumar deleted the package-generation/generate-genesis-config branch May 1, 2024 22:33
@joaosreis joaosreis restored the package-generation/generate-genesis-config branch May 7, 2024 11:25
@joaosreis joaosreis deleted the package-generation/generate-genesis-config branch May 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeee georgeee georgeee approved these changes

@dkijania dkijania dkijania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghost-not-in-the-shell @georgeee @dkijania @deepthiskumar