Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive node records block confirmation #3875

Merged
merged 5 commits into from Nov 13, 2019
Merged

Conversation

wu-s-john
Copy link
Contributor

@wu-s-john wu-s-john commented Nov 8, 2019

  • Show which files have been compiled on testone.sh as indiciation of
    how close the compiler on completing its compilation
  • Renamed archive/lib to archive/archive_lib so that you can it is
    testone can run tests on the lib
  • Added Comparable to data_hash_intf so that we can create Maps where the keys are state_hash. This is useful for
    sexping State_hash.Maps
  • In archive_lib/test.ml, try_with takes in an input of a processor.
    This reduces the recreating a processor for each test

Checklist:

  • Tests were added for the new behavior
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

- Show which files have been compiled on testone.sh as indiciation of
how close the compiler on completing its compilation
- Renamed archive/lib to archive/archive_lib so that you can it is
testone can run tests on the lib
- Added Comparable to data_hash_intf so that we can create Maps where the keys are state_hash. This is useful for
sexping State_hash.Maps
- In archive_lib/test.ml, try_with takes in an input of a processor.
This reduces the recreating a processor for each test
| Unknown ->
-3

let of_int = function
Copy link
Member

@psteckler psteckler Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be of_int_opt ?

Copy link
Member

@psteckler psteckler left a comment

Looks OK, modulo one nit. I can't comment knowledgeably on the GraphQL stuff.

bkase
bkase approved these changes Nov 12, 2019
wu-s-john added 2 commits Nov 13, 2019
- made logic for updating block confirmation a lot easier
bkase
bkase approved these changes Nov 13, 2019
@wu-s-john wu-s-john added the ready-to-merge label Nov 13, 2019
@mergify mergify bot merged commit 92f18a1 into develop Nov 13, 2019
21 of 24 checks passed
@mergify mergify bot deleted the feature/consensus_status branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants