Archive node records block confirmation #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show which files have been compiled on testone.sh as indiciation of how close the compiler on completing its compilation - Renamed archive/lib to archive/archive_lib so that you can it is testone can run tests on the lib - Added Comparable to data_hash_intf so that we can create Maps where the keys are state_hash. This is useful for sexping State_hash.Maps - In archive_lib/test.ml, try_with takes in an input of a processor. This reduces the recreating a processor for each test
wu-s-john
requested review from
bkase,
emberian,
imeckler,
jkrauska,
nholland94,
psteckler,
Schmavery and
yourbuddyconner
as code owners
psteckler
reviewed
Nov 8, 2019
| | Unknown -> | ||
| -3 | ||
|
|
||
| let of_int = function |
psteckler
approved these changes
Nov 8, 2019
Looks OK, modulo one nit. I can't comment knowledgeably on the GraphQL stuff.
bkase
approved these changes
Nov 12, 2019
- made logic for updating block confirmation a lot easier
…da into feature/consensus_status
bkase
approved these changes
Nov 13, 2019
wu-s-john
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
how close the compiler on completing its compilation
testone can run tests on the lib
sexping State_hash.Maps
This reduces the recreating a processor for each test
Checklist: