Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't die if the target peer is banned in try_call_rpc #3881

Merged
merged 2 commits into from Nov 11, 2019

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Nov 8, 2019

This was causing crashes on the release candidate testnet. Since it's a race I don't have a good way to test if the fix works locally, but it's logically sound and we'll see when the next internal testnet goes up.

@enolan enolan requested review from bkase and emberian as code owners Nov 8, 2019
@enolan enolan added the ready-to-merge label Nov 8, 2019
@mergify mergify bot merged commit 5c945c0 into develop Nov 11, 2019
21 of 24 checks passed
@mergify mergify bot deleted the fix/banned_peer_try_call_rpc branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants