New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise rejection updates #299

Merged
merged 2 commits into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@BenjaminHarding
Contributor

BenjaminHarding commented Sep 28, 2018

Adds support to the unhandled promise rejection handler to use the event.reason.error as the exception if event.reason isn't one already.

This handles more case in other developer environments where the error is actually on the reason.

@BenjaminHarding BenjaminHarding requested a review from UberMouse Sep 28, 2018

@UberMouse

LGTM

@BenjaminHarding BenjaminHarding merged commit ffec047 into master Sep 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@BenjaminHarding BenjaminHarding deleted the promise-rejection-updates branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment