Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curseforge maven could not be added as deobf dependencies #596

Open
HyCraftHD opened this issue Jun 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@HyCraftHD
Copy link

commented Jun 3, 2019

There is an issue in the fg.deobf function. When the maven repository is well formatted with pom files everything is working fine.
The problem is the curseforge maven does not provide pom files and has often unusal dependency configurations.
I tried adding morpheus from curseforge as a deobf dependency:

repositories {
    maven { url = "https://minecraft.curseforge.com/api/maven" }
}

dependencies {
    minecraft "net.minecraftforge:forge:$config.forge.version"	
	compile fg.deobf(group: "morpheus", name: "Morpheus", version: "1.13.2", classifier: "4.0.115", ext: "jar")
}

The crashlog is: https://pastebin.com/rPgtSBzu

If i add it as a normal dependency everything is okay.

@MinecraftForge MinecraftForge deleted a comment from tterrag1098 Jun 5, 2019

@LexManos

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

This is a issue with the maven URL format. There is no way we can determine what is the extension, and what is the classifier. We have to support the most common cases of double extension .jar.md5
We do the magic using a regex: https://github.com/MinecraftForge/Artifactural/blob/master/src/gradlecomp/java/com/amadornes/artifactural/gradle/GradleRepositoryAdapter.java#L83

If you have solutions, feel free to PR Artifactural.

(Deleted tterrag's response as he mistakenly thought Artifact/ArtifactIdentifier was gradle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.