Dispensers will pickup any Materal.water as a Water bucket when using a vanilla empty bucket no matter if it is indeed a water block or not

[ThatOneTraitor]

There should be a thing that makes dispensers check for what fluid their picking up. Thermal foundation has their own dispenser utilities that let their liquid be picked up by dispensers in a fixed way. This should be added into forge so that other mods such as AM2 (The whole reason im making this post) doesn't have to worry about liquid not being handled by dispensers properly

[LexManos]

Dispensors use items, and have a registry for there 'attempt to use this item'.
So if there is something that can be used to hold fluids in the dispenser, then it needs a handler to be registered.
So this has very little to do with liquids and more the items. What items are not working? The vanilla bucket picks up lava/water so it should work fine.

[williewillus]

I'm gathering that this is requesting something like a dispenser use action for the universal bucket? Unified way to go bucket -> liquid and vv
@ThatOneTraitor That's not going to show up in 1.7.10 with AM2 though, it's going to be in 1.9.4+

[ThatOneTraitor]

yeah still, it'd be good to add. And to anser @LexManos the bucket will pick up liquid etherium but turn it into Water. there was a fix to it but then it caused the etherium tile not to act as a liquid, the long conversation is in the post that this is being refrenced to.

[TheIcyOne]

Just to note, this is the commit @ThatOneTraitor is referencing.

Mithion/ArsMagica2@0e7da1f

[LexManos]

And this is why context information is important!
The OP is 'Dispensers something something fluids something something'
With your added context 'Dispensers will pickup any Materal.water as a Water bucket when using a vanilla empty bucket no matter if it is indeed a water block or not'
See how context makes things actually make sense?

[williewillus]

So this is actually a bug of sorts.

[Actuarius]

@williewillus added labels [Bug]

[polyipseity]

@ThatOneTraitor
I use a way to make any custom liquid with custom liquid material act as a liquid by overriding a method.

public Boolean isEntityInsideMaterial(IBlockAccess world, BlockPos blockpos, IBlockState iblockstate, Entity entity, double yToTest, Material materialIn, boolean testingHead)
{
    return null;
    // null for default
}

I override it with this :

public Boolean isEntityInsideMaterial(IBlockAccess world, BlockPos blockpos, IBlockState iblockstate, Entity entity, double yToTest, Material materialIn, boolean testingHead)
{
    if (materialIn == Material.WATER && world.getBlockState(blockpos).getBlock() == this) // Check is materialIn equals to Material.WATER
    {
        return true;
    }
    else
    {
        return super.isEntityInsideMaterial(world, blockpos, iblockstate, entity, yToTest, materialIn, testingHead);
    }
}

And it will act like as a liquid.
This is a short-term fix.
We still need to fix this bug.

[ThatOneTraitor]

ty, ill put this on the AM2 issue

[Actuarius]

@mezz added labels [Fluids]

[mezz]

I'll get started on this now

[Actuarius]

@williewillus added labels [Superseded]