Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches left to review for 1.13 #5162

Closed
tterrag1098 opened this issue Sep 26, 2018 · 11 comments
Closed

Patches left to review for 1.13 #5162

tterrag1098 opened this issue Sep 26, 2018 · 11 comments
Labels
1.13 Cleanup This request reorganizes messy code, or fixing it would require doing so.

Comments

@tterrag1098
Copy link
Collaborator

tterrag1098 commented Sep 26, 2018 •
edited

  • net.minecraft.advancements:
    • AdvancementManager
    • AdvancementRewards
    • DisplayInfo
    • PlayerAdvancements
  • net.minecraft.advancements.critereon:
    • ItemPredicate
  • net.minecraft.block:
    • Block
    • BlockBanner
    • BlockBed
    • BlockBush
    • BlockButton
    • BlockCactus
    • BlockChest
    • BlockChorusFlower
    • BlockCocoa
    • BlockCrops
    • BlockDeadBush
    • BlockDoor
    • BlockDoublePlant
    • BlockDragonEgg
    • BlockDropper
    • BlockDynamicLiquid
    • BlockEnchantmentTable
    • BlockEnderChest
    • BlockFalling
    • BlockFarmland
    • BlockFence
    • BlockFenceGate
    • BlockFire
    • BlockFlowerPot
    • BlockGrass
    • BlockHugeMushroom
    • BlockIce
    • BlockLadder
    • BlockLeaves
    • BlockLiquid
    • BlockLog
    • BlockMobSpawner
    • BlockMushroom
    • BlockMycelium
    • BlockNetherWart
    • BlockNewLeaf
    • BlockNote
    • BlockObserver
    • BlockOldLeaf
    • BlockOre
    • BlockPane
    • BlockPistonBase
    • BlockPistonMoving
    • BlockPortal
    • BlockPotato
    • BlockPumpkin
    • BlockQuartz
    • BlockRailBase
    • BlockRailDetector
    • BlockRailPowered
    • BlockRedstoneComparator
    • BlockRedstoneDiode
    • BlockRedstoneOre
    • BlockRedstoneTorch
    • BlockRedstoneWire
    • BlockReed
    • BlockRotatedPillar
    • BlockSapling
    • BlockSkull
    • BlockSlab
    • BlockSnow
    • BlockStairs
    • BlockStaticLiquid
    • BlockStem
    • BlockTallGrass
    • BlockTorch
    • BlockTrapDoor
    • BlockVine
    • BlockWall
    • BlockWeb
    • SoundType
  • net.minecraft.block.state:
    • BlockPistonStructureHelper
    • BlockStateBase
    • BlockStateContainer
    • IBlockProperties
  • net.minecraft.client:
    • ClientBrandRetriever
    • LoadingScreenRenderer
    • Minecraft
  • net.minecraft.client.audio:
    • SoundHandler
    • SoundManager
  • net.minecraft.client.entity:
    • AbstractClientPlayer
    • EntityOtherPlayerMP
    • EntityPlayerSP
  • net.minecraft.client.gui:
    • FontRenderer
    • GuiBossOverlay
    • GuiButton
    • GuiControls
    • GuiCreateWorld
    • GuiEnchantment
    • GuiIngame
    • GuiIngameMenu
    • GuiKeyBindingList
    • GuiLanguage
    • GuiListWorldSelectionEntry
    • GuiMainMenu
    • GuiMultiplayer
    • GuiOverlayDebug
    • GuiScreen
    • GuiScreenBook
    • GuiScreenDemo
    • GuiSleepMP
    • GuiSlot
    • GuiSpectator
    • GuiUtilRenderComponents
    • GuiVideoSettings
    • MapItemRenderer
    • ServerListEntryNormal
  • net.minecraft.client.gui.advancements:
    • GuiAdvancementTab
    • GuiScreenAdvancements
  • net.minecraft.client.gui.inventory:
    • GuiContainer
    • GuiContainerCreative
  • net.minecraft.client.gui.recipebook:
    • GuiRecipeBook
    • GuiRecipeOverlay
  • net.minecraft.client.gui.toasts:
    • RecipeToast
  • net.minecraft.client.model:
    • ModelBase
    • ModelBox
    • ModelRenderer
    • PositionTextureVertex
    • TexturedQuad
  • net.minecraft.client.multiplayer:
    • ChunkProviderClient
    • GuiConnecting
    • PlayerControllerMP
    • WorldClient
  • net.minecraft.client.network:
    • NetHandlerHandshakeMemory
    • NetHandlerLoginClient
    • NetHandlerPlayClient
    • ServerPinger
  • net.minecraft.client.particle:
    • Particle
    • ParticleManager
  • net.minecraft.client.renderer:
    • ActiveRenderInfo
    • BlockFluidRenderer
    • BlockModelRenderer
    • BlockModelShapes
    • BlockRendererDispatcher
    • BufferBuilder
    • ChestRenderer
    • EntityRenderer
    • InventoryEffectRenderer
    • ItemModelMesher
    • ItemRenderer
    • OpenGlHelper
    • RenderGlobal
    • RenderItem
    • WorldVertexBufferUploader
  • net.minecraft.client.renderer.block.model:
    • BakedQuad
    • BakedQuadRetextured
    • FaceBakery
    • IBakedModel
    • ItemCameraTransforms
    • ItemOverrideList
    • ItemTransformVec3f
    • ModelBakery
    • ModelBlockDefinition
    • ModelManager
    • ModelResourceLocation
    • ModelRotation
    • SimpleBakedModel
    • Variant
    • WeightedBakedModel
  • net.minecraft.client.renderer.block.statemap:
    • StateMap
  • net.minecraft.client.renderer.chunk:
    • ChunkRenderDispatcher
    • RenderChunk
  • net.minecraft.client.renderer.color:
    • BlockColors
    • ItemColors
  • net.minecraft.client.renderer.entity:
    • RenderEntityItem
    • RenderFish
    • RenderItemFrame
    • RenderLivingBase
    • RenderManager
    • RenderPlayer
    • RenderVillager
    • RenderZombieVillager
  • net.minecraft.client.renderer.entity.layers:
    • LayerArmorBase
    • LayerBipedArmor
    • LayerHeldItem
  • net.minecraft.client.renderer.texture:
    • LayeredColorMaskTexture
    • Stitcher
    • TextureAtlasSprite
    • TextureManager
    • TextureMap
    • TextureUtil
  • net.minecraft.client.renderer.tileentity:
    • TileEntityItemStackRenderer
    • TileEntityPistonRenderer
    • TileEntityRendererDispatcher
    • TileEntitySpecialRenderer
  • net.minecraft.client.renderer.vertex:
    • VertexFormat
    • VertexFormatElement
  • net.minecraft.client.resources:
    • FallbackResourceManager
    • IResourceManagerReloadListener
    • Language
    • Locale
    • SimpleReloadableResourceManager
  • net.minecraft.client.settings:
    • GameSettings
    • KeyBinding
  • net.minecraft.client.shader:
    • Framebuffer
    • ShaderGroup
    • ShaderLoader
    • ShaderManager
  • net.minecraft.client.util:
    • RecipeBookClient
    • RecipeItemHelper
  • net.minecraft.command:
    • CommandBase
    • CommandFill
    • CommandGameRule
    • CommandHandler
    • EntitySelector
  • net.minecraft.command.server:
    • CommandSetBlock
  • net.minecraft.crash:
    • CrashReport
    • CrashReportCategory
  • net.minecraft.creativetab:
    • CreativeTabs
  • net.minecraft.enchantment:
    • Enchantment
    • EnchantmentFrostWalker
    • EnchantmentHelper
    • EnchantmentThorns
    • EnumEnchantmentType
  • net.minecraft.entity:
    • Entity
    • EntityAgeable
    • EntityFlying
    • EntityHanging
    • EntityLeashKnot
    • EntityList
    • EntityLiving
    • EntityLivingBase
    • EntitySpawnPlacementRegistry
    • EntityTracker
    • EntityTrackerEntry
    • SharedMonsterAttributes
  • net.minecraft.entity.ai:
    • EntityAIAttackMelee
    • EntityAIBreakDoor
    • EntityAIEatGrass
    • EntityAIHarvestFarmland
    • EntityAIMate
    • EntityAIRunAroundLikeCrazy
    • EntityAIVillagerMate
  • net.minecraft.entity.boss:
    • EntityDragon
    • EntityWither
  • net.minecraft.entity.boss.dragon.phase:
    • PhaseSittingFlaming
  • net.minecraft.entity.effect:
    • EntityLightningBolt
  • net.minecraft.entity.item:
    • EntityArmorStand
    • EntityBoat
    • EntityEnderPearl
    • EntityFallingBlock
    • EntityItem
    • EntityItemFrame
    • EntityMinecart
    • EntityMinecartCommandBlock
    • EntityMinecartContainer
    • EntityMinecartEmpty
    • EntityMinecartFurnace
    • EntityMinecartHopper
    • EntityMinecartMobSpawner
    • EntityXPOrb
  • net.minecraft.entity.monster:
    • EntityCreeper
    • EntityEnderman
    • EntityEvoker
    • EntityIronGolem
    • EntityMagmaCube
    • EntityMob
    • EntityShulker
    • EntitySilverfish
    • EntitySlime
    • EntitySnowman
    • EntitySpider
    • EntityZombie
    • EntityZombieVillager
  • net.minecraft.entity.passive:
    • AbstractHorse
    • EntityHorse
    • EntityMooshroom
    • EntityOcelot
    • EntityParrot
    • EntityRabbit
    • EntitySheep
    • EntityVillager
    • EntityWolf
    • HorseArmorType
  • net.minecraft.entity.player:
    • EntityPlayer
    • EntityPlayerMP
    • InventoryPlayer
  • net.minecraft.entity.projectile:
    • EntityArrow
    • EntityFireball
    • EntityFishHook
    • EntityLargeFireball
    • EntityLlamaSpit
    • EntityShulkerBullet
    • EntitySmallFireball
    • EntityThrowable
    • EntityWitherSkull
  • net.minecraft.init:
    • Bootstrap
  • net.minecraft.inventory:
    • Container
    • ContainerBeacon
    • ContainerBrewingStand
    • ContainerEnchantment
    • ContainerPlayer
    • ContainerRepair
    • Slot
    • SlotCrafting
    • SlotFurnaceOutput
  • net.minecraft.item:
    • Item
    • ItemArmor
    • ItemArrow
    • ItemAxe
    • ItemBed
    • ItemBlock
    • ItemBlockSpecial
    • ItemBow
    • ItemBucket
    • ItemBucketMilk
    • ItemDoor
    • ItemDye
    • ItemFlintAndSteel
    • ItemHoe
    • ItemLilyPad
    • ItemMap
    • ItemMinecart
    • ItemSeedFood
    • ItemSeeds
    • ItemShears
    • ItemSkull
    • ItemSlab
    • ItemSnow
    • ItemStack
    • ItemSword
    • ItemTool
  • net.minecraft.item.crafting:
    • CraftingManager
    • FurnaceRecipes
    • IRecipe
    • Ingredient
    • RecipeBookCloning
    • RecipeFireworks
    • RecipeRepairItem
    • RecipeTippedArrow
    • RecipesArmorDyes
    • RecipesBanners
    • RecipesMapCloning
    • ShapedRecipes
    • ShapelessRecipes
    • ShieldRecipes
    • ShulkerBoxRecipes
  • net.minecraft.nbt:
    • CompressedStreamTools
    • NBTSizeTracker
    • NBTTagCompound
    • NBTTagList
    • NBTTagString
  • net.minecraft.network:
    • NetHandlerPlayServer
    • NettyPacketEncoder
    • NetworkManager
    • NetworkSystem
    • PacketBuffer
    • ServerStatusResponse
  • net.minecraft.network.datasync:
    • EntityDataManager
  • net.minecraft.network.handshake.client:
    • C00Handshake
  • net.minecraft.network.login.server:
    • SPacketLoginSuccess
  • net.minecraft.network.play.client:
    • CPacketClickWindow
    • CPacketCreativeInventoryAction
    • CPacketCustomPayload
  • net.minecraft.network.play.server:
    • SPacketCustomPayload
    • SPacketSpawnMob
  • net.minecraft.pathfinding:
    • FlyingNodeProcessor
    • WalkNodeProcessor
  • net.minecraft.potion:
    • Potion
    • PotionEffect
    • PotionHelper
    • PotionType
  • net.minecraft.profiler:
    • Profiler
  • net.minecraft.realms:
    • RealmsConnect
  • net.minecraft.server:
    • MinecraftServer
  • net.minecraft.server.dedicated:
    • DedicatedServer
    • ServerHangWatchdog
  • net.minecraft.server.gui:
    • MinecraftServerGui
  • net.minecraft.server.integrated:
    • IntegratedServer
  • net.minecraft.server.management:
    • PlayerChunkMapEntry
    • PlayerInteractionManager
    • PlayerList
  • net.minecraft.server.network:
    • NetHandlerHandshakeTCP
    • NetHandlerLoginServer
  • net.minecraft.stats:
    • RecipeBook
    • RecipeBookServer
    • StatList
  • net.minecraft.tileentity:
    • MobSpawnerBaseLogic
    • TileEntity
    • TileEntityBeacon
    • TileEntityBrewingStand
    • TileEntityChest
    • TileEntityFurnace
    • TileEntityHopper
    • TileEntityLockable
    • TileEntityLockableLoot
    • TileEntityNote
    • TileEntityPiston
    • TileEntityShulkerBox
    • TileEntitySign
  • net.minecraft.util:
    • ActionResult
    • BlockRenderLayer
    • ChatAllowedCharacters
    • ClassInheritanceMultiMap
    • EnumFacing
    • IntIdentityHashBiMap
    • MouseHelper
    • ScreenShotHelper
    • ServerRecipeBookHelper
    • Session
    • SoundEvent
    • TabCompleter
  • net.minecraft.util.datafix:
    • DataFixesManager
  • net.minecraft.util.math:
    • RayTraceResult
    • Vec3d
  • net.minecraft.util.text:
    • ITextComponent
    • Style
    • TextComponentBase
  • net.minecraft.util.text.translation:
    • LanguageMap
  • net.minecraft.village:
    • Village
    • VillageCollection
  • net.minecraft.world:
    • BossInfo
    • BossInfoServer
    • ChunkCache
    • DimensionType
    • Explosion
    • IBlockAccess
    • ServerWorldEventHandler
    • Teleporter
    • World
    • WorldEntitySpawner
    • WorldProvider
    • WorldProviderEnd
    • WorldProviderSurface
    • WorldServer
    • WorldServerMulti
    • WorldType
  • net.minecraft.world.biome:
    • Biome
    • BiomeDecorator
    • BiomeDesert
    • BiomeForest
    • BiomeHills
    • BiomeJungle
    • BiomeMesa
    • BiomePlains
    • BiomeProvider
    • BiomeSavanna
    • BiomeSnow
    • BiomeSwamp
    • BiomeTaiga
  • net.minecraft.world.border:
    • WorldBorder
  • net.minecraft.world.chunk:
    • BlockStateContainer
    • Chunk
  • net.minecraft.world.chunk.storage:
    • AnvilChunkLoader
    • AnvilSaveHandler
    • ExtendedBlockStorage
    • RegionFile
  • net.minecraft.world.end:
    • DragonFightManager
  • net.minecraft.world.gen:
    • ChunkGeneratorEnd
    • ChunkGeneratorFlat
    • ChunkGeneratorHell
    • ChunkGeneratorOverworld
    • ChunkProviderServer
    • MapGenCaves
    • MapGenRavine
  • net.minecraft.world.gen.feature:
    • WorldGenAbstractTree
    • WorldGenBigMushroom
    • WorldGenBigTree
    • WorldGenBirchTree
    • WorldGenBush
    • WorldGenCanopyTree
    • WorldGenDeadBush
    • WorldGenDungeons
    • WorldGenGlowStone1
    • WorldGenGlowStone2
    • WorldGenHellLava
    • WorldGenHugeTrees
    • WorldGenIceSpike
    • WorldGenLakes
    • WorldGenLiquids
    • WorldGenMegaJungle
    • WorldGenMegaPineTree
    • WorldGenMinable
    • WorldGenSavannaTree
    • WorldGenShrub
    • WorldGenSwamp
    • WorldGenTaiga1
    • WorldGenTaiga2
    • WorldGenTallGrass
    • WorldGenTrees
    • WorldGenerator
    • WorldGeneratorBonusChest
  • net.minecraft.world.gen.layer:
    • GenLayer
    • GenLayerBiome
  • net.minecraft.world.gen.structure:
    • MapGenStronghold
    • MapGenStructure
    • StructureComponent
    • StructureStart
    • StructureVillagePieces
  • net.minecraft.world.gen.structure.template:
    • Template
  • net.minecraft.world.storage:
    • DerivedWorldInfo
    • MapData
    • MapDecoration
    • SaveFormatOld
    • SaveHandler
    • WorldInfo
    • WorldSavedData
  • net.minecraft.world.storage.loot:
    • LootContext
    • LootEntry
    • LootEntryEmpty
    • LootEntryItem
    • LootEntryTable
    • LootPool
    • LootTable
    • LootTableManager
  • net.minecraft.world.storage.loot.conditions:
    • LootConditionManager
    • RandomChanceWithLooting
  • net.minecraft.world.storage.loot.functions:
    • LootingEnchantBonus
@tterrag1098 tterrag1098 added Cleanup This request reorganizes messy code, or fixing it would require doing so. 1.13 labels Sep 26, 2018
@williewillus
Copy link
Contributor

not a patch, but IThrowableEntity and its supporting code should go. It looks like extremely old compat code, and nothing uses it.

@williewillus
Copy link
Contributor

williewillus commented Sep 26, 2018 •
edited

Additionally, I also think the old BrewingRecipeRegistry (and its patches to vanilla) can go as well. Looking at the interfaces provided in IBrewingRecipe, it's superseded completely by the vanilla systems in PotionHelper, since now we have flexible Ingredients that can be extended for arbitrary matching behaviour

@Shadows-of-Fire
Copy link
Contributor

I think it would be a good idea to remove all the patches from TileEntityItemStackRenderer and move to a forge-owned item renderer class, preferably with more context.

@chylex
Copy link

chylex commented Sep 29, 2018

Block.addLandingEffects has a duplicate IBlockState parameter, this would be good to fix for the major version update: EntityLivingBase.java.patch#L28

@ichttt ichttt mentioned this issue Oct 12, 2018
Closed
@NQNStudios
Copy link

Hi all! I'm a dev working with an academic research team that uses Forge for modding. Soon I'll have the time and energy that I could contribute back to Forge; our work would benefit by having 1.13 support so I'd be down to help with that. Is this issue the basic roadmap for the upgrade?

@mezz
Copy link
Member

mezz commented Nov 23, 2018

The current work is extremely specialized, and mostly being done by Lex and cpw.
We will be more open to contributions once the patches have been ported and things have stabilized a little bit. Until then there is not really a way to help out.

This issue is difficult to maintain so I am not sure it reflects the current progress, you can directly see the state of patch porting progress here (updated yesterday): b687180

@chimericdream
Copy link

@mezz @LexManos @cpw

Once things are a little closer (i.e. patches ported and things stabilized as you mentioned), will there be any kind of "here's how you can help" document or issue? I'm an experienced Java developer, but something as big as Forge is so daunting that it's hard to know where to start. For as much as I have gotten from Forge and the modding community, I'd love to help out in whatever ways I can.

Keep up the good work, and thanks for everything you've done so far!

@mezz
Copy link
Member

mezz commented Dec 26, 2018

The project is too big to jump in at random, so I am starting to look for things to fix in Forge by trying to port mods. I quickly ran into things that are missing or not working. When things are more stable next month, more modders will be trying to port their mods and reporting issues in the tracker here, and there should be plenty to take a look at!

@MinecraftForge MinecraftForge deleted a comment Jan 14, 2019
@MinecraftForge MinecraftForge deleted a comment Jan 14, 2019
@NQNStudios
Copy link

Now that this is closed, what does that mean for the 1.13 release? Any way I or the rest of my research team can help out?

@Shadows-of-Fire
Copy link
Contributor

It means the main patchwork has been done, forge is now currently in a stage of bugfixing and feature addition in the form of PR's. Any issues that can be reproduced with just forge should be reported to the tracker with either an accompanying PR or reproruction steps so someone else can make a PR.

@tterrag1098
Copy link
Collaborator Author

Forge for 1.13.2 is released as a beta. Any further patches are on the backburner or not necessary. This part of the port is complete. As for what needs to be done, there are lots of open issues tagged "1.13" that need to be fixed, and lots of other things yet to be discovered I'm sure. Discord is a great place to communicate about what needs doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.13 Cleanup This request reorganizes messy code, or fixing it would require doing so.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@chimericdream @mezz @williewillus @NQNStudios @Shadows-of-Fire @chylex @tterrag1098