Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerTickEvent not firing when dead, even if player isn't removed from world yet #6074

Closed
BlayTheNinth opened this issue Aug 21, 2019 · 1 comment

Comments

@BlayTheNinth
Copy link
Contributor

Minecraft Version: 1.14.4

Forge Version: 28.0.49

Description of issue:

The fix introduced for #5978 made it so players do not tick when dead, even if they haven't been removed from the world. This is because the isAlive() function not only checks for !removed, but also returns true if the player health is <= 0.

My mod Hardcore Revival has players remain in world with zero health upon death, counting down a timer during which they can be rescued instead of having to respawn. This is no longer possible, as they won't have tick events fired.

From the comments in the linked issue it sounds like it was a problem with being ticked while removed from the world, so narrowing down the check to only !removed (instead of isAlive()) should solve the problem.

@BlayTheNinth BlayTheNinth added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Aug 21, 2019
@Orange1861
Copy link

Could you post a PR that fixes this without reverting the previous fix?

@autoforge autoforge bot removed the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants