Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added PotionHooks, closes #3867, #4375 #4614

Merged
merged 5 commits into from Dec 2, 2018
Merged

added PotionHooks, closes #3867, #4375 #4614

merged 5 commits into from Dec 2, 2018

Conversation

mcenderdragon
Copy link
Contributor

@mcenderdragon mcenderdragon commented Dec 23, 2017 •
edited

This PR addresses #3867 by adding more Events for PotionEffects.
This should help mods to remove TickHandlers for cheking if a anything with Potions has happened.

Current Status

Currently tracking potions is quite hard and very performance intensive. You need to iterate over each EntityLivingBase in a World and map their current potions effects to see if they have changed from the last tick. This takes a good amount of time wihtout doing anything since potion effect changes do not happen that often.

How this PR fixes this

This PR adds events for the potion effects so modders are able to control what happens to creatures.

New Events:
PotionApplicableEvent
Fires before a potion is added to an entity, it can either allow the potion effect, deny it, or let vanilla handle if this potion will work.

PotionAddedEvent
This fires right before a potion is added to an entity. This event is only for notification purposes. It has an oldEffect field wish is not null if the player got a new effect of the same kind but with different duration or level.

PotionRemoveEvent
THis Event is fored if a potion is about to get removed (e.g. by drinking milk). This event is cancel able so the Effect will stay. Be aware that the PotionEffect can be null but the Potion is not, this happens if someone tries to remove an effect wish was not active.

@mezz mezz added 1.12 Feature This request implements a new feature. labels Dec 24, 2017
@mcenderdragon
Copy link
Contributor Author

mcenderdragon commented Dec 24, 2017 •
edited

Also fixes #4375

@mcenderdragon
Copy link
Contributor Author

is it just me or is travisCI not existing anymore ? it will not give me the error log

@mcenderdragon mcenderdragon mentioned this pull request Feb 27, 2018
Closed
@mcenderdragon
Copy link
Contributor Author

@mezz do you request any changes ?

@stale
Copy link

stale bot commented Mar 29, 2018

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale This request hasn't had an update from the author in a long time. label Mar 29, 2018
@mcenderdragon
Copy link
Contributor Author

Ok this can get merged.

@stale stale bot removed the Stale This request hasn't had an update from the author in a long time. label Mar 29, 2018
@liach
Copy link
Contributor

liach commented Mar 29, 2018

I believe this one is good to go. No merge conflicts.

@liach liach mentioned this pull request Mar 29, 2018
Closed
@mcenderdragon
Copy link
Contributor Author

@mezz this PR is ready to get merged.

@stale
Copy link

stale bot commented May 14, 2018

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale This request hasn't had an update from the author in a long time. label May 14, 2018
@mcenderdragon
Copy link
Contributor Author

I think this is ready to merge @mezz.

@stale stale bot removed the Stale This request hasn't had an update from the author in a long time. label May 15, 2018
@stale
Copy link

stale bot commented Jun 14, 2018

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale This request hasn't had an update from the author in a long time. label Jun 14, 2018
@mcenderdragon
Copy link
Contributor Author

go away stale.

@mcenderdragon
Copy link
Contributor Author

@mezz could you please review again ?

@mcenderdragon
Copy link
Contributor Author

mezz, please (●__●)

@Alpvax
Copy link

Alpvax commented Sep 13, 2018 •
edited

I understand that it's been a while since you got feedback, but mezz and the rest of the forge team have been busy on 1.13 recently.
Have a little more patience, hopefully it will all be much easier soon.

@pau101 pau101 mentioned this pull request Sep 15, 2018
Closed
@mezz mezz added the Assigned This request has been assigned to a core developer. Will not go stale. label Sep 30, 2018
@mcenderdragon
Copy link
Contributor Author

@mezz yeah I overlocked that, thanks :)

@mcenderdragon mcenderdragon changed the title added PotionHooks, closes #3867 added PotionHooks, closes #3867, #4375 Oct 12, 2018
@tterrag1098 tterrag1098 assigned mezz and unassigned LexManos Nov 15, 2018
@tterrag1098 tterrag1098 added the Needs Update This request requires an update from the author to confirm whether the request is relevant. label Nov 25, 2018
@tterrag1098
Copy link
Contributor

This (yet again) needs an update for merge conflicts.

@mcenderdragon
Copy link
Contributor Author

mcenderdragon commented Nov 25, 2018 •
edited

This complete hassle because 16f4903 removed one line ... but the merge conflict is fixed.

@tterrag1098 tterrag1098 removed the Needs Update This request requires an update from the author to confirm whether the request is relevant. label Nov 27, 2018
@tterrag1098 tterrag1098 merged commit 2a5268c into MinecraftForge:1.12.x Dec 2, 2018
@mcenderdragon
Copy link
Contributor Author

:D Thanks.

@chagacy
Copy link

chagacy commented Dec 4, 2018

I've been using the potionAddEvent, but i don't understand when the event is fired. It continuously fires when not consuming potions?

@mcenderdragon
Copy link
Contributor Author

From the description:

This Event is fired when a new Potion is added to the Entity. This is also fired if the Entity already has this effect but with different duration/level.

tterrag1098 pushed a commit that referenced this pull request Apr 13, 2019
@mcenderdragon @tterrag1098
added PotionHooks, closes #3867, #4375 (#4614)
914fe91
tterrag1098 pushed a commit to tterrag1098/MinecraftForge that referenced this pull request May 11, 2019
@mcenderdragon @tterrag1098
added PotionHooks, closes MinecraftForge#3867, MinecraftForge#4375 (M…
1d18724 
…inecraftForge#4614)
jbredwards added a commit to CleanroomMC/Danvil that referenced this pull request May 31, 2022
@jbredwards
Squashed commit of the following:
70abd24 
commit ef853685c8a5ab85075203818e6b209a3d3cc2c9
Author: Rongmario <rongmario@protonmail.com>
Date:   Thu May 26 19:11:17 2022 +0100

    Danvil now runs on Java 17, just barely

commit d59eda5e3cd8dc43476b1f6747f3e4181a62b5d5
Author: Rongmario <rongmario@protonmail.com>
Date:   Thu May 26 15:32:31 2022 +0100

    Change to use Bouncepad as primer (in some places)

    - NOTE: more are replaced, but they are generated when running `gradlew setup`, I'll update the README with proper steps of how to setup Danvil soon.

commit cf5fe10018b58249a189075c929cc527b6fe7eb9
Author: Rongmario <rongmario@protonmail.com>
Date:   Wed May 25 19:52:55 2022 +0100

    Update gradle to 4.10.3

commit 863ab2ca184cf2e2dfa134d07bfc20d6a9a6a4e8
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Tue Sep 3 23:22:38 2019 +0200

    Fix CME when removing ticket managers (#5861)

commit 45da4f6910abe824aa487056276f6bf2fadb7f24
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 29 03:25:57 2019 +0100

    Add checks for tile entities in now-unloaded chunks (#5724)

commit c2630d2a79d291f0ff364c02f74f8dee3e8aa77a
Author: Bartosz Skrzypczak <Barteks2x@gmail.com>
Date:   Thu Aug 29 03:25:11 2019 +0100

    Fix client sometimes generating biomes, causing incorrect biome generation on integrated server (#5720)

commit 05f4f5ec775fbba7cf5c0421041f417dd4c70a36
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 29 03:22:56 2019 +0100

    Fix invalid placeholder entity attributes (MC-150405) (#5718)

commit a5d0a86760ff56c90e6d79684be20042b9319335
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 29 03:02:29 2019 +0100

    Allow conditional loading of advancements (#5255)

commit 7b4a01703b350056ab288a6e21a6ad0ed30aa1af
Author: Derik <jensen.derik@gmail.com>
Date:   Wed Aug 28 19:58:43 2019 -0600

    Fix lightning not triggering EntityJoinWorldEvent (#5290)

commit 3b99c8063655f56fa6fd1a5e75b7e2f4924b69fa
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 29 02:21:38 2019 +0100

    Improve performance of persistent chunk checks (#5706)

commit 20efd7150a77f81fc0baaa87dd3544b33dd0089b
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 28 18:19:45 2019 -0700

    Fix copy paste derp

commit c56377e4ee34369212776c8955b4c6da43da136c
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 28 17:44:19 2019 -0700

    Remove test publish group.

commit 3e98e16f3960e738980dc43cf47843b77e39e1c2
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 28 17:24:52 2019 -0700

    Fix windows installer directory.

commit d41cb552a1d564be7e0d1f0b7953f4268e6370a0
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 28 17:08:36 2019 -0700

    Use official launch4j plugin to potentially fix build.

commit ae2cb06d2cb4f7fcf99f2725e8b19a11aaae1537
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 28 16:06:54 2019 -0700

    Move to Jenkinsfile and new Jenkins server.

commit 9de91930620634eaa0d0910721de96c4ebf6dd09
Author: Gabriel Harris-Rouquette <gabizou@me.com>
Date:   Thu Aug 15 10:42:21 2019 -0700

    Fix error prone state lookup during rail neighbor updates. (#6028)

commit f8d32a852504018de687e88d7d29a26f10225bdc
Author: Unnoen <Unnoen@users.noreply.github.com>
Date:   Sat Aug 3 07:16:20 2019 +1000

    Don't cache OBJ and B3D models. Throw model loading errors immediately. (#5758)

commit dac053415b8187c5b13f3350d718e20d1bf53496
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Aug 2 22:14:41 2019 +0100

    Improve performance of smooth vertex lighting (#5763)

commit 7a5211666510b135485fd1b4c1fddf501a592e97
Author: Joseph C. Sible <josephcsible@users.noreply.github.com>
Date:   Fri Aug 2 17:12:52 2019 -0400

    Fix SidedInvWrapper hashCode when side is null (#5787)

commit 9ba67cedf1cf9046ed571c9f4ddb8eda9e4dac6f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Aug 2 21:43:12 2019 +0100

    Fix concurrent modification when loading chunk tickets (#5876)

commit 5aac0beba9067d520638f8e2cfd48ce3ad788328
Author: Cloudhunter <me+github@cloudhunter.co.uk>
Date:   Fri Aug 2 21:41:18 2019 +0100

    Fix link applying to whole component in chat if component starts with link (#5910)

commit 7849aebab03edf112636a5076e287640bec30415
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Aug 2 21:39:05 2019 +0100

    Protect against concurrent modification in World#setTileEntity (#5752)

commit ea26df0174b2f9338cab0846366d93299f691df7
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Aug 2 21:33:43 2019 +0100

    Fix more potentially unclosed resources (#5760)

commit 3a62514e60b16873cd87a36119db7fbeb60eedc2
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Aug 2 21:32:08 2019 +0100

    Fix various unclosed I/O resources (#5766)

commit 9a636e3c76f9da868b4167e877e57885bdb2a643
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon May 13 18:01:08 2019 +0100

    Fix vanilla handling of options file (MC-117449, MC-151173) (#5725)

commit fa35f30e86b494ac10dffefd637bc035b10c8bce
Author: clienthax <clienthax@gmail.com>
Date:   Thu May 9 01:46:04 2019 +0100

    Update EnumHelper to be compatible with Eclipse's OpenJ9 JVM. (#5712)

commit 633fd9bd2eea06abd2eb42484439a5250236435b
Author: tterrag <tterrag1098@gmail.com>
Date:   Sat Apr 13 09:54:03 2019 -0400

    Revert "Invalidate tile entities that are queued for removal (#5512)"

    This reverts commit 75788f63eea6c33ccef7e5cbcab27ad9ad2c2a04.

    This solution is invalid as TEs are free to modify the world tileEntities
    list, usually indirectly via chunkloading, from inside invalidate().

    This happens in vanilla, in TileEntityChest#invalidate, where it calls
    checkForAdjacentChests(), which has the potential to load neighboring
    chunks and cause a CME.

    A more sophisticated solution is needed.

commit 3c426a2e6603ec4267e874c6b26cf1beafe558cd
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 21:05:19 2019 +0100

    Fix some vertex format changes not being handled correctly (#5368)

commit 25375f63cc4fc2b03a14789f55627825797cdca1
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 17:59:16 2019 +0100

    Transform vertex normals as well as positions when generating quads (#5242)

commit 45cadab7c5b834b05e2db5fe23df505f6fef4114
Author: Robert WC Seifert <rseifert.phone@gmail.com>
Date:   Thu Apr 11 11:29:14 2019 -0400

    Fix for SidedInvWrapper isItemValid using wrong slot (#5642)

commit 75788f63eea6c33ccef7e5cbcab27ad9ad2c2a04
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 16:03:36 2019 +0100

    Invalidate tile entities that are queued for removal (#5512)

commit 3e7b8809b626e6db9230a9a364bdc9eb2961024b
Author: lclc98 <lclc98@users.noreply.github.com>
Date:   Fri Apr 12 01:01:40 2019 +1000

    Added Wool to OreDictionary (#5414)

commit 6162f438f18f5e78f31239cdef1a62aab374f95a
Author: CreativeMD <CreativeMD@users.noreply.github.com>
Date:   Thu Apr 11 16:18:26 2019 +0200

    Fixed boat not taking care of block-liquid hooks (#5086)

commit 1752e57ea03394e5fe184301599b2a2e6c453e42
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 15:05:19 2019 +0100

    Add Forge dimension-changing hooks to spectator handling code (#5212)

commit e91ef7f56b28bae5d10c59e1973a7473260631e9
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Thu Apr 11 16:03:01 2019 +0200

    Minor performace improvement when building chunks and rendering blocks (#5286)

commit 24f7be2f37d282f9866171509a0912047b88a066
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 13:52:23 2019 +0100

    Catch json parsing errors from constants/factories files (#5258)

commit 208ed997d44f6b481fac9f6ceae1fba890b9af0e
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Apr 11 13:33:12 2019 +0100

    Allow custom DataSerializers to be registered safely (#5245)

commit 1f12642a05e4f97ff1d83abb1a7c787422490900
Author: cpw <cpw+github@weeksfamily.ca>
Date:   Sat Apr 6 13:43:52 2019 -0400

    Try and make 1.13 mods more obviously wrong in 1.12..

    Signed-off-by: cpw <cpw+github@weeksfamily.ca>

commit e7beed487531d199ca1ddffa7b7cc314024bf8a8
Author: tterrag <tterrag1098@gmail.com>
Date:   Thu Mar 28 00:33:05 2019 -0400

    Fix #5651 Re-add canPlaceBlockOnSide check in World#mayPlace

commit 69a44e64142236a218c9cdea6b90f8a83143147c
Author: Pokechu22 <pokechu022@gmail.com>
Date:   Fri Mar 22 09:53:07 2019 -0700

    Fail fast when null is used with setTag instead of crashing in writeEntry (#5257)

commit 3870951a3738389bea521bd13b2b08efba542f77
Author: tterrag <tterrag1098@gmail.com>
Date:   Wed Mar 20 23:18:26 2019 -0400

    Fix block placement not checking for player collision

commit af4fcd73a47cca997822b30ea3578d976fc52c84
Author: Wyn Price <wynprice999@gmail.com>
Date:   Fri Mar 15 19:38:52 2019 +0000

    Added more Constants (#5323)

commit 04a6b6c2d0d16f229475a077295fc495d970a2d1
Author: Thanh-Phuong <python0429@gmail.com>
Date:   Tue Mar 12 01:01:35 2019 -0400

    [1.12.2] Add a few events pertaining to villages (#5302)

commit 1b15c127a694b4f5d5e5ee0ef609e54b11a76ec7
Author: Tyler Hancock <darklime@live.ca>
Date:   Tue Mar 12 04:44:08 2019 +0000

    [1.12] Fix special spawn event not firing in many cases. (#5389)

commit 8670abca5771750814e6c313284ab32ea72c5ce4
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Tue Mar 12 04:34:29 2019 +0000

    Only prompt for missing registries on local worlds (#5348)

commit f3d364397dec1cea9ab2d732b158ea4122e9aa5c
Author: Christopher Krier <ckrier.3000@gmail.com>
Date:   Tue Mar 12 00:22:47 2019 -0400

    Add EntityPlaceEvent (#5057)

commit cc95c40b5ba0b2219d492b6506fa1040fa9e9fb1
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Tue Mar 12 04:02:57 2019 +0000

    Generalise EnumRarity to an interface (#5182)

commit e6fbf39591b920532ea464d36dad24671c6d08fd
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Feb 15 06:46:35 2019 +0000

    Apply access-level changes to inner class attributes (#5468)

commit 8cbac6af97ecb852e0ff9e33a9bf9fcb579b35d7
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Feb 13 22:03:37 2019 +0000

    Fix small logic error in ItemTextureQuadConverter (#5463)

commit 87cbf735a211fbc26252467d3c09e56f28f3e0ab
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Feb 13 20:58:43 2019 +0000

    Better support for custom bows (#5209)

commit bcbf18491542b6eb8ef5516beb71a7ed9f1aa6a9
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Feb 13 20:28:58 2019 +0000

    Improve tracking of used dimension IDs (#5249)

    Closes #5378 Large dimension IDs bloat level.data

commit 965d8728564420983ef15377612c61274c2cd54f
Author: Phylogeny <molecularphylo@gmail.com>
Date:   Wed Jan 16 02:37:06 2019 -0800

    Fixed incorrect string representation of string list config property default values in their comments.

commit 41a098e2f789a507d8d56f4aa3facfe9c8088164
Author: CovertJaguar <covertjaguar@gmail.com>
Date:   Wed Feb 6 15:35:18 2019 -0800

    Remove FluidStack amount from hashcode calculation (#5272)

commit 41d07e7aae10243c638b9dce4951b95651505008
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon Feb 4 19:48:08 2019 +0000

    Fix up torch placement logic to handle more vanilla special-casing (#5426)

commit d1adf00158abb9f5491ab0348f982e6c222173dc
Author: LexManos <LexManos@gmail.com>
Date:   Fri Feb 1 00:46:29 2019 -0800

    Written size does not include int bytes.

commit ed67b6fd314552ccfe9f1d904dee65d954efba17
Author: LexManos <LexManos@gmail.com>
Date:   Fri Feb 1 00:34:45 2019 -0800

    Extend Region files to support >1MB per chunk.
    If the 'sector count' is 255, ask the compressed data header for the proper length.

commit d5ff207fabd9d50c8739c6df5dc98d8ede7ea562
Author: tterrag1098 <tterrag1098@gmail.com>
Date:   Sat Jan 19 16:40:49 2019 -0500

    Add default impl to IConfigElement#getValidValuesDisplay

commit da7c299f7e975c44759cb3b9f34480e6ab1affab
Author: tterrag <tterrag1098@gmail.com>
Date:   Mon Jan 7 18:19:53 2019 -0500

    Simplify custom item rendering by removing GL emissivity hacks

commit 204ebdc6dd0249055ec379750be7e33a3c51ac18
Author: tterrag <tterrag1098@gmail.com>
Date:   Fri Jan 4 13:48:36 2019 -0500

    Support diffuse lighting flag in item rendering

commit be565d2ddc6f2f7a6b2c8ec743c5c301216fa262
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jan 4 04:22:24 2019 +0000

    Add a hook to allow continuously using items through stack changes (#4834)

    * Add a hook to allow continuously using items through stack changes

    * Update licences

commit 21f7c31f6217d91b9d6a0afc012b068e1a59b744
Author: oOMitchOo <oOMitchOo@users.noreply.github.com>
Date:   Fri Jan 4 05:10:56 2019 +0100

    Added an additional constructor to every implementation of IFluidBlock. It is now possible to create a fluid block with a Fluid, Material and MapColor, so that the Material's MapColor isn't used for the blocks MapColor. (#5293)

commit 4e11c95d0e0f657273bbfcf336ccb405101b0838
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jan 4 04:02:11 2019 +0000

    Add redirects to PotionEffect to respect registry replacement (#5213)

commit d1478ca52996894e1d83a9f9a6694bb9c84e3af0
Author: AlexiyOrlov <alexiy.ov@gmail.com>
Date:   Fri Jan 4 05:07:24 2019 +0200

    Add an annotation for @Config elements which will automatically create a slider control (#5026)

commit 359d4fe2d58b1c83abad7ad8e94bee773b38cfcb
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jan 4 02:11:34 2019 +0000

    Fix small logic error in emissive item rendering code (#5320)

commit d3f27cf6fbb36f5ff7189fba0c985955e3cf45b5
Author: Phylogeny <molecularphylo@gmail.com>
Date:   Thu Jan 3 18:08:05 2019 -0800

    Allow config GUI cycling button elements generated from enums to display toString return values, rather than actual values. (#5125)

commit 3dd8c8ae6f197c75b23008f5533160b2794a1c85
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jan 4 02:00:39 2019 +0000

    Fix incorrect indexing in mipmap generation code (#5201)

commit 54882f2564d892feb0f794697597f7180af8f265
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jan 4 01:36:32 2019 +0000

    Ensure slave maps are cleaned up when handling registry overrides (#5250)

commit c5402d50fad5dbb649015d9b6d9bead6b710e035
Author: Daniel Scalzi <d_scalzi@yahoo.com>
Date:   Wed Jan 2 20:28:04 2019 -0500

    Fix issue with --modListFile. (#5316)

commit a5f29570a39508afe96870e7e665ff4bbf964aa8
Author: LexManos <LexManos@gmail.com>
Date:   Fri Dec 7 22:03:32 2018 -0800

    Fix potential issues with the Minecraft FakePlayer lingering around after world unloads.

commit dd27209565fd86d46ad91c5d36d202b704f0632c
Author: tterrag <tterrag1098@gmail.com>
Date:   Sun Dec 2 13:20:02 2018 -0500

    Fix potion remove event not always firing, add expiry event

commit f1d1e8853b278ab2c09df264583ae6cc76d0c752
Author: tterrag <tterrag1098@gmail.com>
Date:   Sun Dec 2 03:05:53 2018 -0500

    Clean up CraftingHelper constants loading API

commit 5ef199f6d71f2baba34fd4cc4ac3fa160274d580
Author: tterrag <tterrag1098@gmail.com>
Date:   Sat Dec 1 23:33:22 2018 -0500

    Fix crash from CraftingHelper due to FileSystem being closed early

commit 2a5268c6993f2de7612789bfac2b674d04c87e89
Author: mcenderdragon <goto.minecraft@googlemail.com>
Date:   Sun Dec 2 02:13:13 2018 +0100

    added PotionHooks, closes #3867, #4375 (#4614)

    * solved merge confilct

    * improved var names & removed tabs

    * Added spaces around !=

    * fixed typo

commit 32c24be6b49769b6d9be73b46144f62cabe13175
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Sun Dec 2 02:08:04 2018 +0100

    Add a hook for farmland watering (#4891)

    * Add a FarmlandWaterCheckEvent to allow mods to override when Farmland is watered or not

    * revert 1.12.2 json

    * Move the farmland patch to a ticket based instead of a event based system

    * Minor changes

    * Faster isValid checks, faster validation/invalidation if the state did not change, expand test mod to include a test for the validation system

    * remove isValid boolean flag, we can express it with the tick counter

    * Fix test mod resource warnings

    * Remove tick timeout, add a javadoc note to invalidate on chunk unload, cleaned up test mod

    * Allow mods to provide custom handling to determine if a pos is valid or not

    * Make SimpleTicket more simple, make register public so custom tickets can be registered

    * Fixes for review

    * Add missing license headers

    * Use a weak hash set

    * Split up the map into smaller chunk based maps

    * Add missing license headers

    * Make MultiTicketManager more universal for custom implementations, cleanup imports

commit 5f56b7cd096add31687b21bbb8b6be92a112e7c0
Author: temp1011 <34900092+temp1011@users.noreply.github.com>
Date:   Sun Dec 2 00:46:19 2018 +0000

    Add methods to allow loading json constants outside of _constants (#4975)

    * add interface methods for loading json constants from an arbitary file

    * use try-with-resources

    * don't make modders create jsoncontext, clean up resource use

    * very minor cleanup

commit 7f337cf2309631bccd2d6c573c1a348f48f067f3
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Sun Dec 2 01:38:46 2018 +0100

    Compute ASMDataTable submaps parallel, speeds up contructing mods (#5246)

    * Compute submaps parallel, speeds up contructing mods by a lot

    * Use stream API better

commit 7731e1cd7529b1efabd72799cc5fda6d0eb6bcbc
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Sun Dec 2 01:28:02 2018 +0100

    Add logging for data manager key registration errors (#5129)

commit f8879b1316c42c18051460c7e1349faea228b30a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Dec 2 00:27:20 2018 +0000

    Improve support for custom block path types (#5203)

commit 3dfe47944d80432c31108b8497b6ed9376faf4be
Author: Luke Gilfoyle <bluemonster122@users.noreply.github.com>
Date:   Sun Dec 2 00:14:48 2018 +0000

    Fix missing comments in configs created with annotations (#5189)

commit c11a712e2f87388126f70a88c579777ab5e74a2f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Dec 2 00:08:15 2018 +0000

    Allow items to control the rate of repair from mending (#5102)

commit 5771c8ffea9a4b31043358a26ec456218a724ac0
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sat Nov 24 02:08:24 2018 +0000

    Improve exception handling from server starting events (#5226)

commit 9587f08ece96327ec0ba0faae469277c1baf2bc2
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sat Nov 24 00:36:29 2018 +0000

    Improve context provided by potion icon rendering hooks (#5111)

commit 73b6d10e5a0711eea9de53cd82845a55d0160059
Author: MrRiegel <ichhabads@gmail.com>
Date:   Sat Nov 24 01:03:44 2018 +0100

    Fix an ObjectHolderRef internal error message (#5214)

commit 90c244acb4781e577782781f656b105c49340d6a
Author: tterrag <tterrag1098@gmail.com>
Date:   Fri Nov 23 18:57:00 2018 -0500

    Implement rendering for item models with emissive quads (#5047)

commit 3cf97f43fec5514033f24b099218c3254753dff8
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:44:35 2018 +0000

    Fix minor issue in getFilledPercentage for Fluid rendering (#5206)

commit 0b47ccc015dd1ac2a1d9210b49938cff6f2596d7
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:42:11 2018 +0000

    Clean up logged mod states (#5227)

commit 8d372f95f28edc7f910849c68a01da9ad39a9494
Author: Paul Fulham <paul.fulham0@gmail.com>
Date:   Fri Nov 23 15:40:46 2018 -0800

    Fix inaccurate main thread name shown in client log (#5078)

commit d16472d0ba38c04d46fbdb59cc035c6796b4798f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:37:53 2018 +0000

    Improve reflection helper methods (#4853)

commit 896db6398fff87afb250e8d943d27fde32c5142d
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:28:30 2018 +0000

    Fix Baked Item models with transformations (#5241)

commit e406137b19596224997397ebfbd033f21defefce
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:24:18 2018 +0000

    Prevent RecipeBook from crashing on empty modded ingredients (#5234)

commit 16f490328586064a4b734622ee3d93376bb9e386
Author: Vincent Lee <williewillus@users.noreply.github.com>
Date:   Fri Nov 23 17:22:08 2018 -0600

    Stop firing LivingSetAttackTargetEvent for setRevengeTarget (#5217)

commit 84d322da34cd02677d863c07c895de9b6c15cd20
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:20:30 2018 +0000

    Fix missing string parameters in some log messages (#5210)

commit 3a64cb898597a91fb4c75b7f0d523fa5cc0d328d
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Nov 23 23:19:44 2018 +0000

    Re-add some missing villager profession patches (#5200)

    * Fix zombie villagers only spawning with vanilla professions
    * Fix spawning modded villagers that do not have their own building

commit 2fef75c1dee7c5032b72873c769f05da68575384
Author: TheIllusiveC4 <itwasmec4@gmail.com>
Date:   Fri Nov 23 15:15:33 2018 -0800

    Fix the bed position given to the SleepingTimeCheck event (#5107)

commit c040a8865ffb7e204919da9a62bb521b5b46ad61
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Nov 15 21:52:45 2018 +0000

    Fix some null returns from defaulted registries (#5235)

commit 4931fc19071da1334f0110199c3eed282744ac56
Author: Yanbing Zhao <zzzz@mail.ustc.edu.cn>
Date:   Thu Nov 15 13:39:30 2018 +0800

    Only remove synthetic lambda methods referenced in body of SideOnly methods (#5127)

commit 607da1bd9b07ed07d8332530d90bca869503cc6d
Author: LexManos <LexManos@gmail.com>
Date:   Tue Nov 13 16:16:33 2018 -0800

    Use HTTPS for files website.

commit ebc4eaddac66e8d9eee6a859b473d3165b1bbfdb
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon Nov 12 20:50:00 2018 +0000

    Fix patches from #5160 setting rotation as well as position (#5233)

commit 10dbbf9c1915b7f5b2fc879a630b199aedbd192a
Author: LexManos <LexManos@gmail.com>
Date:   Mon Nov 12 12:47:27 2018 -0800

    A different approach to my changes in https://github.com/MinecraftForge/MinecraftForge/commit/8ace535995522bec0557d4217e0d98b3dc76cf1e to fix #5207

commit f9c2f715fd63bed9d4bd78b332ed348ad7383a30
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Oct 19 00:22:32 2018 +0100

    Allow IModel to express itself as a vanilla parent (#5195)

    * Fix errors caused by fancy missing model being non-vanilla parent

    * Switch instanceof checks to a default IModel method

    * Small code tweaks

commit 4e1f7138ee5a3962d8c6fb66d6ef1dd012a450f4
Author: gaudus <ichhabads@gmail.com>
Date:   Tue Oct 16 13:37:07 2018 +0200

    fixed visual bug with guislider

commit 5ae5d816090c2c3464283ed4bf4902ec20a2ed8c
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Oct 19 00:21:26 2018 +0100

    Make Forge blockstate variants correctly inherit AO setting from vanilla models (#5190)

    * Make Forge blockstate variants correctly inherit AO setting

    * Move variant format checks into variant, check for added properties

    * Small code cleanup

commit 947a004138bf8da447129adfa9fb11ecc1cc0776
Author: Ben Staddon <quadraxis@hotmail.co.uk>
Date:   Sat Oct 6 15:50:01 2018 +0100

    Make Forge-provided default transforms accessible to custom models

commit e4ca526d5b90f8f169850d5c9bbee9ade007f4d8
Author: InsomniaKitten <admin@designdevils.co.uk>
Date:   Wed Aug 8 21:12:39 2018 +0100

    Add CreativeTabs#getLabelColor

commit 1ba084f131975e1e38181c21f8b9f1e9cab6f9ba
Author: XCompWiz <XCompWiz@users.noreply.github.com>
Date:   Fri Oct 12 02:25:25 2018 +0300

    Allow providing a BufferedImage for banner render generation (#5041)

    * Adds an Event to allow providing a BufferedImage for the banner render generation (cached)
    This allows mods to provide generated banner textures, since banners don't use an atlas.
    Includes reference/test implementation.

    * Missed some copyright; might as well absolut text match, I guess

    * Remove unneeded patch change

    * Fix event variable access convention

    * Formatting fix

    * Improve event handling registration

    * Import cleanup

    * Replace event approach with Supplier approach

    * Better name for test mod (now that it's no longer an event); adds ENABLE flag

    * Moves MC code into net.minecraftforge.client.MinecraftForgeClient.getImageLayer to simplify patch

    * Generalize naming

commit 857573f10fbb18b3b15d7053757a2216730b459d
Author: Tim <4258783+dargonforce@users.noreply.github.com>
Date:   Sun Oct 7 15:37:23 2018 -0400

    Fix Mesa biome entry tags in the BiomeDictionary (#5177)

commit 76c138c40043431a6cdecf674570d757d89b26c7
Author: LexManos <LexManos@gmail.com>
Date:   Thu Oct 4 00:34:49 2018 -0700

    Bump version number for RB.

commit 55a7c6d64b61a40a5d7aa8cef4259f2209e2cd5e
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Oct 4 08:27:17 2018 +0100

    Add a notification event for handling game rule changes (#5152)

commit 0fb884462394fe604ce19f0b3113be81a4b5d805
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Oct 4 08:25:58 2018 +0100

    Patch PotionHelper to use registry delegates (#5142)

commit 633746673523e9375a933fa00badcc180018332e
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Oct 4 08:24:51 2018 +0100

    Prevent some texture loading errors from crashing the game (#5121)

commit 214275babadb9288ecea779245442687dd3ae8cd
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Oct 4 08:24:01 2018 +0100

    Change biome spawn list entries to use factory method where possible (#5075)

commit 82262e462e5ea8ff3a368ffce7d0edfd301dfeb0
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Oct 4 08:20:44 2018 +0100

    Change universal bucket support to use fluid names instead of instances (#5031)

commit ee0d43bbde37e258c36de1003436dbe3fcf88077
Author: tterrag <tterrag1098@gmail.com>
Date:   Fri Sep 28 15:32:19 2018 -0400

    Fix NPE on clientside entities constructed with null world (#5170)

commit 93b704b459c6f537d3b1651008c49ce1db2e0ca1
Author: tterrag <tterrag1098@gmail.com>
Date:   Thu Sep 27 21:34:26 2018 -0400

    Fix patches from #5160 running on the client and causing stutter

commit 10036aa764f9678ef2c86cde40ddcaf72d32dc95
Author: gegy1000 <gegy1000@gmail.com>
Date:   Thu Sep 27 23:27:21 2018 +0200

    Class transformer optimizations (#5159)

    * Filter packages for deobf transformation
    * Only serialize transformed class with TerminalTransformer if bytecode changed

commit fcd00bd4af61a640c54715bdce79455ecedd9060
Author: mezz <tehgeek@gmail.com>
Date:   Wed Sep 26 21:22:54 2018 -0700

    Update github stale so issues can be Assigned

commit c20a5e8805f64097430cf0722011f20862a8df9c
Author: Gabriel Harris-Rouquette <github@gabizou.com>
Date:   Wed Sep 26 11:08:30 2018 -0700

    Fix MC-136995 - Chunk loading and unloading issue with entities placed in exact positions. (#5160)

    Scatter gun patches to improve entity tracking and position tracking.
    Provided by Aikar through the Paper project, this commit of patches combines the following patches:

    https://github.com/PaperMC/Paper/blob/fd1bd5223a461b6d98280bb8f2d67280a30dd24a/Spigot-Server-Patches/0306-Mark-chunk-dirty-anytime-entities-change-to-guarante.patch
    https://github.com/PaperMC/Paper/blob/fd1bd5223a461b6d98280bb8f2d67280a30dd24a/Spigot-Server-Patches/0315-Always-process-chunk-registration-after-moving.patch
    https://github.com/PaperMC/Paper/blob/fd1bd5223a461b6d98280bb8f2d67280a30dd24a/Spigot-Server-Patches/0335-Ensure-chunks-are-always-loaded-on-hard-position-set.patch
    https://github.com/PaperMC/Paper/blob/fd1bd5223a461b6d98280bb8f2d67280a30dd24a/Spigot-Server-Patches/0378-Sync-Player-Position-to-Vehicles.patch

commit 8ace535995522bec0557d4217e0d98b3dc76cf1e
Author: LexManos <LexManos@gmail.com>
Date:   Mon Sep 3 21:20:23 2018 -0700

    Fix --mods and --modListFile arguments not making it past LaunchWrapper.

commit f2da4be93e436258aaa52f3b053b842838dd33d2
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon Aug 27 02:57:44 2018 +0100

    Remove BlamingTransformer (#5115)

commit 4aaa0370abc26b023ceebe9df5f0d5c326ab0aa9
Author: LexManos <LexManos@gmail.com>
Date:   Wed Aug 22 11:56:35 2018 -0700

    Fix more apache exclusions.

commit c6abcf5b84cbce6ad425475b5cdc0b9e4f886578
Author: LexManos <LexManos@gmail.com>
Date:   Tue Aug 21 23:50:25 2018 -0700

    Change org.apache to org.apache.maven. class loader exclusion.

commit d0e40ca726aaad4dd56e8a5cd5ed2432af416bdc
Author: mezz <tehgeek@gmail.com>
Date:   Sat Aug 18 11:21:53 2018 -0700

    Increase time it takes for Github Pull Requests to go stale

commit 69233f1bbf197948691dfe291a0c656dfa8efb0f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 16 21:21:21 2018 +0100

    Add variant alias for item models not loaded via blockstate (#5025)

commit f6b3893a05ce8c3d0e00900c286f4b4e9abad403
Author: mcenderdragon <goto.minecraft@googlemail.com>
Date:   Thu Aug 16 22:19:45 2018 +0200

    Added getter for children of CompoundIngredient (#5082)

commit f1dfb809315fd90b5b3ee1e3074cde55328792a2
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 16 21:18:25 2018 +0100

    Allow network leak detection level to be specified (#5067)

commit 222a110eb132056793b4d91f2bf846220a1e44b8
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 16 21:17:27 2018 +0100

    Fix saved toolbars not working with non-vanilla items (#5063)

commit 6ece0ba2548ee5bad430f8690077e34a2d3074f9
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 16 21:16:31 2018 +0100

    Fix server watchdog thread occasionally crashing on first run (#5019)

commit 8e7b5be3d42e151aef2cfe48208209635a46e447
Author: TheIllusiveC4 <itwasmec4@gmail.com>
Date:   Thu Aug 16 16:14:34 2018 -0400

    New SleepingTimeCheckEvent to add yet another way to control sleeping. (#5013)

commit 1171668c25526bf360549b9670dd5b67aa45e355
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Aug 16 21:03:32 2018 +0100

    Allow sending packets to client from ServerConnectionFromClientEvent (#4991)

commit 1f58bd71c09fb90165de4161832d14a0698f731a
Author: TheCyberBrick <TheCyberBrick@users.noreply.github.com>
Date:   Thu Aug 16 21:55:11 2018 +0200

    Fixed overworld spawn point reset when respawning in another dimension (#4982)

commit dd0c251b3d4b2058d35456a1a7e85b3ebc160449
Author: Pyrofab <redstoneinfire@gmail.com>
Date:   Thu Aug 16 20:54:56 2018 +0200

    Fix ModList cache never being updated (#5081)

commit 21097a4122bf969fb387d7745046f7d661d6e07d
Author: tterrag <tterrag1098@gmail.com>
Date:   Thu Aug 16 14:02:53 2018 -0400

    Fix loading languages with no underscore in the name (#5105)

commit 3b8146a06e889fa71cea138e5f4dec66742170ac
Author: Tom E <1036527+thommy101@users.noreply.github.com>
Date:   Mon Aug 13 05:00:05 2018 +0200

    Fixed Redstone and RedstoneDiodes placement on modded blocks that use BlockFaceShape.SOLID for Top.  (#5100)

commit afd6de3e305ed7f88c8f8a2f478b25e1af1e4e7e
Author: DaemonUmbra <daemon.umbra@gmail.com>
Date:   Fri Aug 10 01:12:42 2018 -0400

    Fix blank Server GUI console log (#5089)

commit cfa33be24bd1f96102a9fa0cfc9a8bc25603e484
Author: mezz <tehgeek@gmail.com>
Date:   Thu Aug 9 21:18:29 2018 -0700

    Fix SlotItemHandler.isItemValid check

commit 5a48ca99b6787c7f811045d1f98b26db6ce073b7
Author: mezz <tehgeek@gmail.com>
Date:   Wed Aug 1 22:28:22 2018 -0700

    Improve performance of FluidRegistry.getBucketFluids

commit 889fa4da7e8c708539fa8deb9253fad294dcc7a1
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Aug 1 21:35:56 2018 +0100

    Fix received data for last vertex format element not being recorded (#5074)

commit 682a867a91de7ffddd5f36b4505750f54b1f345d
Author: Karthas077 <Karthas077@users.noreply.github.com>
Date:   Sun Jul 29 14:21:24 2018 -0700

    Fix missing lang entry for Swim Speed attribute (#5064)

commit 9e30f4f6f9e213fc09a313144ec5455a78488e75
Author: Karthas077 <Karthas077@users.noreply.github.com>
Date:   Sat Jul 28 19:24:30 2018 -0700

    Added Swim Speed Attribute to EntityLivingBase (#4990)

commit f3f1e585dcd6f625ea33513c5ae3512db3184ba8
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Jul 29 02:55:33 2018 +0100

    Add function to lookup model location for an ItemStack (#5017)

commit 14bfeefb4dea4a5f57c88d97cde566ae3b143080
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Jul 29 01:51:44 2018 +0100

    Allow custom SpawnPlacementType registration (#4973)

commit a935859b24916d45287b692f87765a14c3cd29d9
Author: gegy1000 <gegy1000@gmail.com>
Date:   Sun Jul 29 02:47:01 2018 +0200

    Resource type sensitive ResourceManager reloading, Disabled by default, but may increase performance. (#4658)

commit 4c3e6ed139b335aff487391897ad399a5d703b63
Author: Brennan Ward <Bward7864@gmail.com>
Date:   Sat Jul 28 20:39:40 2018 -0400

    Improve crash report details (#5011)

commit c7c2921b2fa05b6d0fa9e6c2934c08fc84dcb71f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Jul 29 01:38:47 2018 +0100

    Fire colour events for mesa and swamp biomes (#5029)

commit 4acfca27f88627a78473a982c004a4a18875e8d4
Author: Cody Brittain <cbrittain10@yahoo.com>
Date:   Sat Jul 28 20:38:18 2018 -0400

    Add functionality in IItemHandler to test if a slot can accept an item (#5033)

commit eb870bc84c322aaec73c719f5688d1aa2dccecc2
Author: Kitten <InsomniaKitten@users.noreply.github.com>
Date:   Sun Jul 29 01:34:40 2018 +0100

    Added CreativeTabs#getBackgroundImage (#5034)

commit 36f74e955bb8cd6814040075229c5254bedef685
Author: Eragonn1490 <Chollis81@yahoo.com>
Date:   Sat Jul 28 20:32:59 2018 -0400

    Add wooden doors to the OreDictionary. (#5036)

commit 2786cd279cd8feb5965060da27f141d7c8ccf1e5
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jul 18 04:37:20 2018 +0100

    Update and clean up Forge fluid render model (#4763)

commit ab228832f24e53436d058a96ff9483376a917b02
Author: mezz <tehgeek@gmail.com>
Date:   Sun Jul 15 13:22:41 2018 -0700

    Allow configuring log levels using system properties. (#5024)

    Defaults are:
    -Dforge.logging.mojang.level=info (note that setting this to debug or trace will enable extra debug behavior which may slow things down or detect issues and crash)
    -Dforge.logging.console.level=info
    -Dforge.logging.file.level=info
    -Dforge.logging.debugFile.level=trace

commit f999e87f17324b006083cf6f607ca110b956b9df
Author: mezz <tehgeek@gmail.com>
Date:   Sun Jul 15 13:09:57 2018 -0700

    Update README on github to fix the CLA section

commit 6ae2287d5759a75dce7fa5b5daebf0d9adc6353c
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sat Jul 14 22:52:54 2018 +0100

    Add support for FluidStack-dependant colouring to Forge bucket (#4952)

commit cfebf2739359961c08bad01dfa2251492df9162e
Author: MrRiegel <ichhabads@gmail.com>
Date:   Sat Jul 14 23:29:32 2018 +0200

    Use itemstack in LivingEntityUseItemEvent.Finish before it was used (#5015)

commit 603f4bd7a3657e8721ab74d4363848e337d27d78
Author: bloodmc <bloodmc@users.noreply.github.com>
Date:   Sat Jul 14 17:28:42 2018 -0400

    Check use item result before calling onItemUseFirst. (#5016)

commit 97d58aeaa1ca0ee8b70cb9f1491edcadc5635aae
Author: tterrag <tterrag1098@gmail.com>
Date:   Sat Jul 14 17:08:22 2018 -0400

    Clean up and improve ICapabilityProvider javadocs (#4978)

commit c6f001bb6ccecd3f010958587ee73a75ec0c2cd6
Author: mezz <tehgeek@gmail.com>
Date:   Mon Jul 9 21:22:58 2018 -0700

    Update license header on ChunkIOThreadPoolExecutor

commit a98db5bef270e0afea904708de1a88972b0aa6b9
Author: tterrag <tterrag1098@gmail.com>
Date:   Mon Jul 9 16:45:50 2018 -0400

    Fix potential deadlock when chunkload raises non-IO exception (#4861)

commit da888df4639a870b4a4b1ab094904f3cac194bf2
Author: LexManos <LexManos@gmail.com>
Date:   Sun Jul 8 16:43:45 2018 -0700

    Fix MDK not having license texts.

commit 5624afbc3273c670ab22efa169bd3493f7a39897
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu Jul 5 03:59:12 2018 +0100

    Change some client hooks to use GlStateManager functions (#5010)

commit c3aa99677adbf34be56d6852277b6abb618c218a
Author: Marvin Rösch <marvinroesch99@gmail.com>
Date:   Thu Jul 5 04:58:55 2018 +0200

    Move some test mods into appropriate packages (#5006)

commit 1902363eac7e9e73b9676853e1ab7c8ffc9d3923
Author: Weissmoon <Weissmoon@users.noreply.github.com>
Date:   Wed Jul 4 19:58:36 2018 -0700

    Write full class name in undefined packet error messages. (#4970)

commit 58d570a6f19757d468cceb97aba86a33180041ef
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Tue Jul 3 06:41:18 2018 +0100

    Fix ItemHandlerHelper.giveItemToPlayer creating item entities with incorrect contents (#5007)

commit 0cf5ef221cd6d7e850b848d6c1ff537a48921edd
Author: LexManos <LexManos@gmail.com>
Date:   Sun Jul 1 14:17:28 2018 -0700

    Run licenseFormat to apply license header to all files.

commit eb94dc5c484d05344401cdccf74fd21f0f326d62
Author: Minecrell <minecrell@minecrell.net>
Date:   Sun Jul 1 20:39:10 2018 +0200

    Restore original license headers in Maven versioning package

commit 97627e7fb95f4e01ec8e57061f32439e530f26b1
Author: Minecrell <minecrell@minecrell.net>
Date:   Sun Jul 1 20:30:52 2018 +0200

    Restore original license headers of delta package

commit 60e8359324502854c2ee16bc61dcf562daf42e3f
Author: Minecrell <minecrell@minecrell.net>
Date:   Sat Jun 30 20:57:16 2018 +0200

    Setup configuration for licenser Gradle plugin

commit 9121b1f0c0e90a7491caaa5c9cfcc243fe113486
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 21:10:47 2018 +0100

    Fix player movement status not syncing across dimension change (MC-10657) (#4974)

commit 80724a52d3db7734721d36503518936e2d6ad16a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 20:56:46 2018 +0100

    Fix some ClassCastExceptions incorrectly being logged in FML handshake. (#4972)

commit 19de6cf97e5e4234457335e084b594f7dcc26d94
Author: KingLemming <kinglemming@gmail.com>
Date:   Wed Jun 27 15:53:45 2018 -0400

    Fix ISpecialArmor to allow for "Unblockable" damage to be handled if the armor opts in. (#4964)

commit 74c3aab72027ca5746228b834d3defeeaf3fd10a
Author: LexManos <LexManos@gmail.com>
Date:   Wed Jun 27 12:51:06 2018 -0700

    Fix FML entity network spawning not using EntityBuilder's facctory. Closes #4845 and #4846

commit 464cccaa3e7c1ebf277d77ecf24850f691aa88d8
Author: LexManos <LexManos@gmail.com>
Date:   Wed Jun 27 12:23:00 2018 -0700

    Fix NPE when sleeping in some custom beds. Closes #4956

commit 1007d3e9c5abf6580c7989ef6390134108abd1ca
Author: LexManos <LexManos@gmail.com>
Date:   Wed Jun 27 12:04:23 2018 -0700

    Added Fluid Place Block Event for when fluid changes blocks in world. (#4627)

commit 0e4d73230b0601350c4271ccac94e0147039afd7
Author: LexManos <LexManos@gmail.com>
Date:   Wed Jun 20 23:39:31 2018 -0700

    Cleanup licenses

commit c001d2dbf68e9199b44ba7e99065da08d0f2b0cf
Author: UnRealDinnerbone <UnRealDinnerbone@users.noreply.github.com>
Date:   Wed Jun 27 13:31:38 2018 -0500

    Add Farmland Trample Event  (#4895)

commit 539626727ce8131de4f9951c4881a29228d19a1a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 19:29:09 2018 +0100

    Switch from trove to fastutil collections (#4933)

commit 6367c15d324b537013df71590d64b418765e519d
Author: Kristiāns Micītis <latvianmodder@gmail.com>
Date:   Wed Jun 27 21:27:24 2018 +0300

    Added Item#readNBTShareTag(ItemStack, NBTTagCompound) (#4932)

commit 4e4ff66bd30e11b82b0b7de9ada81d990e8d39be
Author: tterrag <tterrag1098@gmail.com>
Date:   Wed Jun 27 14:25:03 2018 -0400

    Fix MC-234: Z-fighting when viewing break animation side-on (#4928)

commit 4d6fbd9d2ff179057be884ad4137fbb92f81cc5d
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 19:23:23 2018 +0100

    Clean up some dimension manager code and add a command to list dimensions (#4902)

commit a749861cb22c2139db18a07a84bf59568ee63328
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 19:08:38 2018 +0100

    Change item model loading priority to fix model conflicts (#4898)

commit 1db28d072ab46e7997cf8c1ce3c55466e2e5d940
Author: mezz <tehgeek@gmail.com>
Date:   Wed Jun 27 10:58:07 2018 -0700

    Improve server console implementation (#4821)

commit 43895d773e8304d9c970e0a3ebd4107014f9deb6
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 27 06:00:53 2018 +0100

    Add validation to recipe registry (#4957)

commit d09a8d98d7eefe9f2d1120f9d777873b5918b042
Author: mezz <tehgeek@gmail.com>
Date:   Mon Jun 25 22:09:17 2018 -0700

    Fix flickering leaves when mods break the blurMipmap settings (#4997)

commit f2d7a197028585886fec828233da82c7c08b3a55
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Jun 24 08:18:13 2018 +0100

    Clear out stored errors after model loading finishes (#4938)

commit 61666ed6aabc7a01e29ca9fadf72b7bf1d1b88fc
Author: Paul Fulham <paul.fulham0@gmail.com>
Date:   Sat Jun 23 23:38:57 2018 -0700

    Fix AutomaticEventSubscriber error message (#4986)

commit 59c3e1baaf31b4ffb3b0f659b0e9266ac0106d99
Author: mezz <tehgeek@gmail.com>
Date:   Sat Jun 23 12:33:13 2018 -0700

    Always wrap mod creation errors in LoaderException

    to make error message more clear

commit 7258beeede608b0512b744beb5e01bd5dbca3811
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 20 20:36:10 2018 +0100

    Fix vertex lighter using stale normal data (#4917)

commit fa50d98357fe6a52333fade830a714e2bfeffb40
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Wed Jun 13 06:58:45 2018 +0100

    Fix structure template processors causing cascading world generation (#4979)

commit 9cda586ebd402df2e0543444329cfc1dd08172ea
Author: LexManos <LexManos@gmail.com>
Date:   Fri Jun 1 00:07:17 2018 -0700

    Fix scala mods crashing with the json annotation cache.

commit d9a042c775a1beb7022c11cb7ef4e5371458330a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Jun 1 06:35:02 2018 +0100

    Fix black flickering on animated models by clamping max diffuse lighting multiplier to 1.0 (#4962)

commit bea02348e2845ef6b1f49b0692f79dbc097d2706
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun May 27 03:56:46 2018 +0100

    Fix crash from search tree processing invalid recipes (#4942)

commit b30540f20c7b7cfc69ea7d96da25ea9b92467a38
Author: LexManos <LexManos@gmail.com>
Date:   Sat May 26 16:42:58 2018 -0700

    Fix names in JSON annotation data not matching expected format. Closes #4953

commit 32438d2e00632d40238776d5e85a27535e0048fc
Author: LexManos <LexManos@gmail.com>
Date:   Thu May 24 18:38:01 2018 -0700

    Bump version in prep for new RB.

commit b654b843935b759569b5404fe2a93e3b84f37691
Author: LexManos <LexManos@gmail.com>
Date:   Thu May 24 18:37:05 2018 -0700

    Add potential support for models defining 'vanilla like' rotations in Forge's Modified Blockstate format.

commit f492e25bc9b99c9cd899a53e37c35ca6b8745824
Author: LexManos <LexManos@gmail.com>
Date:   Sun May 20 11:21:05 2018 -0700

    Copy the Dedicated server's EULA checking to main() function so it can exit earlier. Closes #3659, #3661

commit 0139a7baf2dfcaa708a46bdc9ca3df1d52bca536
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun May 20 05:25:08 2018 +0100

    Fix Forge bucket not declaring all texture dependencies (#4930)

commit 189df85b5aba38b84683711b24b291a9c6d42de6
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun May 20 04:50:57 2018 +0100

    Reuse multipart model instances across variants (#4791)

commit f9b8c992eec06c0e8ea53d6f1989c117980642c3
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 19 20:28:10 2018 -0700

    Fix language parsing for creating the java locale

commit 3c4efa1ae7c3b132f40b8298f6cf7a4139d43631
Author: sinus <thilo@meduka.de>
Date:   Thu May 17 13:15:57 2018 +0200

    Fixes parameter inconsistency in IFieldWrapper (Fixes #4325) (#4766)

commit fc1877dd961ffe0c51207b1f0b0a1e3688653cb2
Author: Kristiāns Micītis <latvianmodder@gmail.com>
Date:   Thu May 17 10:41:21 2018 +0300

    Added formatting support for status messages (#4925)

commit 330a9c4fd38e78c7c0ab5182dbad4425c2ef75ba
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 07:13:27 2018 +0100

    Fix server-side data not being released (#4882)

commit 8fdc6eff0787e0167f2b5a466de519f870d20c29
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 07:12:18 2018 +0100

    Fix memory leaks in EnchantmentHelper (MC-128547) (#4880)

commit e742a3f5983cbbf172632a87dbd199362bd1a900
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 07:06:50 2018 +0100

    Change composite models to fetch quads from submodels using full context (#4809)

commit fd201fb690ce63fda9c7c0faaa7e2bc7c062433d
Author: temp1011 <34900092+temp1011@users.noreply.github.com>
Date:   Thu May 17 06:54:34 2018 +0100

    Expand Villager Farmer AI to generic crops. (#4745)

commit 1d863cdefcbaf8a8059ef5658b6affe29f477b0e
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 06:52:32 2018 +0100

    Check name prefix used for tile entity registrations (#4681)

commit 40b567e9621e57f719d32d7752e8a438c4d53e08
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 06:48:14 2018 +0100

    Add an event to control nether portal formation (#4735)

commit 36f94fd20e940f5c0736dce8d8b226d3a23c7938
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 06:44:34 2018 +0100

    Allow custom models to have per-state lighting (#4732)

commit 8d994d074c28dd01bc22f1b1858e5d1846b2fbcf
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Thu May 17 06:29:03 2018 +0100

    Fix some light-emitting blocks letting light through (MC-119932) (#4642)

commit e7cd3d4df6206bc6366f026e3933edf15963d4d9
Author: temp1011 <34900092+temp1011@users.noreply.github.com>
Date:   Tue May 15 04:20:50 2018 +0100

    Preserve original ChunkPos for decoration events. (#4767)

commit 215157f5cd5cbe1dca6afd9cc1fc4896924811a0
Author: LexManos <LexManos@gmail.com>
Date:   Mon May 14 11:32:25 2018 -0700

    Fix library folder detection on various JVMs.

commit 38c5cb6b94904ead3a1e5e528c281476c2482cfd
Author: Take Weiland <diesieben07@gmail.com>
Date:   Sun May 13 20:39:13 2018 +0200

    Add supports for redirects when doing mod version checks (#4826)

commit c5d95cb3a9298860845c23e2d541876014ffdcd1
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 12 23:59:22 2018 -0700

    Fix imports

commit 979797a2a6651857decf05f5a878cf4e7efd271f
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 12 22:39:42 2018 -0700

    Give immediate and complete error messages when there is a crash during startup (#4869)

commit ad099a4bfe7245be7deb923dcc4e80c452a0b115
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 12 22:36:45 2018 -0700

    Revert "Give immediate and complete error messages when there is a crash during startup (#4869)"

    This reverts commit a38f5fd6a24297490671cd300b5e4a9020189f63.

commit dae7bcee4b4397cb6cd9ee1524d58510219bce34
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 12 21:07:25 2018 -0700

    Remove invalid optimization in ItemStackHandler#setStackInSlot #3465

commit a38f5fd6a24297490671cd300b5e4a9020189f63
Author: mezz <tehgeek@gmail.com>
Date:   Sat May 12 16:56:57 2018 -0700

    Give immediate and complete error messages when there is a crash during startup (#4869)

commit e65bd4a62b8fe003cd1f641625a8deadb076c36a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sat May 12 20:58:52 2018 +0100

    Clean up mod dependency checking code (#4922)

commit 33f4acb6b99b491cc7a40c1114c7125100c9b899
Author: mezz <tehgeek@gmail.com>
Date:   Fri May 11 17:58:21 2018 -0700

    Fix version range check for required mods #4918

commit b6f8be6718c6a3bcba96983f37d25a463784d424
Author: mezz <tehgeek@gmail.com>
Date:   Wed May 9 22:45:22 2018 -0700

    Add javadoc note about minimum required Forge versions for old Forge. Close #4918

commit 789d9437b28e769a53db856aebb9630e65b0130b
Author: mezz <tehgeek@gmail.com>
Date:   Wed May 9 22:40:14 2018 -0700

    Fix possible NPE when calling Loader.getIndexedModList #4919

commit 4f294da7990198b640f1c62205576e9b6c527ccd
Author: tterrag <tterrag1098@gmail.com>
Date:   Tue May 8 23:25:06 2018 -0400

    Fix MC-12269 Various Particles glitchy movement (#4914)

commit e1968e73b9b1ce6be86ea32cae42a10dbe087c48
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon May 7 22:19:11 2018 +0100

    Fix deobfuscator not regenerating super maps (#4856)

commit 9e9cb021ab6145965f44bf4b67424ad90655db17
Author: cpw <cpw+github@weeksfamily.ca>
Date:   Tue May 1 05:05:37 2018 +0100

    Clean up broken aliases caused by registry bug #4894. (#4909)

commit f2fa21e6e2f1c769e0db90781bc740201e0ba92b
Author: LexManos <LexManos@gmail.com>
Date:   Sun Apr 29 17:58:02 2018 -0700

    Move registry snapshot read/write code to Snapshot class. Cleaner code.

commit 4df55f3bd3c15213abebf0b3df3960900f451d1c
Author: LexManos <LexManos@gmail.com>
Date:   Sun Apr 29 17:57:33 2018 -0700

    Only revert to frozen data on server shutdown on client. Should fix race condition exposed by #4904

commit 412c2ae53f8dd24a7ed26ee0783c3585e44522ba
Author: LexManos <LexManos@gmail.com>
Date:   Sat Apr 28 04:28:40 2018 -0700

    Potentially fix issue with BungeeCord or other servers resetting the registry mappings on the client while the game is running.
    Errors may still occure if the client knows about world data beyond vanilla. Servers should NEVER send world/registry invocations before they have sent registry mappings.
    Closes #4901

commit 50014c7ca446616e53ea6b61d513465780aac8f0
Author: sfPlayer1 <sfPlayer1@users.noreply.github.com>
Date:   Fri Apr 27 20:53:04 2018 +0200

    Reduce range requirement for World.checkLightFor from 17 to 16 (#4729)

commit 2353800d6142e44bf9682047aea0575e208f00c8
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Apr 27 05:18:39 2018 +0100

    Fix typo in validation of vanilla registry wrappers (#4899)

commit c9f035cf035bcd07ab035f922604ee9f60b7df84
Author: Joseph C. Sible <josephcsible@users.noreply.github.com>
Date:   Sun Apr 22 21:58:21 2018 -0400

    Fix #4772: add an "isActivator" boolean to powered rails (#4774)

commit fc799564ed6d601364bc6cfe51bbfd2721d847e9
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 22 22:42:05 2018 +0100

    Add checks for undefined packet discriminators when sending messages (#4890)

commit 90bf8dd95dd3b7955896d3268d0ec13d06a7575f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 22 22:40:38 2018 +0100

    Fix some code holding client world references longer than needed (#4881)

commit bc545450e523e3e0678da9cd87731869ff02ece4
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 22 22:32:09 2018 +0100

    Don't try to render removed tile entities. Fixes MC-123363 (#4811)

commit a99fe416673dd17577fa7711d2b67fa5f571ca1a
Author: LexManos <LexManos@gmail.com>
Date:   Sat Apr 21 21:40:40 2018 -0700

    Fix overrides typo in saving registry data. Closes #4894

commit 34f4381e0ca6ae87c00034e7f5757e173b3dd02e
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 17 19:24:43 2018 -0700

    Fix library path and soft fail when repository root is not found.

commit 68ce80dad48cb58ac8d97bc0f2151320b8261424
Author: LexManos <LexManos@gmail.com>
Date:   Sun Apr 15 17:44:01 2018 -0700

    Fix libraries not being added to the modlist when using external metadata. Closes #4879

commit d9dbec05463cff111268a26dbe136a09ac6beb0c
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 15 03:43:45 2018 +0100

    Fix dragon fight not initialising correctly under some circumstances (#4868)

commit 32237f57ef9805f2b7907a065f572670c143bb43
Author: LexManos <LexManos@gmail.com>
Date:   Sat Apr 14 19:32:45 2018 -0700

    Cleanup some issues with the mod extraction to the memory modlist. Closes #4874 #4875

commit a794f1daffd546bec55ec4332c382b6f13337f3a
Author: mezz <tehgeek@gmail.com>
Date:   Sat Apr 14 18:17:06 2018 -0700

    Improve missing mod dependency error screen (#4762)

commit fab45a32a8c74563e3a368aa8f84d2cbd7bc4ddb
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 15 01:05:08 2018 +0100

    Fix biome dictionary's biome type detection (#4878)

commit 97a2143fc2d3cea4483bdbff07c5700cf3a8e515
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 15 01:00:38 2018 +0100

    Clean up Reader/Writer handling to use a specified charset (#4872)

commit d0566ebadc9f5a78c5566ae11bdf3ca50447863f
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Fri Apr 13 01:18:43 2018 +0100

    Suppress firing events at load time if an error has already occurred (#4801)

commit 76591f7245142553087235eb7527a154135216e1
Author: AlexIIL <AlexIIL@users.noreply.github.com>
Date:   Fri Apr 13 01:17:39 2018 +0100

    Fix FluidUtil.getFluidHandler skipping some fluid tile entities (#4854)

commit 0fca21fbc527892b4a331bb43ec52c89ad94d40d
Author: Erlend Åmdal <erlend@aamdal.com>
Date:   Thu Apr 12 01:26:53 2018 +0200

    Parse contained dependency Timestamp as long instead of int (#4866)

commit 9442a48e93310ace5550cff05efef6f6149d5c0f
Author: LexManos <LexManos@gmail.com>
Date:   Wed Apr 11 13:10:27 2018 -0700

    Fix Forge's metadata not being loaded. Closes #4865

commit b71caeb81324eff4562aeecc6d97cd2ba5ba0ea3
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 10 19:17:27 2018 -0700

    Fix mods without ModSide meta value.

commit 9d0771b3d736a1a1b26bcdfcbda193a626e95d59
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 10 16:01:35 2018 -0700

    Rewrite dependency extraction to use mod list system (#4841)

commit 3f4dfbb367e8b47a981bcec7e13ed33c8834289c
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 10 15:40:42 2018 -0700

    Bump Forge version for new dev chunk.

commit bad83a303e6770d484aad0b0d891549dc273cf05
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 3 15:29:25 2018 -0700

    Fix vanilla duplication bug.

commit 34706c7cd77fe2107794347cbf77ca59250019dd
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 3 15:26:28 2018 -0700

    Slow down Forge chunk gen worker when save queue is to high.
    Prevents task from completing while tons of chunks are pending save.
    And add minimum notification every 60 seconds.

commit 501e030f3ed0db1606547166ad2e753e3e38424c
Author: LexManos <LexManos@gmail.com>
Date:   Tue Apr 3 15:23:35 2018 -0700

    Add support for World Workers skipping ticks without being removed from the worker list.

commit 272b337aa33864ac3d9a855c5cd9ee1f79ac0a8b
Author: Vincent Lee <williewillus@users.noreply.github.com>
Date:   Mon Apr 2 14:58:15 2018 -0500

    Fix MC-88179 in a better way that avoids and closes #4824 (#4830)

commit 60e0f05b0d05bd4aa9b9b4ad807d3fc66abff209
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Mon Apr 2 03:01:22 2018 +0100

    Improve the warning logged for cascading world generation (#4725)

commit fe3478f233e9b3934ddc80330cb0f333b0a7ea1a
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 09:55:45 2018 +0100

    New ITeleporter interface making dimensional teleportation easier. (#4602)

commit 1d7c04daeba2ab2941cfe79aedc338d157a827c2
Author: Vincent Lee <williewillus@users.noreply.github.com>
Date:   Sun Apr 1 03:42:55 2018 -0500

    Add a FML outbound target for all players tracking a point or entity in the world. Closes #3677 (#4631)

commit f5c0b894bf54467a519caa45acf0448440d5b90d
Author: coolsquid <mail@coolsquid.me>
Date:   Sun Apr 1 08:12:46 2018 +0000

    Prevent EntityPlayer.attackEntityFrom from firing LivingAttackEvent twice (#4661)

commit e099aa32d40d0a7e590b2c2d9f77081f65a13b80
Author: Mackenzie McClane <6081834+Yuudaari@users.noreply.github.com>
Date:   Sun Apr 1 03:03:27 2018 -0500

    Add a way to get a list of registered biome types (#4685)

commit fff660918a6756beae15d9a14b295cb945b3f6f3
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 09:01:40 2018 +0100

    Improve performance of some ExtendedBlockState methods (#4698)

commit dda7bd5d42e66e60563be9d83904c4f2bb76baea
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 08:59:34 2018 +0100

    Optimise adding normal element to vertex formats (#4699)

commit 4c1167c96df738328630d2322c0372c157d25d80
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 08:54:22 2018 +0100

    Check for empty dimensions outside of chunk unloading loop, culling worlds without needing chunk unloads to trigger it. (#4704)

commit b8e411674b777778d4111b785567acf91b25f988
Author: Judge40 <Judge40@users.noreply.github.com>
Date:   Sun Apr 1 08:48:25 2018 +0100

    Create event for overriding mob griefing flag based on entity. (#4710)

commit 247d4cb5a8ce18a8c62050aa4e475d4e0e391450
Author: Joseph C. Sible <josephcsible@users.noreply.github.com>
Date:   Sun Apr 1 03:45:21 2018 -0400

    Add description to Error raised by the server hang watchdog. (#4714)

commit db3b2549e2b18f34403630e0c5c7c84da5d25869
Author: Parker Young <parker@parker8283.net>
Date:   Sun Apr 1 03:43:39 2018 -0400

    Update ItemHandlerHelper.giveItemToPlayer to allow player who picked up the item to hear the sound as well (#4720)

commit 6f642ba6ceb1978abdd5d63a5e4227f4cd1afa23
Author: CreativeMD <CreativeMD@users.noreply.github.com>
Date:   Sun Apr 1 09:40:26 2018 +0200

    Fixed Spectator mode particles and sounds computed from where you have been before (MC-46445) (#4728)

commit e82a7605dc7d1ae5bf623924db4a7c98606d9dbd
Author: Matti Ruohonen <matti.j.ruohonen@gmail.com>
Date:   Sun Apr 1 10:27:58 2018 +0300

    Add a WorldProvider#canSleepHere() method to allow providers to control sleeping in beds separately from re-spawning. (#4741)

commit 7c098462fedf3dd37903823d557db9263814d055
Author: malte0811 <malte0811@web.de>
Date:   Sun Apr 1 09:25:38 2018 +0200

    Fix FMLCommonHandler#exitJava printing useless/wrong calling info (#4742)

commit 0b5a6a3b031816ca46d4bc405a0062781dec914b
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 08:24:37 2018 +0100

    Reduce memory usage of model transforms (#4753)

commit fb61505d35d282dd5b168ae3e7664f158fa5499d
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 08:18:14 2018 +0100

    Fix some block connection logic not matching vanilla (#4781)

commit 14a8e099ca2d224d8c1b09395a47a313ddeaa690
Author: Mordenkainen <Mordenkainen@users.noreply.github.com>
Date:   Sun Apr 1 03:15:37 2018 -0400

    Fix for the player inadvertently being removed from the Entity Tracker when the chunk they were in unloads after they teleport out of it. (#4784)

commit 557b41056f42b35419fb0aac598e68d4285275d1
Author: Brennan Ward <Bward7864@gmail.com>
Date:   Sun Apr 1 03:08:55 2018 -0400

    Small performance improvement to ItemStack, by using Items.AIR directly instead of getting it from the Block map. (#4786)

commit 11e623bf4d40fe0b464f8cb142695112ff92dc41
Author: TheCyberBrick <TheCyberBrick@users.noreply.github.com>
Date:   Sun Apr 1 09:07:01 2018 +0200

    Added chunk instance to ChunkWatchEvent (#4805)

commit 1fcff02b677a2582426938f8f5240b2fde0a33a0
Author: temp1011 <34900092+temp1011@users.noreply.github.com>
Date:   Sun Apr 1 08:06:10 2018 +0100

    Add fences and fence gates to ore dictionary (#4807)

commit 483bf26aa4fe63d411f15c59bdbefe741c7fd5f0
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Sun Apr 1 08:02:57 2018 +0100

    Fix entities sometimes not rendering when out-of-world (#4823)

commit cfe3867a70d4709b069e5e57d0d048982ae979a7
Author: mezz <tehgeek@gmail.com>
Date:   Thu Mar 29 22:33:40 2018 -0700

    Fix issues with the test mods

commit 297a1eb766a89cf5e325182f6e54b4ba527a070a
Author: Marvin Rösch <marvinroesch99@gmail.com>
Date:   Wed Mar 28 07:09:10 2018 +0200

    Reorganise test mods into packages (#4706)

commit cfa3337884674326de74906b93de40e91554ba70
Author: Take Weiland <diesieben07@gmail.com>
Date:   Tue Mar 27 22:59:52 2018 +0200

    Fix servers crashing due to initializer on @SideOnly field (#4825)

commit ed314864f0379c4434d36d29f8ab7e13a95eb1cb
Author: Brennan Ward <Bward7864@gmail.com>
Date:   Tue Mar 27 07:26:58 2018 -0400

    Cleaner TileEntityItemStackRenderers, now stored on the Item. Modders should be careful and cache their renderers. (#4700)

commit a6bbc2761edbb37d36c9e4688ed4b64d2f50c0b4
Author: mezz <tehgeek@gmail.com>
Date:   Mon Mar 26 23:25:27 2018 -0700

    Add support for creator mod ID for modded enchanted books, potions, arrows, and spawn eggs (#4810)

commit 41f192155844a27fc497852fa63e84215ba7a3de
Author: LexManos <LexManos@gmail.com>
Date:   Mon Mar 26 19:41:07 2018 -0700

    Remove Mercurius from optional mods.

commit 12de748af0ba863d8f22a5edb82433b465e4b005
Author: CreativeMD <CreativeMD@users.noreply.github.com>
Date:   Sun Mar 25 07:56:24 2018 +0200

    Fixed sound engine crash when stopping streaming sounds (#4765)

commit f908c2e44982a14be185007aae27137181b50362
Author: LexManos <LexManos@gmail.com>
Date:   Fri Mar 23 20:42:33 2018 -0700

    Merge vanilla pre-decompile annotations with Forge's post-patching. Fixes #4769 Crash detail classes causing class not found errors.

commit 9d8bf87e93cf1289c595fd41a4d5ed7ab60be5b4
Author: malte0811 <malte0811@web.de>
Date:   Sat Mar 24 01:32:59 2018 +0100

    Fix NBT data loss when shift-clicking stacked items in the enchantment table (MC-17431) (#4817)

commit f9a26956626d977f9b820ecad3e5c4f6456baac5
Author: mezz <tehgeek@gmail.com>
Date:   Wed Mar 21 20:11:17 2018 -0700

    Update docs for ItemTooltipEvent

commit cf4325058401d20bd73fdfa49cb2d677aa644cd5
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Tue Mar 20 06:58:54 2018 +0100

    Fix some IResources being leaked (#4806)

commit 881aa67be7d3f6a6f90fb5a75f1071ac65526c54
Author: mezz <tehgeek@gmail.com>
Date:   Mon Mar 19 22:44:05 2018 -0700

    Fix server console logging issues

    Closes #4808

commit ae654edfc26f486f0d55bc4e01c20ea116fdebfa
Author: mezz <tehgeek@gmail.com>
Date:   Sat Mar 17 18:41:16 2018 -0700

    Fix up logging and log4j configuration (#4802)

commit 5ace86da121feafd20ed1f2d3e34ad99fee0599a
Author: Joseph C. Sible <josephcsible@users.noreply.github.com>
Date:   Sat Mar 17 01:54:23 2018 -0400

    Make lookupFluidForBlock work for flowing water and lava (#4675)

commit 4242f89c75d3d4a38737848a37383561eed8ec27
Author: Wyn Price <wynprice999@gmail.com>
Date:   Tue Mar 13 23:35:04 2018 +0000

    Patched BlockInfo#updateLightMatrix to use IBlockState#doesSideBlockRendering instead of Block#doesSideBlockRendering (#4798)

commit 6ed287984241109c1bfbe5b08c1fc28a22f54725
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Tue Mar 13 23:29:12 2018 +0000

    Fix integrated server crash not stopping client (#4796)

commit 752be6b526e162665ac16e20c161b38de4e745ea
Author: mezz <tehgeek@gmail.com>
Date:   Sun Mar 11 14:58:58 2018 -0700

    Fix #4792 TextComponentHelper handling for FakePlayers

commit dc459d6b868a0b1df521ca6e1a796bab136ff5aa
Author: ichttt <ichttt@users.noreply.github.com>
Date:   Thu Mar 1 20:00:48 2018 +0100

    Fix serverside startup failure when checking for vanilla acceptance (#4783)

commit 29fe38f72323c82534b6c65c35dab537bff326ef
Author: Ben Staddon <bs2609@users.noreply.github.com>
Date:   Tue Feb 27 06:13:17 2018 +0000

    Improve how smooth lighting code handles translucency (#4711)

commit 4e8b7803c521a451bd8ac5408d776130a3b353b5
Author: mezz <tehgeek@gmail.com>
Date:   Mon Feb 26 22:13:01 2018 -0800

    Prevent various vanilla blocks from loading unloaded chunks (#4689)

commit bdb65e9ed79b2e890d75eed932c919efe110ffd6
Author: mezz <tehgeek@gmail.com>
Date:   Mon Feb 26 22:05:08 2018 -0800

    Improve the "Mod rejections" error message when connecting to a server (#4761)

commit 18144b7a0a593e46bd170815ff7351ed84ecdcbc
Author: cpw <cpw+github@weeksfamily.ca>
Date:   Mon Feb 26 22:49:56 2018 -0500

    Fix the ForgeChunkManager to use the writebehind FileIO thread for writing (#4777)

    the chunk file. Closes #4775

    This is a performance tweak - doing File IO on the server thread during
    world saves causes significant lag spikes. This is one of many.

commit e29948949395b602121246f4cbc66f5b2d929d3b
Author: LexManos <LexManos@gmail.com>
Date:   Mon Feb 26 15:36:39 2018 -0800

    Fix vanilla crash classes not being preloaded. Closes #4769
    Fix classes not being aggregated for mods using the new annotation cache.

commit 49be9b273e2dae7b145f1200c41ae01d01f89e33
Author: Ben Staddon <bs2609@users.noreply.g…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alpvax Alpvax Alpvax left review comments

@williewillus williewillus williewillus left review comments

@mezz mezz mezz approved these changes

@tterrag1098 tterrag1098 tterrag1098 approved these changes

@liach liach liach approved these changes

Assignees

@mezz mezz

Labels
1.12 Assigned This request has been assigned to a core developer. Will not go stale. Feature This request implements a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mcenderdragon @liach @Alpvax @tterrag1098 @chagacy @mezz @williewillus @LexManos