[1.14.x] Update README badges to fix wrong version. #6141
Conversation
Version badges now use promotions.json Fixed Latest badge from displaying any latest build. (Set to 1.14.4 builds only) Added Stable badge, pulls from recommended key. Stable and Latest both have their same icons used on the files page. All badges are now capitalised and Patreon has it's logo back.
|
Also: What is the situation for moving 1.12.2 to Legacy? If it's confirmed to be legacy only, the version support table should be updated, however I've been waiting for a new RB before doing that. What are your thoughts @LexManos, should this PR include the marking of 1.12.2 as legacy, or should that wait? |
|
tterrag and I spoke about the possibility of either promotions.json having a "latest" part (like the recommended part) or promotions_slim.json having it along with the mc version, since at the moment we have to update the latest badge to the Minecraft version we want it to show (1.14.4-latest). And unfortunately we can't format the badges when using two fields/values. (Which is why they're split with a comma and not with a dash.) |
Changed version badge source to promotions_slim.json 1.12.x is now Legacy
|
The promotions.json no longer has a recommended key so I've changed the badges to use promotions_slim.json and just set the version to monitor. There's also a prefix so they display as "1.14.4-XX.XX.XX" Also 1.12.x is set to Legacy now. |
Version badges now use promotions.json
Fixed Latest badge from displaying any latest build. (Set to 1.14.4 builds only)
Added Stable badge, pulls from recommended key.
Stable and Latest both have their same icons used on the files page.
All badges are now capitalised and Patreon has it's logo back.
Since this is another readme/doc update, this opportunity should be taken to address any other issues related to the readme, please comment anything you think should be changed.
(You can see the badge changes here)