Add names reader for CSV zips #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These readers can be loaded with `IMappingNames#load`. Use with `IMappingFile#rename(IMappingNames)` to use the names loaded from those names.
Member
|
No, as discussed on discord I dont want to add the extra dependency, and this is outside the scope of 'just deal with mapping files' |
Member
Author
|
Yup, I've implemented this in ForgeDev directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CSV names readers. These readers can be loaded with
IMappingNames#load. Use withIMappingFile#rename(IMappingNames)to use the names loaded from those names.This functionality that was already implemented in ForgeGradle 6 and the Minecraft Mavenizer. I've done my best to keep the already existing code structure that SrgUtils is built off of.
Also, updated Gradle to 8.14.3 and updated the buildscripts to look like our newer stuff.