New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing regional proxies used by tournament API #6

Closed
Derpthemeus opened this Issue Jan 21, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@Derpthemeus
Copy link

Derpthemeus commented Jan 21, 2019

The tournament API uses the host americas.api.riotgames.com, which is not listed in the available platforms.

Reference: https://developer.riotgames.com/regional-endpoints.html

@MingweiSamuel

This comment has been minimized.

Copy link
Owner

MingweiSamuel commented Jan 21, 2019

Alright, should be an easy fix to add, taking a look now

@MingweiSamuel

This comment has been minimized.

Copy link
Owner

MingweiSamuel commented Jan 22, 2019

I'm considering adding

servers = [{
    url: 'https://americas.api.riotgames.com'
}]

(or similar) to each of the tournament endpoints which would override the default server platforms. Botty would need to be updated to check this field I assume

@MingweiSamuel

This comment has been minimized.

Copy link
Owner

MingweiSamuel commented Jan 29, 2019

I decided not to take this route and add them all to the global server variables. there's now a x-platforms-available field to show which endpoints are available per method

so this should be working for botty as soon as everything updates

@MingweiSamuel

This comment has been minimized.

Copy link
Owner

MingweiSamuel commented Jan 29, 2019

Note that this means botty will parse incorrect requests going to americas.api.riotgames.com for other endpoints (for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment