Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RavenDB to 3.0 #107

Closed
kamranayub opened this issue Apr 15, 2015 · 6 comments
Closed

Update RavenDB to 3.0 #107

kamranayub opened this issue Apr 15, 2015 · 6 comments

Comments

@kamranayub
Copy link
Contributor

Need to update RavenDB support for 3.0. Maybe just as separate project (MiniProfiler.RavenDb30) since it was a major upgrade.

@carlosagsmendes
Copy link

@kamranayub do you confirm that the current version doesn't support RavenDB 3?

@kamranayub
Copy link
Contributor Author

Yes, I have it running with 3.0 and I get no output.

On Tue, Apr 21, 2015, 20:06 carlosagsmendes notifications@github.com
wrote:

@kamranayub https://github.com/kamranayub do you confirm that the
current version doesn't support RavenDB 3?


Reply to this email directly or view it on GitHub
#107 (comment).

@carlosagsmendes
Copy link

Thank you for the heads up. +1

@yellis
Copy link
Member

yellis commented Aug 26, 2015

Closing this issue as it seems that the question was answered. If you want to provide a PR for Raven 3, I would be happy to include it.

@yellis yellis closed this as completed Aug 26, 2015
@kamranayub
Copy link
Contributor Author

So the main issue is in 3.0 something changed where the LogRequest event doesn't appear to have any HttpContext.Current (possibly due to some async context), so MiniProfiler.Current is always null. Otherwise this would work if I can access the current HttpContext from the event handler. I'm not sure how yet.

@kamranayub
Copy link
Contributor Author

I've fixed it for 3.0 and it's backwards compatible with 2.5. I am issuing a PR.

kamranayub added a commit to kamranayub/dotnet that referenced this issue Jan 18, 2016
NickCraver added a commit that referenced this issue May 20, 2016
[Closes #107] Add RavenDB 3.0 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants