Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Dot Net core getting started guide is unclear #363

Closed
roa-nyx opened this issue Feb 13, 2019 · 3 comments
Closed

Console Dot Net core getting started guide is unclear #363

roa-nyx opened this issue Feb 13, 2019 · 3 comments

Comments

@roa-nyx
Copy link

@roa-nyx roa-nyx commented Feb 13, 2019

https://miniprofiler.com/dotnet/ConsoleDotNetCore

There are two console examples one for ConsoleDotNet and another for ConsoleDotNetCore. One instructs you to install MiniProfiler and the DotNetCore instructs you to install MiniProfiler.AspNetCore.

I feel like either this is a mistake? Or if it's not that it needs to be explicitly called out as to why for DotNetCore you need to use a package labeled for AspNet in a console application.

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Feb 23, 2019

The example is correct - there is no .NET Core packages (because it's just too many packages). You could use MiniProfiler.Shared and do some manual bits, but thus far profiling console applications is rare enough that another package of packages and dependencies between .Shared and .AspNetCore isn't really warranted.

For what it's worth, MiniProfiler simple pre-dates .NET Core by many years. If it didn't exist back then, it'd have been called MiniProfiler.AspNet today. It retains the MiniProfiler name for ease of user upgrades. It is an ASP.NET with those bits just like MiniProfiler.AspNetCore is, though.

Loading

@roa-nyx
Copy link
Author

@roa-nyx roa-nyx commented Feb 25, 2019

Gotcha. Do you think it maybe it'd be good to have that explicitly called out in the .net core example? That even though it's a console example you still need to reference the AspNetCore package?

Loading

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Feb 25, 2019

Yeah sure, if that would help clarify things I'm all for it...that's the entire point of the samples after all :)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants