Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniProfiler 3 breaks TransactionScope and SynchronizationContext flow #419

Open
gaevoy opened this issue Sep 9, 2019 · 1 comment

Comments

@gaevoy
Copy link

commented Sep 9, 2019

MiniProfiler 3 affects on how TransactionScope and SynchronizationContext flow when ProfiledDbConnection, AsyncPump, ConfigureAwait(false) are used. I managed to reproduce the behavior difference in MiniProfilerReproductionTests.

MiniProfiler 4 does not have such side effect and works as expected.

More details I tried to describe in blog post.

@NickCraver

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

My suggestion would be to upgrade to MiniProfiler v4 for anyone doing async :) (or in generally really)

In short: v3 was not very async friendly, breaks or behaves oddly in a variety of ways around it (e.g. "what is the root timing?", and will not be getting any further updates. A lot of how it handled things necessitated a rewrite of the fundamentals to be async friendly, which happened in v4. If you're hitting this, please update!

@NickCraver NickCraver added the v3 Issue label Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.