Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniProfiler 3 breaks TransactionScope and SynchronizationContext flow #419

Closed
gaevoy opened this issue Sep 9, 2019 · 2 comments
Closed

MiniProfiler 3 breaks TransactionScope and SynchronizationContext flow #419

gaevoy opened this issue Sep 9, 2019 · 2 comments
Labels

Comments

@gaevoy
Copy link

@gaevoy gaevoy commented Sep 9, 2019

MiniProfiler 3 affects on how TransactionScope and SynchronizationContext flow when ProfiledDbConnection, AsyncPump, ConfigureAwait(false) are used. I managed to reproduce the behavior difference in MiniProfilerReproductionTests.

MiniProfiler 4 does not have such side effect and works as expected.

More details I tried to describe in blog post.

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Sep 10, 2019

My suggestion would be to upgrade to MiniProfiler v4 for anyone doing async :) (or in generally really)

In short: v3 was not very async friendly, breaks or behaves oddly in a variety of ways around it (e.g. "what is the root timing?", and will not be getting any further updates. A lot of how it handled things necessitated a rewrite of the fundamentals to be async friendly, which happened in v4. If you're hitting this, please update!

Loading

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Sep 21, 2019

I'm going to close this out since it's solved in v4, but if you're still hitting issues there please shout!

Loading

@NickCraver NickCraver closed this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants