Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin for Entity Framework Classic 7 #397

Merged
merged 2 commits into from Jul 20, 2019
Merged

plugin for Entity Framework Classic 7 #397

merged 2 commits into from Jul 20, 2019

Conversation

@JendaPerl
Copy link
Contributor

@JendaPerl JendaPerl commented Jun 30, 2019

I've just made a copy of the Miniprofiler.EF6 as Miniprofiler.EFC7 and tweaked it to reference and use the https://entityframework-classic.net/ instead of the official EF 6. Not sure what needs to be done to get a nuget package, but the obtained MiniProfiler.EFC7.dll does work with the current Miniprofiler and EFC 7.1.9.

The initialization just needs to be changed to

StackExchange.Profiling.EntityFrameworkClassic7.MiniProfilerEFC7.Initialize();
in place of
StackExchange.Profiling.EntityFramework6.MiniProfilerEF6.Initialize();

I would very much appreciate if anyone could finish whatever needs to be done to end up with a nuget.

@JendaPerl
Copy link
Contributor Author

@JendaPerl JendaPerl commented Jul 2, 2019

What the what?

no matching manifest for windows/amd64 10.0.17134 in the manifest list entries
##[warning]Docker pull failed with exit code 1, back off 3.444 seconds before retry.
##[command]C:\Program Files\Docker\docker.EXE pull redis
Using default tag: latest
no matching manifest for windows/amd64 10.0.17134 in the manifest list entries
latest: Pulling from library/redis
##[warning]Docker pull failed with exit code 1, back off 3.905 seconds before retry.
##[command]C:\Program Files\Docker\docker.EXE pull redis
Using default tag: latest
no matching manifest for windows/amd64 10.0.17134 in the manifest list entries
latest: Pulling from library/redis
##[error]Docker pull failed with exit code 1

It seems setting up the tests failed before anything I did came to play.

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Jul 20, 2019

I was getting netcoreapp3.0 initial bits working (which conflicted) - going to try and update some of these PRs to work :)

Copy link
Member

@NickCraver NickCraver left a comment

Looking good after a master merge - I'll try and get packages added in the next NuGet release.

Thank you for the contribution!

@NickCraver NickCraver merged commit b63599c into MiniProfiler:master Jul 20, 2019
2 checks passed
@JendaPerl
Copy link
Contributor Author

@JendaPerl JendaPerl commented Jul 31, 2019

I noticed that I've made a typo in the readme. I suggest install of Miniprofiler.EFC76 instead of Miniprofiler.EFC7. Could you fix this or change it to whatever you decide to call the package?
I think that's easier than going through the exercise of forking and creating a pull request for a one character change. :-)

Thanks!

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Aug 1, 2019

Done in c3c66d3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants