Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySqlConnector to 0.60.1 #432

Merged
merged 1 commit into from Oct 27, 2019

Conversation

bgrainger
Copy link
Contributor

@bgrainger bgrainger commented Oct 21, 2019

MySqlConnector 0.30.0 is quite old; it seems like it would be best to use the latest version, which has the latest bug fixes and performance enhancements.

(MySqlConnector 0.30.0 is the oldest strong-named version, so if you want to rely on the oldest possible version that is compatible with anything your users want to upgrade to, then I understand if you want to close this PR. I just think it would be best to install the latest good version by default.)

Copy link
Member

@NickCraver NickCraver left a comment

Good call - thanks!

@NickCraver
Copy link
Member

@NickCraver NickCraver commented Oct 22, 2019

Change looks good but let me visit this tonight and see about the strong naming and where things are. Are the plans to strong name future versions?

@bgrainger
Copy link
Contributor Author

@bgrainger bgrainger commented Oct 23, 2019

Sorry for being unclear.

The first version of MySqlConnector that was strong-named was 0.30.0. The latest (0.60.2) continues to be strong-named. I was trying to say that if you wanted to stick with the lowest-possible version number (for broadest compatibility...?), then 0.30.0 is good. But 0.60.2 hasn't dropped any TFMs, so I don't think there's really any reason not to upgrade.

Also, I just shipped a bugfix so I bumped this branch to 0.60.2.

@NickCraver NickCraver merged commit 443f10e into MiniProfiler:master Oct 27, 2019
3 checks passed
@NickCraver
Copy link
Member

@NickCraver NickCraver commented Oct 27, 2019

Pulling in - thanks again! :) You're a saint for maintaining so much around this driver <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants