Update MySqlConnector to 0.60.1#432
Merged
NickCraver merged 1 commit intoMiniProfiler:masterfrom Oct 27, 2019
Merged
Conversation
Member
|
Change looks good but let me visit this tonight and see about the strong naming and where things are. Are the plans to strong name future versions? |
bgrainger
force-pushed
the
mysqlconnector-0.60.1
branch
from
7735001 to
3594ef2
Compare
Contributor
Author
|
Sorry for being unclear. The first version of MySqlConnector that was strong-named was 0.30.0. The latest (0.60.2) continues to be strong-named. I was trying to say that if you wanted to stick with the lowest-possible version number (for broadest compatibility...?), then 0.30.0 is good. But 0.60.2 hasn't dropped any TFMs, so I don't think there's really any reason not to upgrade. Also, I just shipped a bugfix so I bumped this branch to 0.60.2. |
Member
|
Pulling in - thanks again! :) You're a saint for maintaining so much around this driver <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySqlConnector 0.30.0 is quite old; it seems like it would be best to use the latest version, which has the latest bug fixes and performance enhancements.
(MySqlConnector 0.30.0 is the oldest strong-named version, so if you want to rely on the oldest possible version that is compatible with anything your users want to upgrade to, then I understand if you want to close this PR. I just think it would be best to install the latest good version by default.)