Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Changes: Removing jQuery #442

Merged
merged 9 commits into from Dec 14, 2019
Merged

Library Changes: Removing jQuery #442

merged 9 commits into from Dec 14, 2019

Conversation

NickCraver
Copy link
Member

@NickCraver NickCraver commented Nov 30, 2019

This removes the jQuery bundling and dependency, taking the raw size from 133KB down to 48.3KB.

Upsides:

  • Smaller payload
  • Fewer dependencies

Downsides:

  • More maintenance/direct code in vailla JS/TS
  • No IE <= 11 Support (I'll try this next without fetch and see what the diff is)

This also upgrades the TypeScript compiler and minifier which wasn't handling ES6 well. But this is a work-in-progress. Committing here because this is a stable and working ES6 version.

Nick Craver added 5 commits Nov 30, 2019
This removes the jQuery bundling and dependency, taking the raw size from 133KB down to 48.3KB.

Upsides:
- Smaller payload
- Fewer dependencies

Downsides:
- More maintenance/direct code in vailla JS/TS
- No IE <= 11 Support (I'll try this next without fetch and see what the diff is)

This also upgrades the TypeScript compiler and minifier which wasn't handling ES6 well. But this is a work-in-progress. Committing here because this is a stable and working ES6 version.
Shifting images is a PITA.
@NickCraver NickCraver mentioned this pull request Nov 30, 2019
@NickCraver NickCraver marked this pull request as ready for review Dec 14, 2019
@NickCraver NickCraver merged commit 1655a62 into master Dec 14, 2019
@NickCraver NickCraver mentioned this pull request Jan 20, 2020
@NickCraver NickCraver deleted the craver/jquery-less branch Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants