Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work on ASP.NET Core timings #482

Merged
merged 13 commits into from May 25, 2020
Merged

Conversation

NickCraver
Copy link
Member

@NickCraver NickCraver commented May 11, 2020

This is a stab, may change a lot...getting it up for tweaking. Trying to repro the negative timing issue we see in Stack Overflow.

This is a stab, may change a lot...getting it up for tweaking. Trying to repro the negative timing issue we see in Stack Overflow.
@NickCraver NickCraver added bug enhancement .net-core labels May 11, 2020
NickCraver added 12 commits May 24, 2020
Gotta figure out stack slicing off the top here yet...but some progress in an uber debug mode for things.
This sets the parent profiler to where it should be when adding a new timing, even in the case of stack unwinds further up which hide our understanding of a previous head reset further down due to an AsyncLocal<Timing> mismatch on the head. Now as a safety we roll up to the parent and get the right tree even with MVCs frame-saving shenanigans. Woohoo!

Good god that was hard to figure out.
@NickCraver NickCraver marked this pull request as ready for review May 24, 2020
Copy link
Member Author

@NickCraver NickCraver left a comment

Changes complete!

@NickCraver NickCraver merged commit ff8b503 into master May 25, 2020
1 check passed
@NickCraver NickCraver deleted the craver/aspnetcore-timings branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement .net-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant