Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to RavenDB 4.1 storage for MiniProfiler #483

Merged
merged 20 commits into from May 25, 2020

Conversation

lillo42
Copy link
Contributor

@lillo42 lillo42 commented May 15, 2020

Adding support to RavenDb 4.1 Storage on MiniProfiler

@NickCraver
Copy link
Member

NickCraver commented May 15, 2020

Heyyyy awesome, it looks like they're strongly naming the client now which means this is viable! That was the main blocker before :)

The compose and such is a great addition too - there's more bits I wanted to add there already so this is a great motivator. I'll try and dig in this weekend!

Copy link
Member

@NickCraver NickCraver left a comment

Changes are looking great! I consolidated some bits, matched conventions in a few places, and expanded the docket-compose for more providers (as well as added RavenDB to GitHub Actions). Thanks for firing this up and getting the docker bits moving. Merging in for the 4.2 release!

@NickCraver NickCraver merged commit 45e6fa3 into MiniProfiler:master May 25, 2020
2 checks passed
@NickCraver NickCraver changed the title Adding support to RavenDb 4.1 Storage on MiniProfiler Adding support to RavenDB 4.1 storage for MiniProfiler May 25, 2020
@lillo42 lillo42 deleted the update-raven-db branch May 25, 2020
query = query.Where(x => x.Started <= finish.Value);
}

query.Take(maxResults);
Copy link
Contributor

@JesperTreetop JesperTreetop May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be query = query.Take(maxResults);?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants