Adding support to RavenDB 4.1 storage for MiniProfiler #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heyyyy awesome, it looks like they're strongly naming the client now which means this is viable! That was the main blocker before :) The compose and such is a great addition too - there's more bits I wanted to add there already so this is a great motivator. I'll try and dig in this weekend! |
More closely match the other libraries and namespaces :)
Yay, so handy
Need to get Rafael's name on all this work!
NickCraver
approved these changes
May 25, 2020
There was a problem hiding this comment.
Changes are looking great! I consolidated some bits, matched conventions in a few places, and expanded the docket-compose for more providers (as well as added RavenDB to GitHub Actions). Thanks for firing this up and getting the docker bits moving. Merging in for the 4.2 release!
NickCraver
changed the title
| query = query.Where(x => x.Started <= finish.Value); | ||
| } | ||
|
|
||
| query.Take(maxResults); |
There was a problem hiding this comment.
Shouldn't this be query = query.Take(maxResults);?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to RavenDb 4.1 Storage on MiniProfiler